From patchwork Wed Mar 15 06:18:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Kuai X-Patchwork-Id: 70008 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2164037wrd; Tue, 14 Mar 2023 23:21:53 -0700 (PDT) X-Google-Smtp-Source: AK7set9+9c7hPZ6+qHAs7AfsTA0hAF/R1ZDdret/YHQdhymTPW6dFL+I8rgKLsLZ6Q4JB9gyW8iy X-Received: by 2002:a17:90b:4d07:b0:237:ae98:a47f with SMTP id mw7-20020a17090b4d0700b00237ae98a47fmr16400089pjb.1.1678861313573; Tue, 14 Mar 2023 23:21:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678861313; cv=none; d=google.com; s=arc-20160816; b=lBDmgW+ECzXb0k36vZxNb6WUHqZ+S2GRUvGNuX53/7WWqDphZlVHG0e8lhaZhfB5xv ckeuRG3ClaGYpphm+qhPLc35pFLYvYePTCev+B6C3U5J+1ABd9h01vpZTqszVB/jWNfY QIq3oPYG1EFPye3KdD4qowje0n2SnK44ELq8vfMfiF05/pKYB3sYtpPgU2B86Rjz8tHv 6o5zyf2+4HqXqzPQ4YrAHI539TZ0tY9xhfAQUcGaimouegwhCZIMdSRjQIuKvKWhXRPP OCgcrMFXQPTIpZXVJafnsuTSUCs2Jk8NYichZqHpFcxpQLp2nxeUX4CDu5K/eXDnV2PI K/tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=DKX7+fw/bVlv5vDS2XyxXTqd72I0w0iD9oD9dR/CS8E=; b=yWcHw9thgZ3tMy8BLp48JWeh4kjcGshMPpZBPL8oswKSXa7wFvargKiZCzLGxMlsYA rdfo6DAPAWhQzkhVH37WtjQuZVDe1l+p9/y5z25DvXPLFhrXoDIpvOx++Kpk8d36Q4qR 46eGm0yEtwqJJYyny0aofF5k8KDwBGyTZQOmwmpxn5ZeU2g7s3vUY7HZM2THYaOs7+7I plIl+3lmzShZtRHJsfEY0E8eoeNLe9yEj3XrcA0Kt5NjNW1vwkekqQtjol8XMBw0G+dJ WR23EqlEEei0wH0s8K+wVn5pTBTRnhrattOG+dnXw3xGt+AyntmXBz4bRoKQNGb/NIMo nU7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z13-20020a170903018d00b0019a9b869bfasi5051054plg.75.2023.03.14.23.21.38; Tue, 14 Mar 2023 23:21:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231195AbjCOGTJ (ORCPT + 99 others); Wed, 15 Mar 2023 02:19:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230447AbjCOGTB (ORCPT ); Wed, 15 Mar 2023 02:19:01 -0400 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AD2026C26; Tue, 14 Mar 2023 23:18:59 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.169]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Pc0b30hg3z4f4cFl; Wed, 15 Mar 2023 14:18:55 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.127.227]) by APP3 (Coremail) with SMTP id _Ch0CgCnUyFNYxFklvvMEw--.20241S7; Wed, 15 Mar 2023 14:18:56 +0800 (CST) From: Yu Kuai To: agk@redhat.com, snitzer@kernel.org, song@kernel.org Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: [PATCH v2 3/5] md: use md_thread api to wake up sync_thread Date: Wed, 15 Mar 2023 14:18:08 +0800 Message-Id: <20230315061810.653263-4-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230315061810.653263-1-yukuai1@huaweicloud.com> References: <20230315061810.653263-1-yukuai1@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: _Ch0CgCnUyFNYxFklvvMEw--.20241S7 X-Coremail-Antispam: 1UD129KBjvJXoW7Ar47Jw4rGw13JFWkXw4rAFb_yoW8WFy7pa yxAF95ur10yry3ZFZxJa4qva4rXF10q342vry7ua1rJw15tw45tFy3ury8AryvvayfAw45 Zw1rtFWxuFs29r7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9m14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JrWl82xGYIkIc2 x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0 Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJw A2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS 0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2 IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0 Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCF04k20xvY0x0EwIxGrwCFx2 IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v2 6r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67 AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IY s7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr 0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUd8n5UUUUU= X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS, MAY_BE_FORGED,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760413681131283288?= X-GMAIL-MSGID: =?utf-8?q?1760413681131283288?= From: Yu Kuai Instead of wake_up_process() directly, convert to use md_wakeup_thread(). Signed-off-by: Yu Kuai --- drivers/md/md.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index 97e87df4ee43..4ecfd0508afb 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -6267,10 +6267,12 @@ static int md_set_readonly(struct mddev *mddev, struct block_device *bdev) } if (test_bit(MD_RECOVERY_RUNNING, &mddev->recovery)) set_bit(MD_RECOVERY_INTR, &mddev->recovery); - if (mddev->sync_thread) - /* Thread might be blocked waiting for metadata update - * which will now never happen */ - wake_up_process(mddev->sync_thread->tsk); + + /* + * Thread might be blocked waiting for metadata update + * which will now never happen + */ + md_wakeup_thread(&mddev->sync_thread, mddev); if (mddev->external && test_bit(MD_SB_CHANGE_PENDING, &mddev->sb_flags)) return -EBUSY; @@ -6331,10 +6333,12 @@ static int do_md_stop(struct mddev *mddev, int mode, } if (test_bit(MD_RECOVERY_RUNNING, &mddev->recovery)) set_bit(MD_RECOVERY_INTR, &mddev->recovery); - if (mddev->sync_thread) - /* Thread might be blocked waiting for metadata update - * which will now never happen */ - wake_up_process(mddev->sync_thread->tsk); + + /* + * Thread might be blocked waiting for metadata update + * which will now never happen + */ + md_wakeup_thread(&mddev->sync_thread, mddev); mddev_unlock(mddev); wait_event(resync_wait, (mddev->sync_thread == NULL &&