From patchwork Tue Mar 14 22:07:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 69860 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2010559wrd; Tue, 14 Mar 2023 15:15:37 -0700 (PDT) X-Google-Smtp-Source: AK7set++QHLOXd0AGgJLb0ECe95pbjD0ZujJ2EHsMxogzf8sZttEEuDGFydbZebguSUtA0gzBPkK X-Received: by 2002:a17:90b:4f8e:b0:23d:536f:fca5 with SMTP id qe14-20020a17090b4f8e00b0023d536ffca5mr694606pjb.0.1678832136910; Tue, 14 Mar 2023 15:15:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678832136; cv=none; d=google.com; s=arc-20160816; b=Ha0s4+igiVg1k5LqCY7e9uoRRZn+qptqWDl53/vcMildTPTyIseQ3UGbWZn7OemIq5 jQWDLwkoxBrUYhelrZFlESGB11qQOFSwemUNGslKYY++Sk21xmDjzXZpuZFBhvZQUqYk 8PhM/1fGbawkQbxzEuawX4pN0DcFld1Qeszljcdy4+B/Xk07+K/p9zitdTCS3lo2bWDN W5A2smpNSf3syjNBzoMyEubB4f8zs13wefW2Gc/DYEnQEmTJk0grXhST0nIAcSFH2Er5 eTOBkUK5pCWUk6yClO7q5mE4mErTBn+JYBfnX9+G/O/qV+E+nzBKjP9tkuwbDKT3L6ke eedQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=w0CyxxuCfKyDxUhqZI8uZNDs4yTA+LT97JFfaSxmf5E=; b=N95eQ55pAHFSl8MZxe83wDu85w2fBZga/fAFksFCu3JzDNbnVKB5zRG9xeVcJQXAED tq4NlgqOh780FTcZF1lCBm5eW5tIYZWkHMV+qC6fb6xL4Lu+gaJDgt8Zl1joP+FjoljE Yhv+X65Q++qS8kuafdRk9D4SsCPDJs2n0OnymDG2eWNjnKNGJQEpdTDX/ozHff5/by3/ e8yZeq9hCcEkZTa1YDg9Xmd0HZylYN6HgITz70Y5HMpgVS7VFbX9DVDE4lq4pf8TS5Np aMImWdO5AASlDdz0IzF4aS4fvMWNmYVWpPc6Q2iadj4fe5dv/cfMETQxK5v+hCEan13f ZZXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jGO+JF8t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mm6-20020a17090b358600b002309f0bd759si3282321pjb.92.2023.03.14.15.15.24; Tue, 14 Mar 2023 15:15:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jGO+JF8t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231381AbjCNWKR (ORCPT + 99 others); Tue, 14 Mar 2023 18:10:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbjCNWJk (ORCPT ); Tue, 14 Mar 2023 18:09:40 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D68325B9D for ; Tue, 14 Mar 2023 15:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678831721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w0CyxxuCfKyDxUhqZI8uZNDs4yTA+LT97JFfaSxmf5E=; b=jGO+JF8t5z7V5YiIZPAp/yx8bj7HjaS0bCOJPrIQiwA2Q2FwsY2Ds9rlNGRlmNbO6otXG/ 5jnitxinVWM0dKqhs4duXcBuO3Lb5G1RiuUPyPZROhJWE9C0nCciT530DbZV/c9FdQ3TRO 3xir+95PugJTVLWj8NniZoLop79vIYQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-240-WXoXZ4YbN7yQ7YG_W8vEZA-1; Tue, 14 Mar 2023 18:08:38 -0400 X-MC-Unique: WXoXZ4YbN7yQ7YG_W8vEZA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 34E3B85D062; Tue, 14 Mar 2023 22:08:37 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 042542166B26; Tue, 14 Mar 2023 22:08:34 +0000 (UTC) From: David Howells To: Jens Axboe , Al Viro , Christoph Hellwig Cc: David Howells , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard , Dave Chinner , Christoph Hellwig Subject: [PATCH v18 10/15] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Date: Tue, 14 Mar 2023 22:07:52 +0000 Message-Id: <20230314220757.3827941-11-dhowells@redhat.com> In-Reply-To: <20230314220757.3827941-1-dhowells@redhat.com> References: <20230314220757.3827941-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760383087054759681?= X-GMAIL-MSGID: =?utf-8?q?1760383087054759681?= ZERO_PAGE can't go away, no need to hold an extra reference. Signed-off-by: David Howells Reviewed-by: David Hildenbrand Reviewed-by: John Hubbard Reviewed-by: Dave Chinner Reviewed-by: Christoph Hellwig cc: Al Viro cc: linux-fsdevel@vger.kernel.org --- fs/iomap/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index f771001574d0..850fb9870c2f 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, bio->bi_private = dio; bio->bi_end_io = iomap_dio_bio_end_io; - get_page(page); + bio_set_flag(bio, BIO_NO_PAGE_REF); __bio_add_page(bio, page, len, 0); iomap_dio_submit_bio(iter, dio, bio, pos); }