From patchwork Tue Mar 14 20:39:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 69831 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1975981wrd; Tue, 14 Mar 2023 13:46:43 -0700 (PDT) X-Google-Smtp-Source: AK7set8wWiLINd1AFvXnz8+3RT7gPwlzWPHte3tX4zhPg8ZKewdBhtYX4VISva1cCqjMLa1K7vXc X-Received: by 2002:a05:6a20:3c87:b0:d5:7f0b:f2f with SMTP id b7-20020a056a203c8700b000d57f0b0f2fmr4101851pzj.26.1678826803022; Tue, 14 Mar 2023 13:46:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678826803; cv=none; d=google.com; s=arc-20160816; b=H/FtXM6jkeafB2/CT9aodZrmZrqtHzHfnp0tYzudGj7U6TlJEvoLlRondZT9Hr0+ea SN66Iq35EPMLGX4yjsUI0cuY04cfkHzN2wnjc0yqyE0cWQe9iN8CwHMaQDjPqURiQZCj T/VPaLOrgVN+1PByc9K1FU/Ou3QOF9IhRiSyclBkPjWKQGSXCWfv/vGIQJG42g9w03oK /Y+bC/sFSHQN5LFMGfhOv860KiK8HjDWEuBZkMitcPAEpXGFIhrFoEsBZbExI5Wt8KMI DlF9eHqBgakuZGH8cNrWgdqdDpAiX02Y7Nhso9DbA6v6mOO/R15r/SXGDo55TnvZSyDi bSSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gAVzGC5admqQWUbt0SvNwXRFrLei9CHekAmYZ2wD2pE=; b=nJHB7zr8/CDnREmuH/8jzqZTyKurzvYwgaNzteCnoJrarZeTSPhhQE2fW9AP/pSUOy 3HIELeEYQAt5wxvSauXTelm+Uj3U2TqaF9QgOHvOBBs8vtmSDYYHAkb7HNo+vU8f6Lml fbwa2pjz+e8GTUmmroWJfaCBbWkp14p4us3hmodU0jCX2OCrlC9vcdFFFpwaNXMowOzY k2qp8ge+d8Ncr8j5dH7cBmfmK8tFobxpjst3qQwoGkQkBYRXe6PBEzwTfuw0aVw9YPvQ ecb5jpoS1SoyELP2ALY690rMtgNBJkS7drtfXNAlaz+HZHu//TlMVT2ypWli5bU6bE2u EbsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iEGaDl55; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q24-20020aa79838000000b005a91a8ab300si3077895pfl.83.2023.03.14.13.46.27; Tue, 14 Mar 2023 13:46:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iEGaDl55; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229930AbjCNUji (ORCPT + 99 others); Tue, 14 Mar 2023 16:39:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231288AbjCNUj2 (ORCPT ); Tue, 14 Mar 2023 16:39:28 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E120C4609C for ; Tue, 14 Mar 2023 13:39:07 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id eh3so11314812edb.11 for ; Tue, 14 Mar 2023 13:39:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678826344; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gAVzGC5admqQWUbt0SvNwXRFrLei9CHekAmYZ2wD2pE=; b=iEGaDl55qfyDycFXah/KYYvnNFfJlhE8QFNkKfpu+UkuOIJFyUAr/jtuFroupg2M0d 5qZj+7snyHp7ocmSIRrghLGPxxS2RTBF6VaxOY286yXYU15gNWOrTv2hGrhl0ccUfCOE N4wWiN5NIF+aHTNM6/9zwDQrnlOdKLya9+rScVcdNLd4KdpEoqU2qjp2R+USlRqrMyKT rsib9f6bfzGEz7logItZ5Ex9QjD6Zbbp0BQbQYrqJw2zx5D93eqHp/emSwumSO12bXkn TdCsYjCxXB0qhEluMT78xtIjyOGVZswdIBGPXQ43qEnxPTbO/Cyg/qtCpIrpH9lpYCaM Pitw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678826344; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gAVzGC5admqQWUbt0SvNwXRFrLei9CHekAmYZ2wD2pE=; b=TnuOSDVN/iO1DQLR8NG9qrb7qbH3p8VUohR0QykZTU7k32ZFziZ/dOqbmy2y3KvVay PyDbya5irf/Pygix8XRcq5MrBclFzTVGZ5U9zxp/pKggj9uTav0/3pxEnpjkJljs9ruZ 1Zol9+NDnZnCpwuitNHaeoVq0sQhi6fGKkngTfTtpTjbJCA/y57bbhlvaKx6wFCV22Uu 5zzSHgYV+96oy83saf/hjoUlWWuRmRi7K1cXCplpVQtRorZDfqgGxV0y6UU5e5ufW4eW mfsoHnosGXw/c6Jj5VEVJhnOriwQ8PDpeAU2kiYS7HRtWn3z4bXaiIpUAHZguLDir6iD V5NQ== X-Gm-Message-State: AO0yUKX1hyU7VX4Og0MTVTWqb/WZbmDUNDSCg7q4lthoKyCX6vk0gO+9 0Gw4mQQmgO0tSxToi3CG8geftQ== X-Received: by 2002:a17:906:e093:b0:8b1:7e88:c20f with SMTP id gh19-20020a170906e09300b008b17e88c20fmr4486277ejb.15.1678826344267; Tue, 14 Mar 2023 13:39:04 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:642b:87c2:1efc:c8af]) by smtp.gmail.com with ESMTPSA id k18-20020a1709060cb200b008d68d018153sm1579768ejh.23.2023.03.14.13.39.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 13:39:03 -0700 (PDT) From: Krzysztof Kozlowski To: Adrian Hunter , Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2] mmc: sdhci: drop useless sdhci_get_compatibility() !OF stub Date: Tue, 14 Mar 2023 21:39:01 +0100 Message-Id: <20230314203901.20803-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760377493953090475?= X-GMAIL-MSGID: =?utf-8?q?1760377493953090475?= The sdhci_get_compatibility() uses OF functions which have stubs for !OF case, thus entire CONFIG_OF ifdef can be dropped. This also fixes !CONFIG_OF W=1 warning: drivers/mmc/host/sdhci-pltfm.c:76:6: error: no previous prototype for ‘sdhci_get_compatibility’ [-Werror=missing-prototypes] Signed-off-by: Krzysztof Kozlowski Acked-by: Adrian Hunter --- Changes since v1: 1. Drop the stub (Ulf) --- drivers/mmc/host/sdhci-pltfm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c index 328b132bbe57..673e750a8490 100644 --- a/drivers/mmc/host/sdhci-pltfm.c +++ b/drivers/mmc/host/sdhci-pltfm.c @@ -54,7 +54,6 @@ static bool sdhci_wp_inverted(struct device *dev) #endif /* CONFIG_PPC */ } -#ifdef CONFIG_OF static void sdhci_get_compatibility(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); @@ -72,9 +71,6 @@ static void sdhci_get_compatibility(struct platform_device *pdev) of_device_is_compatible(np, "fsl,mpc8536-esdhc")) host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL; } -#else -void sdhci_get_compatibility(struct platform_device *pdev) {} -#endif /* CONFIG_OF */ void sdhci_get_property(struct platform_device *pdev) {