From patchwork Tue Mar 14 19:26:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 69820 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1943952wrd; Tue, 14 Mar 2023 12:28:43 -0700 (PDT) X-Google-Smtp-Source: AK7set+ghIL1RA4bAiAZBPHcMvO6F605WU4vVRbi5KSkb6K+sto4iG5QLf01kTK5k2kpFun0BzNN X-Received: by 2002:a05:6a20:a8a7:b0:d3:c1c4:5e37 with SMTP id ca39-20020a056a20a8a700b000d3c1c45e37mr7595894pzb.53.1678822122734; Tue, 14 Mar 2023 12:28:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678822122; cv=none; d=google.com; s=arc-20160816; b=oOBMrdsQBlLLpJfM5xnUMJ5jiLtE9jw0M39JpDhuEtU2jgh9Tjftp6/Yz6n7r1Vz/Z Rtsgw6nv4lmqECjM3AZYU7LyWxAsJ+I0pgIkpNjLeHXyBcDCcz6zB5v2iPhF6khnm7LU mUG7CIg/Oy2/EwH3ZulurjQDNi8+Q3go25l1mYKIM4jnasY1WDA2Koj4Yte6pH719pVv b+FKEyAwayAW71qN3A3f1ET0HsAX38EHuYbDLWsqIL5Pv/6ubyR+Ak04+nJJd604Fk9J 62Frupa1BVsHZ47ydV4HhjzZQnIQLCUAp+fgXRCxNaE8gOy0+rP/rJysQBQlqiw1OTRL ivhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=uGy73J8PN36RGUWXkk9NgU+l5Ua5i6MonmZmSoLXPaA=; b=tmxIKgNRY66386a4G9pm3WuJ7cChkPEZ5vfktQbamNSlbjbMgGSnSET4mFZaNHUGTk VSSjGchy+M9tM52h3UyXqnGyilns4yU/I0kNo3i1F/N6NbzidhZ9ctW/bHWdPVor7Zm5 JMi1AYeEYglvoOcfBNbUpcZDjwVKJ8WWejE6eOWAZhdid+V4yMFS5aLMzlvGv9aYL/HN +QmQBAHdBjPNvBoNIfTlW1DSgePTFvr7HYnpUlblmKho5KCUTqdl0kYjEGEl4cuIkK3d HOx/AE+8sjs+LHX/w5IA31Todtw/RmNWczOD3+UsG9jficawGKHuktViQ1ul43k4aYxW XlFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LDHidmpg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 33-20020a631061000000b0050bbfeba6f4si2698102pgq.582.2023.03.14.12.28.30; Tue, 14 Mar 2023 12:28:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LDHidmpg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229525AbjCNT0n (ORCPT + 99 others); Tue, 14 Mar 2023 15:26:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230208AbjCNT0L (ORCPT ); Tue, 14 Mar 2023 15:26:11 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2BF62D78; Tue, 14 Mar 2023 12:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678821970; x=1710357970; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=w+YdvYGhoz+V3BkfBUt2y8DW6u+jmfOhlK0R9Fvr/bI=; b=LDHidmpgIP5gQ08E79DB12qSsTvCSUxd5oE1FFL1akuVWrU1WW/jpUQ7 j050GSpKdv61Gevu1hYh7HMyQLrturr6nTaYDSGnc+uY2hJtxnY+gXvyN vmw2oZ+XLp68NDB3m/crAAjkbTrULGlL4dn0UC1gIhzEW9hf6MoLSoXmX Ysb34ip1kRqi2xQgCXQOCoTpQ7CVDW4DIWw8gb96GvOJVZCJrwQfwokFL Y1dBVxcDEHn/2/EBT6o+nJnnqYBUFAnKJpdShP4iW8vaD1k0gGFFodXB5 6BkIbYf6JFO5I2KAps247zvxgV7/nUPMI1czjv6MgudKpFMy2NqB2HXVt Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="402389803" X-IronPort-AV: E=Sophos;i="5.98,260,1673942400"; d="scan'208";a="402389803" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2023 12:26:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="656474982" X-IronPort-AV: E=Sophos;i="5.98,260,1673942400"; d="scan'208";a="656474982" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga006.jf.intel.com with ESMTP; 14 Mar 2023 12:25:52 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id A3CFB93; Tue, 14 Mar 2023 21:26:37 +0200 (EET) From: Andy Shevchenko To: =?utf-8?q?Micka=C3=ABl_Sala=C3=BCn?= , Mika Westerberg , =?utf-8?q?Krzysztof_Wilc?= =?utf-8?q?zy=C5=84ski?= , Andy Shevchenko , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Niklas Schnelle , Bjorn Helgaas , "Rafael J. Wysocki" , =?utf-8?q?Pali_Roh=C3=A1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , Anatolij Gustschin , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH v5 3/4] EISA: Convert to use pci_bus_for_each_resource_p() Date: Tue, 14 Mar 2023 21:26:33 +0200 Message-Id: <20230314192634.63531-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230314192634.63531-1-andriy.shevchenko@linux.intel.com> References: <20230314192634.63531-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760372586227009896?= X-GMAIL-MSGID: =?utf-8?q?1760372586227009896?= The pci_bus_for_each_resource_p() hides the iterator loop since it may be not used otherwise. With this, we may drop that iterator variable definition. Signed-off-by: Andy Shevchenko Reviewed-by: Krzysztof Wilczyński --- drivers/eisa/pci_eisa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/eisa/pci_eisa.c b/drivers/eisa/pci_eisa.c index 930c2332c3c4..907b86384396 100644 --- a/drivers/eisa/pci_eisa.c +++ b/drivers/eisa/pci_eisa.c @@ -20,8 +20,8 @@ static struct eisa_root_device pci_eisa_root; static int __init pci_eisa_init(struct pci_dev *pdev) { - int rc, i; struct resource *res, *bus_res = NULL; + int rc; if ((rc = pci_enable_device (pdev))) { dev_err(&pdev->dev, "Could not enable device\n"); @@ -38,7 +38,7 @@ static int __init pci_eisa_init(struct pci_dev *pdev) * eisa_root_register() can only deal with a single io port resource, * so we use the first valid io port resource. */ - pci_bus_for_each_resource(pdev->bus, res, i) + pci_bus_for_each_resource_p(pdev->bus, res) if (res && (res->flags & IORESOURCE_IO)) { bus_res = res; break;