From patchwork Tue Mar 14 13:14:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 69621 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1758333wrd; Tue, 14 Mar 2023 06:29:45 -0700 (PDT) X-Google-Smtp-Source: AK7set/bAl67uMsh5keKeUyYIChGT3CZPc32d0WenyKRa56gkvvn37lH44ZxxptC5LbD5cxiM2Zm X-Received: by 2002:a05:6a20:4c95:b0:d3:f5e4:f3bd with SMTP id fq21-20020a056a204c9500b000d3f5e4f3bdmr7371012pzb.14.1678800585425; Tue, 14 Mar 2023 06:29:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678800585; cv=none; d=google.com; s=arc-20160816; b=x2+U9Wk3STcHGKNMWmv0OzOHOa87Cv6SJeSSOwXgcQ/0HfA7X3e0rSN/gBG+vQBGzb ng3xyrYO/ZsxvqPWPGWJ+lQ3RXhCZGhs5hbX8BRw6Uw8ctLN0lM2X+iUXPvleyUKpUXF R2bic0PTP/XYUhW0sUCWQkt2VHL/XQSGSNSXLSNOxEBOV2H/y5ZMzCP0YUJjMJZgiIZk 1mDCoyA4g8DYCkhA/bdWJN5WhxektvmgKkaXqBUYl8swH0V8IpBcEDj0U4IhRTMHj7RA Wszy4h1CXn8aeB3oKaSFJu4442wqJeL/XVhGtCPsAKEH2ic/eg3oCYspr7as/vWsBI0E SFQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/g5U2nBWFLu4oD4eRCa7XyeCkfe3WqX8PWsTADoukaw=; b=usanehJG2TtI2MBg25XrJ/YQJAiYN8Mn9DkMdLf/v5cohxeYcEtgVkoCCQWRPZXhvs vGK0U+phU2eG2PEZLzNKzHlze8MEGK1etAlSmcCqhdyxU8DFOI0x8TmffwwNEx7FhHvI wDYcS7y2Dt8QkouYEMQJ0PdfPNvgQlpWLQd3GKDl6Em4z7X7YSLpS9k2FbG5EJR0gMuL QAIfKFH0Q676sNvcEGDK25yyl3+Uyc7AG4txJsyxLK2L4P7itCPBG5e3p/hz7yT4wOHq gM9NoXyKWuqEPFXvirL5QEQiuthaaGIwA7uMz8DRwORQ++DbnTZpf0eKqGTVcRkK/d9g e6qQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=ZvcXfLKA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j12-20020a63230c000000b00502f3d1a058si2173890pgj.479.2023.03.14.06.29.28; Tue, 14 Mar 2023 06:29:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=ZvcXfLKA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232336AbjCNNT3 (ORCPT + 99 others); Tue, 14 Mar 2023 09:19:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232391AbjCNNSr (ORCPT ); Tue, 14 Mar 2023 09:18:47 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 755B1618B for ; Tue, 14 Mar 2023 06:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=SsTC9UU9wdPdSI 0PbPhntycZBlShn3e/V5pFPLMU5/8=; b=ZvcXfLKABiDC9npZb4SVa4ELduNGUH JYWlTOq5gC2b1Av3MwV0fQnLvYANm1jrF0pT40lXXp0CxRsKZsy3vYQ9Tq9h8aJr 28EY9RgVIc3Y//DR8263wPxS2Mdmzx+kTMLxVu0VBVJZZG9mv8UlX+qnZXcuzzXG m9CExX8bF7Wg4= Received: (qmail 3111703 invoked from network); 14 Mar 2023 14:14:58 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 14 Mar 2023 14:14:58 +0100 X-UD-Smtp-Session: l3s3148p1@fFKrA9z2ts0ujnvb From: Wolfram Sang To: netdev@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de, Wolfram Sang , Steve Glendinning , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net-next 4/4] smsc911x: add FIXME to move 'mac_managed_pm' to probe Date: Tue, 14 Mar 2023 14:14:42 +0100 Message-Id: <20230314131443.46342-5-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230314131443.46342-1-wsa+renesas@sang-engineering.com> References: <20230314131443.46342-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760350002865069968?= X-GMAIL-MSGID: =?utf-8?q?1760350002865069968?= On Renesas hardware, we had issues because the above flag was set during 'open'. It was concluded that it needs to be set during 'probe'. It looks like SMS911x needs the same fix but I can't test it because I don't have the hardware. At least, leave a note about the issue. Signed-off-by: Wolfram Sang --- drivers/net/ethernet/smsc/smsc911x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c index a2e511912e6a..745e0180eb34 100644 --- a/drivers/net/ethernet/smsc/smsc911x.c +++ b/drivers/net/ethernet/smsc/smsc911x.c @@ -1038,6 +1038,7 @@ static int smsc911x_mii_probe(struct net_device *dev) } /* Indicate that the MAC is responsible for managing PHY PM */ + /* FIXME: should be set right after mdiobus is registered */ phydev->mac_managed_pm = true; phy_attached_info(phydev);