From patchwork Tue Mar 14 12:49:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 69620 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1758238wrd; Tue, 14 Mar 2023 06:29:33 -0700 (PDT) X-Google-Smtp-Source: AK7set8gSFf/eVXsF0EBwhE68pM7JGus9V70zDE+69RS0FNiHar1FmjtcnsWNHXmwzH2ciCEP0eL X-Received: by 2002:a17:902:e74b:b0:19a:7648:512 with SMTP id p11-20020a170902e74b00b0019a76480512mr47063714plf.30.1678800573190; Tue, 14 Mar 2023 06:29:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678800573; cv=none; d=google.com; s=arc-20160816; b=hxYjGfG5OzJiCU+6RcOjD+JTHHtjle4CoVUEyotBrUd8I2Yp2w3MkqNybQnS6Qp0iq NPp1MubTiXJWuyT/n789/B8T9lBtNd56R7G3q8kaT+CFvL066J2tXqTe4RDsrwQEKx29 6XFVavcmmoHuk/LSy5bOLjGvnIi7XktnN6V0wp1DYM+8bRf7xv06PUu9QXSNr0P/r8HZ afqcg3qERc1SEFBBWfuEZ/au82Evox1u9YXF/1JmkW4CeabTbdb5PQsoai9HkS0iEmxy W92eCExnv0veRKwplfmEZqroj5Ob0NBwGm3E5hJG1dzEOKhmzDgbxeLNS+FSZsoK8DHh 2yJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=So7ifoxaKAQxnaXRYLe04qsoqIzUBFnYMmUBAxDeuNk=; b=exJH7CF6/ibTrmYAxnq3FvVLpxujULjE6u0upbCU3eDeD4BX1YBQmUq6VYZMARn3hl J3oZ2XthuU89PGVBL/zW4tiry8iPL4U1e5KZDMm+yOq2KrGzFsrVFl4duQ3/MGcotVP0 ejvgVxYJGtNWeXrAbVKoCbCiu3gWlw8wLWO4IWTvYYdLucKEOv3MpTyk4W+nBGPpbEdX hNv9w6iTnCqrPuRUcPq4SKbjZMZsIPcz9JP3HjVPUDeu5ugF9gm4/UCmwRbAdxvYA7wN HTcnRkgG5S9FL+TbRq9xqFIRzF3sWojexmPlwNJRCw2g98xA7NSrX2pyDO4Xl8DKQro4 15sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=B9HQI9o5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p9-20020a170902bd0900b0019ace4c5bd5si2341514pls.513.2023.03.14.06.29.14; Tue, 14 Mar 2023 06:29:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=B9HQI9o5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231954AbjCNNOr (ORCPT + 99 others); Tue, 14 Mar 2023 09:14:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231874AbjCNNOW (ORCPT ); Tue, 14 Mar 2023 09:14:22 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2684D64267 for ; Tue, 14 Mar 2023 06:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=k1; bh=YSDGQgo64K7kPQPijTqgAMUKCwj Eu9vA4OsmPLBJ/pU=; b=B9HQI9o5SsFCfo06nrkKU/np4zw7Jw8Vb2MdaLMP+hH cMUnirTlQ8AIEKbdsMKhLQFnqNlSv1TnRxMonfGlCSMpPOSgdyZUvH38KsQFZ/tt qvLVFqkOF3gwDYP2UGN5B6bhF/uuG7HjcVnz+ktICCcNKvC7SrW3NHWos4S8gPUg = Received: (qmail 3103901 invoked from network); 14 Mar 2023 13:49:30 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 14 Mar 2023 13:49:30 +0100 X-UD-Smtp-Session: l3s3148p1@nHeUqNv2OsQujnvb From: Wolfram Sang To: netdev@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Wolfram Sang , Andrew Lunn , Geert Uytterhoeven , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [RESEND net-next] net: phy: micrel: drop superfluous use of temp variable Date: Tue, 14 Mar 2023 13:49:27 +0100 Message-Id: <20230314124928.44948-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760349989587618841?= X-GMAIL-MSGID: =?utf-8?q?1760349989587618841?= 'temp' was used before commit c0c99d0cd107 ("net: phy: micrel: remove the use of .ack_interrupt()") refactored the code. Now, we can simplify it a little. Signed-off-by: Wolfram Sang Reviewed-by: Andrew Lunn Reviewed-by: Geert Uytterhoeven --- Only tags added since last time. drivers/net/phy/micrel.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 2c84fccef4f6..6c7845137c23 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -435,11 +435,9 @@ static int kszphy_config_intr(struct phy_device *phydev) if (err) return err; - temp = KSZPHY_INTCS_ALL; - err = phy_write(phydev, MII_KSZPHY_INTCS, temp); + err = phy_write(phydev, MII_KSZPHY_INTCS, KSZPHY_INTCS_ALL); } else { - temp = 0; - err = phy_write(phydev, MII_KSZPHY_INTCS, temp); + err = phy_write(phydev, MII_KSZPHY_INTCS, 0); if (err) return err;