| Message ID | 20230314080231.20212-2-yang.lee@linux.alibaba.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1624786wrd;
Tue, 14 Mar 2023 01:06:39 -0700 (PDT)
X-Google-Smtp-Source:
AK7set/O3E9/VHzlHa2Nz+AD5yhuaeZN2sxZP+1k8W1yms8IVmgrKtFFd8grTTTSuucr3E1atAcg
X-Received: by 2002:a05:6a20:e688:b0:cb:ac6c:139d with SMTP id
mz8-20020a056a20e68800b000cbac6c139dmr36768461pzb.9.1678781199630;
Tue, 14 Mar 2023 01:06:39 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1678781199; cv=none;
d=google.com; s=arc-20160816;
b=QHYGmZpcUGfNuD6IQniQZ5Mcaafn+NxQbpfHSmQhfcbQuF6tCkIuWU/jOeQA2dfFA6
NmmuXx3yDZIwsbPwINBmbj/cdEGAmxNc8JmtY1aVQbnOXccXWDwqv3kBpNXlhBazUJLE
Hky2vY1ew72cbhvkU3PBBRfNQd/RgX88A0HcFbwXz0XeJYVSE1U1AiEOwr3uNiGnbMe9
Qf/zHQmKnIJ7SGmd+28ZO1+EerEJitfHODIicgqswNAkiBs8mLT3UbbFHMsDEcBPyCar
4o3Nx3bYMrJtcu93d4YGYwqqhsNq1jJdXxikmQKdmwB8rv3znl8zxfUO0x3b0spYyf+6
l0dg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=IrQFMmICVWs7JJ21//ijMDTfeZJ9x/f7JNodIk5mUQ4=;
b=A6b9GDQPKEzquSdNufGaiZpZkRydtQtoJ4PR/TlnsCMg2IFzVJ9Xdb9vKEnhMbAnXz
hDm2Zncjkj5i84cl6vpXwdShfVrdMzuASk3OQwDcD/UP6ZOmMYS8zQr4bbv7BN31FlgP
DQbs8Io2UsbCCT/QPJqj77NBaHBnVwJg/M+LNOgghh+XpQem0snPkqzntE5ZP6vJgrWL
8lz15bFVlcn0Wi/2I/upBM5RfvnfwGpqDzwlXzv0BVFABn1fjmLHP4aFJpPeVTt0WGDQ
MN0q3AkMJIRLbbF9SDcR/PTXUmiVRpS0eW9lWdtrsKhDGvDf7XMeYUakmW5zADswpUS0
KRbg==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
g10-20020a63f40a000000b00503224ebb35si1646881pgi.575.2023.03.14.01.06.20;
Tue, 14 Mar 2023 01:06:39 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230312AbjCNICl (ORCPT <rfc822;realc9580@gmail.com> + 99 others);
Tue, 14 Mar 2023 04:02:41 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59924 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230287AbjCNICj (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 14 Mar 2023 04:02:39 -0400
Received: from out30-118.freemail.mail.aliyun.com
(out30-118.freemail.mail.aliyun.com [115.124.30.118])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 299ED58C33
for <linux-kernel@vger.kernel.org>;
Tue, 14 Mar 2023 01:02:37 -0700 (PDT)
X-Alimail-AntiSpam:
AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0VdrLTsb_1678780954;
Received: from localhost(mailfrom:yang.lee@linux.alibaba.com
fp:SMTPD_---0VdrLTsb_1678780954)
by smtp.aliyun-inc.com;
Tue, 14 Mar 2023 16:02:35 +0800
From: Yang Li <yang.lee@linux.alibaba.com>
To: airlied@gmail.com
Cc: daniel@ffwll.ch, liviu.dudau@arm.com, brian.starkey@arm.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Yang Li <yang.lee@linux.alibaba.com>
Subject: [PATCH -next 1/2] drm/arm/malidp: Use
devm_platform_get_and_ioremap_resource()
Date: Tue, 14 Mar 2023 16:02:31 +0800
Message-Id: <20230314080231.20212-2-yang.lee@linux.alibaba.com>
X-Mailer: git-send-email 2.20.1.7.g153144c
In-Reply-To: <20230314080231.20212-1-yang.lee@linux.alibaba.com>
References: <20230314080231.20212-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00,
ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1760329675384250412?=
X-GMAIL-MSGID: =?utf-8?q?1760329675384250412?=
|
| Series |
[-next,1/2] drm/arm/malidp: Use devm_platform_get_and_ioremap_resource()
|
|
Commit Message
Yang Li
March 14, 2023, 8:02 a.m. UTC
According to commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()"), convert
platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Since 'struct platform_device *pdev = to_platform_device(dev)',
'pdev->dev' is equivalent to 'dev'.
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/arm/malidp_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
On Tue, Mar 14, 2023 at 04:02:31PM +0800, Yang Li wrote: > According to commit 890cc39a8799 ("drivers: provide > devm_platform_get_and_ioremap_resource()"), convert > platform_get_resource(), devm_ioremap_resource() to a single > call to devm_platform_get_and_ioremap_resource(), as this is exactly > what this function does. > > Since 'struct platform_device *pdev = to_platform_device(dev)', > 'pdev->dev' is equivalent to 'dev'. > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> Thanks for the cleanup! I will pull this patch and the hdlcd one into drm-misc-next by the end of the week. Best regards, Liviu > --- > drivers/gpu/drm/arm/malidp_drv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c > index cf040e2e9efe..e220bfc85b2e 100644 > --- a/drivers/gpu/drm/arm/malidp_drv.c > +++ b/drivers/gpu/drm/arm/malidp_drv.c > @@ -724,8 +724,7 @@ static int malidp_bind(struct device *dev) > hwdev->hw = (struct malidp_hw *)of_device_get_match_data(dev); > malidp->dev = hwdev; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - hwdev->regs = devm_ioremap_resource(dev, res); > + hwdev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res); > if (IS_ERR(hwdev->regs)) > return PTR_ERR(hwdev->regs); > > -- > 2.20.1.7.g153144c >
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index cf040e2e9efe..e220bfc85b2e 100644 --- a/drivers/gpu/drm/arm/malidp_drv.c +++ b/drivers/gpu/drm/arm/malidp_drv.c @@ -724,8 +724,7 @@ static int malidp_bind(struct device *dev) hwdev->hw = (struct malidp_hw *)of_device_get_match_data(dev); malidp->dev = hwdev; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - hwdev->regs = devm_ioremap_resource(dev, res); + hwdev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(hwdev->regs)) return PTR_ERR(hwdev->regs);