From patchwork Tue Mar 14 07:47:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yonggil Song X-Patchwork-Id: 69348 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1621093wrd; Tue, 14 Mar 2023 00:56:40 -0700 (PDT) X-Google-Smtp-Source: AK7set8o+n0X4tBSe4ovurST486PIdXyu4hDoNIfAgnoMpa/N05cksOhPnNfKi3wNCjevrIqsbkK X-Received: by 2002:a05:6a20:4c95:b0:d3:f5e4:f3bd with SMTP id fq21-20020a056a204c9500b000d3f5e4f3bdmr6613222pzb.14.1678780600224; Tue, 14 Mar 2023 00:56:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678780600; cv=none; d=google.com; s=arc-20160816; b=jsMJY5URuHmCOh7lTKWKNleIqPh8+SneKoJzgKalPKqMWcIjt8f5qzXW9LHlMT+5e6 orUni9oO4f9/MvF0BadoHE4RGOXAn9M8CDknXFG9+ddfgZbiXZoLsCGKjb1GdwSLJR/R Amq+Ao8i+Vbd10rEdEbZ2vUomZ7aRSafxKWz9xhK+7ktBgbn/oc4ZurrPTistHuTMZIY U4+ld+qQS5PjJilH7o2N17207v7gsXDLKt+5zn6Kkx8HXyfYXVDFQVqtPXIhjQUoFJoG LAt1AewR5U0aZEMyU23+1Gi2W1jjyXTunYhEj55IFDjAoNOvqoHB2YGtR10OoSwiwH7r nzCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:date:message-id:to:from:sender:reply-to :subject:mime-version:dkim-signature:dkim-filter; bh=Rh6UJxWisQFryDemfLydE6a77p2ZTG2G9wZ47GaDRRo=; b=KWnCm+J9ytCTkOlYaAAGiWphIL83ZrbisArSTa/5u1ndcpAjbZdWgwX2fK+KE1VOvS n4SmTUQ8MKEdSSw+yFeILnYJE2cZQKESkeTqnKvzYeIPf7IRi7U99CLcXZ98oJHNpT6z OyR1eIOKLp771nKGUrsfjIOdA7ixKWk/t8noZ2yP4xxEb6P1e8JP+0ibED1Sg2DS8Hpt IKl51CmoF2oznTOV8wt3EVUKpkzVUOLnGt0PFUul7BpFcXdPrWFzf4CvBsLlfuEbRMSe eDk7dRkSnUVi6VNUMYrUrYgUyZTnDhyp4G0OREZtkMt+zX8WNMjSiHaaAJuzbmhyWy6P jZOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b="MfJy2X/e"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j191-20020a638bc8000000b00502ece99eb3si1709737pge.41.2023.03.14.00.56.27; Tue, 14 Mar 2023 00:56:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b="MfJy2X/e"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229670AbjCNHro (ORCPT + 99 others); Tue, 14 Mar 2023 03:47:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjCNHrm (ORCPT ); Tue, 14 Mar 2023 03:47:42 -0400 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21BD095444 for ; Tue, 14 Mar 2023 00:47:39 -0700 (PDT) Received: from epcas2p3.samsung.com (unknown [182.195.41.55]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20230314074735epoutp03471fdf6f0cdd6adf9c58df1246ee70ab~MOZDYl_ej3089630896epoutp031 for ; Tue, 14 Mar 2023 07:47:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20230314074735epoutp03471fdf6f0cdd6adf9c58df1246ee70ab~MOZDYl_ej3089630896epoutp031 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1678780055; bh=Rh6UJxWisQFryDemfLydE6a77p2ZTG2G9wZ47GaDRRo=; h=Subject:Reply-To:From:To:Date:References:From; b=MfJy2X/e2StM5wrUro9aHC4UYj3EaQsh8XwtNffT5a5CiuYN+3DUV2IiWum2QwM7r VytnjHW1CyIrU/aSSouvORJ9TRvIEucva1N7kIviQ3Iu8sY8sy/UlzgynURiRJPgB8 U5BeZSx0Xhhh7FwAb6+DooYltBDsM1/OpFPv+oLo= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas2p1.samsung.com (KnoxPortal) with ESMTP id 20230314074735epcas2p1b4f3d417fa3df9152499c5a8a009c0d1~MOZDHou100842908429epcas2p1W; Tue, 14 Mar 2023 07:47:35 +0000 (GMT) Received: from epsmges2p4.samsung.com (unknown [182.195.36.91]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4PbQbp1T2Cz4x9Q2; Tue, 14 Mar 2023 07:47:34 +0000 (GMT) X-AuditID: b6c32a48-45bfc70000021624-ba-64102695b236 Received: from epcas2p2.samsung.com ( [182.195.41.54]) by epsmges2p4.samsung.com (Symantec Messaging Gateway) with SMTP id F3.5D.05668.59620146; Tue, 14 Mar 2023 16:47:33 +0900 (KST) Mime-Version: 1.0 Subject: [PATCH v1] f2fs: Fix system crash due to lack of free space in LFS Reply-To: yonggil.song@samsung.com Sender: Yonggil Song From: Yonggil Song To: "jaegeuk@kernel.org" , "chao@kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" X-Priority: 3 X-Content-Kind-Code: NORMAL X-CPGS-Detection: blocking_info_exchange X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20230314074733epcms2p511d7a7fa11d5b54ac2fbaa840db3f1cb@epcms2p5> Date: Tue, 14 Mar 2023 16:47:33 +0900 X-CMS-MailID: 20230314074733epcms2p511d7a7fa11d5b54ac2fbaa840db3f1cb X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJKsWRmVeSWpSXmKPExsWy7bCmme5UNYEUg1n3DS1OTz3LZPFk/Sxm i0uL3C0u75rDZjH1/BEmB1aPTas62Tx2L/jM5NG3ZRWjx+dNcgEsUdk2GamJKalFCql5yfkp mXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUBrlRTKEnNKgUIBicXFSvp2NkX5 pSWpChn5xSW2SqkFKTkF5gV6xYm5xaV56Xp5qSVWhgYGRqZAhQnZGY9uz2Et+KpR8fPdPvYG xg6lLkZODgkBE4nj8/8zdjFycQgJ7GCUmHj+I3sXIwcHr4CgxN8dwiA1wgLeEj1bl7OD2EIC ShLXDvSyQMT1JTYvXgYWZxPQlfi7AaJGROAVo8SZ1aIQ83klZrQ/ZYGwpSW2L9/KCGFrSPxY 1ssMYYtK3Fz9lh3Gfn9sPlSNiETrvbNQNYISD37uhopLSiw6dJ4Jws6X+LviOhuEXSOxtaEN Kq4vca1jI9heXgFfiZa7c1lBbBYBVYnbnVeg5rhInPkyDSzOLCAvsf3tHGaQ15kFNCXW79IH MSUElCWO3GKBqOCT6Dj8lx3mqx3znkBtUpPYvGkzK4QtI3HhcRvUdA+JXzNPskJCLVDi+NkG 1gmM8rMQYTsLyd5ZCHsXMDKvYhRLLSjOTU8tNiowgUdncn7uJkZwmtPy2ME4++0HvUOMTByM hxglOJiVRHjDWQRShHhTEiurUovy44tKc1KLDzGaAn08kVlKNDkfmGjzSuINTSwNTMzMDM2N TA3MlcR5pW1PJgsJpCeWpGanphakFsH0MXFwSjUwJd+eduqbypfCzk5lq+K7N7l9n6qf/8d8 QOyJ10Grhc19bc7Tytkvu51w0HxezJXdcOJ1nvcVKwd5ziePP61y+xTqfXZaTcC7BtUW1gOi rvPn+9rp72nik79zcv/NptJZ5fJzD6zs5Fv19x/XwQT7rQvVblQeaJxRt/uyH1+avtTPCcFJ /G/XPGVWnjptlevvp4sm1e/2NF+5n+8A26IqvwMzmD1nxvftTqnwZxP+2tX9M+lRh6sCt+mK qkNLYz8yfP27bOr/I6qr715+F7D0rd/EeX9elyRe3VbdWujcMP/F4nuHVmydaHlnV4NAq5tL oKTbyxVP3p1a7s6w9fXOHF2Bi3syHk6sWejV9uY/m4sSS3FGoqEWc1FxIgBA6duw/AMAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230314074733epcms2p511d7a7fa11d5b54ac2fbaa840db3f1cb References: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760329046391870609?= X-GMAIL-MSGID: =?utf-8?q?1760329046391870609?= When f2fs tries to checkpoint during foreground gc in LFS mode, system crash occurs due to lack of free space if the amount of dirty node and dentry pages generated by data migration exceeds free space. The reproduction sequence is as follows. - 20GiB capacity block device (null_blk) - format and mount with LFS mode - create a file and write 20,000MiB - 4k random write on full range of the file RIP: 0010:new_curseg+0x48a/0x510 [f2fs] Code: 55 e7 f5 89 c0 48 0f af c3 48 8b 5d c0 48 c1 e8 20 83 c0 01 89 43 6c 48 83 c4 28 5b 41 5c 41 5d 41 5e 41 5f 5d c3 cc cc cc cc <0f> 0b f0 41 80 4f 48 04 45 85 f6 0f 84 ba fd ff ff e9 ef fe ff ff RSP: 0018:ffff977bc397b218 EFLAGS: 00010246 RAX: 00000000000027b9 RBX: 0000000000000000 RCX: 00000000000027c0 RDX: 0000000000000000 RSI: 00000000000027b9 RDI: ffff8c25ab4e74f8 RBP: ffff977bc397b268 R08: 00000000000027b9 R09: ffff8c29e4a34b40 R10: 0000000000000001 R11: ffff977bc397b0d8 R12: 0000000000000000 R13: ffff8c25b4dd81a0 R14: 0000000000000000 R15: ffff8c2f667f9000 FS: 0000000000000000(0000) GS:ffff8c344ec80000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 000000c00055d000 CR3: 0000000e30810003 CR4: 00000000003706e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: allocate_segment_by_default+0x9c/0x110 [f2fs] f2fs_allocate_data_block+0x243/0xa30 [f2fs] ? __mod_lruvec_page_state+0xa0/0x150 do_write_page+0x80/0x160 [f2fs] f2fs_do_write_node_page+0x32/0x50 [f2fs] __write_node_page+0x339/0x730 [f2fs] f2fs_sync_node_pages+0x5a6/0x780 [f2fs] block_operations+0x257/0x340 [f2fs] f2fs_write_checkpoint+0x102/0x1050 [f2fs] f2fs_gc+0x27c/0x630 [f2fs] ? folio_mark_dirty+0x36/0x70 f2fs_balance_fs+0x16f/0x180 [f2fs] This patch adds checking whether free sections are enough before checkpoint during gc. Signed-off-by: Yonggil Song --- fs/f2fs/gc.c | 7 ++++++- fs/f2fs/segment.h | 26 +++++++++++++++++++++----- 2 files changed, 27 insertions(+), 6 deletions(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 4546e01b2ee0..b22f49a6f128 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -1773,6 +1773,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, struct f2fs_gc_control *gc_control) .iroot = RADIX_TREE_INIT(gc_list.iroot, GFP_NOFS), }; unsigned int skipped_round = 0, round = 0; + unsigned int nr_needed_secs = 0, node_blocks = 0, dent_blocks = 0; trace_f2fs_gc_begin(sbi->sb, gc_type, gc_control->no_bg_gc, gc_control->nr_free_secs, @@ -1858,8 +1859,12 @@ int f2fs_gc(struct f2fs_sb_info *sbi, struct f2fs_gc_control *gc_control) } } + /* need more three extra sections for writer's data/node/dentry */ + nr_needed_secs = get_min_need_secs(sbi, &node_blocks, &dent_blocks) + 3; + nr_needed_secs += ((node_blocks ? 1 : 0) + (dent_blocks ? 1 : 0)); + /* Write checkpoint to reclaim prefree segments */ - if (free_sections(sbi) < NR_CURSEG_PERSIST_TYPE && + if (free_sections(sbi) <= nr_needed_secs && prefree_segments(sbi)) { ret = f2fs_write_checkpoint(sbi, &cpc); if (ret) diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h index be8f2d7d007b..ac11c47bfe37 100644 --- a/fs/f2fs/segment.h +++ b/fs/f2fs/segment.h @@ -605,8 +605,11 @@ static inline bool has_curseg_enough_space(struct f2fs_sb_info *sbi, return true; } -static inline bool has_not_enough_free_secs(struct f2fs_sb_info *sbi, - int freed, int needed) +/* + * calculate the minimum number of sections (needed) for dirty node/dentry + */ +static inline unsigned int get_min_need_secs(struct f2fs_sb_info *sbi, + unsigned int *node_blocks, unsigned int *dent_blocks) { unsigned int total_node_blocks = get_pages(sbi, F2FS_DIRTY_NODES) + get_pages(sbi, F2FS_DIRTY_DENTS) + @@ -614,15 +617,28 @@ static inline bool has_not_enough_free_secs(struct f2fs_sb_info *sbi, unsigned int total_dent_blocks = get_pages(sbi, F2FS_DIRTY_DENTS); unsigned int node_secs = total_node_blocks / CAP_BLKS_PER_SEC(sbi); unsigned int dent_secs = total_dent_blocks / CAP_BLKS_PER_SEC(sbi); - unsigned int node_blocks = total_node_blocks % CAP_BLKS_PER_SEC(sbi); - unsigned int dent_blocks = total_dent_blocks % CAP_BLKS_PER_SEC(sbi); + + f2fs_bug_on(sbi, (!node_blocks || !dent_blocks)); + + *node_blocks = total_node_blocks % CAP_BLKS_PER_SEC(sbi); + *dent_blocks = total_dent_blocks % CAP_BLKS_PER_SEC(sbi); + + return (node_secs + dent_secs); +} + +static inline bool has_not_enough_free_secs(struct f2fs_sb_info *sbi, + int freed, int needed) +{ + unsigned int node_blocks = 0; + unsigned int dent_blocks = 0; unsigned int free, need_lower, need_upper; if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING))) return false; free = free_sections(sbi) + freed; - need_lower = node_secs + dent_secs + reserved_sections(sbi) + needed; + need_lower = get_min_need_secs(sbi, &node_blocks, &dent_blocks) + needed + + reserved_sections(sbi); need_upper = need_lower + (node_blocks ? 1 : 0) + (dent_blocks ? 1 : 0); if (free > need_upper)