diff mbox series

[1/2] dt-bindings: arm: qcom: Add Acer Aspire 1

Message ID 20230314064322.65429-1-nikita@trvn.ru
State New
Headers
Series [1/2] dt-bindings: arm: qcom: Add Acer Aspire 1 |

Commit Message

Nikita Travkin March 14, 2023, 6:43 a.m. UTC 
  Acer Aspire 1 is a laptop based on sc7180. Document it's compatible.

Signed-off-by: Nikita Travkin <nikita@trvn.ru>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski March 14, 2023, 8:21 a.m. UTC | #1 
On 14/03/2023 07:43, Nikita Travkin wrote:
> Acer Aspire 1 is a laptop based on sc7180. Document it's compatible.
> 
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 1bb24d46e4ee..903a5ea42cf6 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -352,6 +352,11 @@ properties:
>                - qcom,qru1000-idp
>            - const: qcom,qru1000
>  
> +      - items:
> +          - enum:
> +              - acer,aspire1
> +          - const: qcom,sc7180
> +
>        - description: Qualcomm Technologies, Inc. SC7180 IDP

Please merge with this one and drop the description (or rename it to
something like SC7180-based boards). The sc7180 entries spread a lot and
it is not helping to read the file.

Best regards,
Krzysztof
Nikita Travkin March 14, 2023, 8:55 a.m. UTC | #2 
Krzysztof Kozlowski писал(а) 14.03.2023 13:21:
> On 14/03/2023 07:43, Nikita Travkin wrote:
>> Acer Aspire 1 is a laptop based on sc7180. Document it's compatible.
>>
>> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
>> ---
>>  Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 1bb24d46e4ee..903a5ea42cf6 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -352,6 +352,11 @@ properties:
>>                - qcom,qru1000-idp
>>            - const: qcom,qru1000
>>
>> +      - items:
>> +          - enum:
>> +              - acer,aspire1
>> +          - const: qcom,sc7180
>> +
>>        - description: Qualcomm Technologies, Inc. SC7180 IDP
> 
> Please merge with this one and drop the description (or rename it to
> something like SC7180-based boards). The sc7180 entries spread a lot and
> it is not helping to read the file.
> 

I was debating whether to copy CrOS style or the majority for this one.
Will merge with IDP (dropping the description to be in line with all others)
but will not touch any other sc7180 boards.

Thanks,
Nikita

> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 1bb24d46e4ee..903a5ea42cf6 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -352,6 +352,11 @@  properties:
               - qcom,qru1000-idp
           - const: qcom,qru1000
 
+      - items:
+          - enum:
+              - acer,aspire1
+          - const: qcom,sc7180
+
       - description: Qualcomm Technologies, Inc. SC7180 IDP
         items:
           - enum: