From patchwork Tue Mar 14 06:40:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 69329 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1598864wrd; Mon, 13 Mar 2023 23:44:25 -0700 (PDT) X-Google-Smtp-Source: AK7set9NltrM1r+SJaBJspktLerzzRhXBYPkmDiq1/tDD+Y8d+mDp4Bu3N9B/CSirStKEWsCseNh X-Received: by 2002:a17:902:d4cc:b0:19d:af20:3fe8 with SMTP id o12-20020a170902d4cc00b0019daf203fe8mr45248666plg.21.1678776264682; Mon, 13 Mar 2023 23:44:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678776264; cv=none; d=google.com; s=arc-20160816; b=DTVJKvS3R/swvmCfL11a6wgcvv2AfCkl5475RCmB7trnqber28ybOCuLhlTo679pgW vcMFDSI7udexyK4zfEhKjyaEw35fBm959jaoZH2VPtIQ1mWyXRl78YfTot2NoQ0rlSWl IE8JDOxL7pRhOEowCihGLgglmJW75RJ+YqASv64rT9wM1lbQmnFLUq+m8ETbUGlZG88M wEtgogPa+eY9N+9JYCu/GTwd9w6onLYom7eyFdRXgBOYYLNZzppiO94eCCrZt9+DsMZh 624k/Ypc4aOad1kHUDmKXrIdoViVTSt2ZafSA9ddmwJEKDuCPCgGWGkQJEN+o9rp0249 4IXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LRCH94INAYNBTN9UMFfZ73anns3LkZY1R6gty5aOJHg=; b=tCJ7nkSNCutFMi5pSeX2t+5QxWs3CgHqD3JxnYlKl+F+g4mhYzzDXLD9G/CH9Z33ts PfZJqUVh8LqrEdKAZSptbqGT+8nkqMDGjzVJjTMav3gOUiMYADmmygY3UbffYigrkFHs uvYkLF7lH1TaYUNVFpzP6sqltS+qpu00TBQxvi9D/w2HItqog67sMtq8EhAIl6+sPbMk 5kyzPYr0tXDhjlXmJMYgtkK1YXXeLJf7iUXJ2PhP8DUMf3Rb4I1bN9x7Namdli7R2v4V DRaSe94PRQqZuvONnpVRL2Vt5eXIcPnY46YtwTne8/ZnieHiO/lczrLg9AGtZIHLmrtE Jb5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KVpZtTfA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k22-20020a170902761600b001a055252e3csi1722571pll.314.2023.03.13.23.44.12; Mon, 13 Mar 2023 23:44:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KVpZtTfA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230128AbjCNGku (ORCPT + 99 others); Tue, 14 Mar 2023 02:40:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229684AbjCNGkq (ORCPT ); Tue, 14 Mar 2023 02:40:46 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0608C96C27 for ; Mon, 13 Mar 2023 23:40:45 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id kb15so14431331pjb.1 for ; Mon, 13 Mar 2023 23:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678776044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LRCH94INAYNBTN9UMFfZ73anns3LkZY1R6gty5aOJHg=; b=KVpZtTfANzauJj677+bEuT5pejek9GXPcrX4gYrtN6aE6ZBi9dMkJ6895LhooworgT NFpFesV2sJzZ+jw6cvrlZvSZ0S47uhTgsgGkIRCSpze+zmXBOYjxyf64K84RG1RTctJP AM1Me4tlqlF7bGnBOsjd6z8/mrT+Rp6pYXQFFtmChzPgRk6wnRlREKpvU4+GpmYOWsVC At8dM0hPwvHmLicKVewi+MvWWrn7SWJDztrwh+gvYaxzYwehRk0wxJ107EUl9gABmeww fJT7mS7IJk7++dSTO1DJ19gpE2vjIRBDJ3SP2rZIbIQT7jKv112P2Sg0RteJAs1cFYyf wYkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678776044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LRCH94INAYNBTN9UMFfZ73anns3LkZY1R6gty5aOJHg=; b=jkcANJSEcRslLW7Ic5B4OHwWCw6pP2yis4fpBvvUyP2mqWo6E2g51ByTemjVV5dhAi +NY/x4FVtjTV1HW0CtQf+Hg0ux//e6F8ybzG9g2YDwiOX9hJ4Dys/iO3PxJeGqDS/j7j rTaDxo4JmhzJzxncXnjztpTCDrdZKyftBwKuHEc4ZlCkXlF6FFGz/JVoCRVHXVMV7Ghc PXv0HGWJkv4JKO+zoE11wcKulVVvmOAorY0LoAySbEYOrlwgE+mKFgrxHy+oORB9dCJz sa2bwshUrPi7X7kXVhasmmr3wF+7mhE5wTBsQ4IIJUg3lKXWUCDTT3vHDr/XrVs87/tJ L7xw== X-Gm-Message-State: AO0yUKXs4ocubCSUmoI6TJS36qQ8vVc6jvjLW+cEdaJMOtk+URbIaNhx yPS9TOK9hXmUvX5lnvpsw8OT X-Received: by 2002:a17:903:2281:b0:19a:9686:ea85 with SMTP id b1-20020a170903228100b0019a9686ea85mr40126604plh.17.1678776044427; Mon, 13 Mar 2023 23:40:44 -0700 (PDT) Received: from localhost.localdomain ([117.217.177.49]) by smtp.gmail.com with ESMTPSA id l15-20020a170902f68f00b0019f363ed8c0sm897497plg.226.2023.03.13.23.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 23:40:43 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, bp@alien8.de, mchehab@kernel.org Cc: james.morse@arm.com, rric@kernel.org, linux-arm-msm@vger.kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, quic_saipraka@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v6 1/2] EDAC/qcom: Remove extra error no assignment in qcom_llcc_core_setup() Date: Tue, 14 Mar 2023 12:10:31 +0530 Message-Id: <20230314064032.16433-2-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230314064032.16433-1-manivannan.sadhasivam@linaro.org> References: <20230314064032.16433-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760324500057695758?= X-GMAIL-MSGID: =?utf-8?q?1760324500057695758?= If the ret variable is initialized with -EINVAL, then there is no need to assign it again in the default case of qcom_llcc_core_setup(). Signed-off-by: Manivannan Sadhasivam --- drivers/edac/qcom_edac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/edac/qcom_edac.c b/drivers/edac/qcom_edac.c index 3256254c3722..9cac49596a6f 100644 --- a/drivers/edac/qcom_edac.c +++ b/drivers/edac/qcom_edac.c @@ -168,7 +168,7 @@ static int qcom_llcc_core_setup(struct regmap *llcc_bcast_regmap) static int qcom_llcc_clear_error_status(int err_type, struct llcc_drv_data *drv) { - int ret = 0; + int ret = -EINVAL; switch (err_type) { case LLCC_DRAM_CE: @@ -196,7 +196,6 @@ qcom_llcc_clear_error_status(int err_type, struct llcc_drv_data *drv) return ret; break; default: - ret = -EINVAL; edac_printk(KERN_CRIT, EDAC_LLCC, "Unexpected error type: %d\n", err_type); }