[-next] media: atmel: atmel-isc: Use devm_platform_ioremap_resource()

Message ID 20230314055826.103682-1-yang.lee@linux.alibaba.com
State New
Headers
Series [-next] media: atmel: atmel-isc: Use devm_platform_ioremap_resource() |

Commit Message

Yang Li March 14, 2023, 5:58 a.m. UTC
  According to commit 7945f929f1a7 ("drivers: provide
devm_platform_ioremap_resource()"), convert platform_get_resource(),
devm_ioremap_resource() to a single call to Use
devm_platform_ioremap_resource(), as this is exactly what this function
does.

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c | 4 +---
 drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)
  

Comments

Claudiu Beznea March 14, 2023, 3:01 p.m. UTC | #1
On 14.03.2023 07:58, Yang Li wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> According to commit 7945f929f1a7 ("drivers: provide
> devm_platform_ioremap_resource()"), convert platform_get_resource(),
> devm_ioremap_resource() to a single call to Use

s/Use/use

with this:

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>

> devm_platform_ioremap_resource(), as this is exactly what this function
> does.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c | 4 +---
>  drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c b/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
> index ba0614f981a2..eebb336efce7 100644
> --- a/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
> +++ b/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
> @@ -389,7 +389,6 @@ static int atmel_isc_probe(struct platform_device *pdev)
>  {
>         struct device *dev = &pdev->dev;
>         struct isc_device *isc;
> -       struct resource *res;
>         void __iomem *io_base;
>         struct isc_subdev_entity *subdev_entity;
>         int irq;
> @@ -403,8 +402,7 @@ static int atmel_isc_probe(struct platform_device *pdev)
>         platform_set_drvdata(pdev, isc);
>         isc->dev = dev;
> 
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       io_base = devm_ioremap_resource(dev, res);
> +       io_base = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(io_base))
>                 return PTR_ERR(io_base);
> 
> diff --git a/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c b/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c
> index 01ababdfcbd9..beed40fe3f91 100644
> --- a/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c
> +++ b/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c
> @@ -378,7 +378,6 @@ static int microchip_xisc_probe(struct platform_device *pdev)
>  {
>         struct device *dev = &pdev->dev;
>         struct isc_device *isc;
> -       struct resource *res;
>         void __iomem *io_base;
>         struct isc_subdev_entity *subdev_entity;
>         int irq;
> @@ -392,8 +391,7 @@ static int microchip_xisc_probe(struct platform_device *pdev)
>         platform_set_drvdata(pdev, isc);
>         isc->dev = dev;
> 
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       io_base = devm_ioremap_resource(dev, res);
> +       io_base = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(io_base))
>                 return PTR_ERR(io_base);
> 
> --
> 2.20.1.7.g153144c
>
  

Patch

diff --git a/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c b/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
index ba0614f981a2..eebb336efce7 100644
--- a/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
+++ b/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
@@ -389,7 +389,6 @@  static int atmel_isc_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct isc_device *isc;
-	struct resource *res;
 	void __iomem *io_base;
 	struct isc_subdev_entity *subdev_entity;
 	int irq;
@@ -403,8 +402,7 @@  static int atmel_isc_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, isc);
 	isc->dev = dev;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	io_base = devm_ioremap_resource(dev, res);
+	io_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(io_base))
 		return PTR_ERR(io_base);
 
diff --git a/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c b/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c
index 01ababdfcbd9..beed40fe3f91 100644
--- a/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c
+++ b/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c
@@ -378,7 +378,6 @@  static int microchip_xisc_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct isc_device *isc;
-	struct resource *res;
 	void __iomem *io_base;
 	struct isc_subdev_entity *subdev_entity;
 	int irq;
@@ -392,8 +391,7 @@  static int microchip_xisc_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, isc);
 	isc->dev = dev;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	io_base = devm_ioremap_resource(dev, res);
+	io_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(io_base))
 		return PTR_ERR(io_base);