From patchwork Mon Mar 13 18:28:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 69028 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1347090wrd; Mon, 13 Mar 2023 11:47:10 -0700 (PDT) X-Google-Smtp-Source: AK7set8mZuCyYv04jO8d+gLwLxX096rNHATUAuTroe5C/tyeER7J4H/Cjy6B1y8cHDpwsDb5bzJy X-Received: by 2002:aa7:9e5e:0:b0:622:8a8e:8cf8 with SMTP id z30-20020aa79e5e000000b006228a8e8cf8mr6743124pfq.14.1678733230201; Mon, 13 Mar 2023 11:47:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678733230; cv=none; d=google.com; s=arc-20160816; b=nxOuzCwd2Dik6c+8jBqMpa+hQcq6IoSEjJcx7M8ytU3UuTpH0CNNDnntpADKELDmIZ 47emxow7rvRERivQSgUaDHRdPXtN2P7w+4ouPIqXJTuMy685ijKArY2zP8PbG6NhlkHv Bls1ZG7oBYQHE1kh5mB2doOJeC7m6JIY+bHwVVxwc5f1OFHnN/2pjDbDvma96+09qAtd KK1S76PmnQVVd34zekI0JrfCxlxKVWIrYzb7PYO+8xt1/KytDp7/UKeGPTkIlJfKoPvX u8Ku7q6dSA9HaeeYhZtz211n8uLOZmoJy07YiBzt6orpwRWtEmg4WCD4Yqvrat8Wzwt1 yayA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=i/Ua0PxvgzldLMLcE/yrBJI2MHOkHgnX1kapbxsaFSk=; b=vqJwPWMu/1CAU7Q/KxV0V/FD8hD0DzFRnIFBsQnHfmNs5IsV2oq0RngUXuxSrMQ0h1 5ifh6pyFbwVVCgE8UUfdoJHa6rNEUb9bbVkGZZl0NxHUGYm/1cILTnnYqNjYkRsPFtDo 1LfnMgUG37lE7MT8FVuEsNM/rPNs6IYh5AKL/9xT4NrFoZWyojXR3H2fY8I6xgv+nxi/ +MufSy6/N5Fu+oRgS9jvDw9Tt7M0Ff97Wy/Sfva/cd1TA5TaO9G9xrKRr0rSgQOXEQeN 0Hv3ST5WDc23P/phW4MxvSMdYF3U6Ac3RcxQTViS82wscFkmU1vpfPeYTPV+X5ZhyRJF zhWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="p5+h/Fwc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y5-20020a63ce05000000b005038290f44csi139565pgf.527.2023.03.13.11.46.56; Mon, 13 Mar 2023 11:47:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="p5+h/Fwc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230301AbjCMSaN (ORCPT + 99 others); Mon, 13 Mar 2023 14:30:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230224AbjCMSaI (ORCPT ); Mon, 13 Mar 2023 14:30:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45F60746FF; Mon, 13 Mar 2023 11:29:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1C2FCB811D8; Mon, 13 Mar 2023 18:29:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DC4FC433D2; Mon, 13 Mar 2023 18:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678732161; bh=F5jf/JTxW3R0JUCStVxeFrVkNOg4tNx9+6PiesOi5Z8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p5+h/FwcgMxm2RjkgHinbqRrDA77EWxq/o7knveMcMtDIzlPCfFnTqw5V/1PxJiQg zFsA9bxqVx2KJSICOO2UileuoWlC6nJjRl7M3ZHuoH5/BI38+/RPxNaEro7zbdT4GU NNLFzrMNVoMeJiMIdLUZzbNmaQUnf6uG1gPE5FIs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: rafael@kernel.org, Greg Kroah-Hartman , Len Brown , linux-acpi@vger.kernel.org Subject: [PATCH 02/36] ACPI: LPIT: move to use bus_get_dev_root() Date: Mon, 13 Mar 2023 19:28:44 +0100 Message-Id: <20230313182918.1312597-2-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230313182918.1312597-1-gregkh@linuxfoundation.org> References: <20230313182918.1312597-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2324; i=gregkh@linuxfoundation.org; h=from:subject; bh=F5jf/JTxW3R0JUCStVxeFrVkNOg4tNx9+6PiesOi5Z8=; b=owGbwMvMwCRo6H6F97bub03G02pJDCn82aXsiSHvwmLzbOPu+O+yzVkcvPHv/zdVcpOtbZKie +cfXxvdEcvCIMjEICumyPJlG8/R/RWHFL0MbU/DzGFlAhnCwMUpABOZt51hnt6lmX6hmkefHOS9 pevItv7wV6dKc4YF+37K+2lxMZxkfX1Ae5mG0QWp0OqtAA== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760279375973419941?= X-GMAIL-MSGID: =?utf-8?q?1760279375973419941?= Direct access to the struct bus_type dev_root pointer is going away soon so replace that with a call to bus_get_dev_root() instead, which is what it is there for. Cc: "Rafael J. Wysocki" Cc: Len Brown Cc: linux-acpi@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- Note, this is a patch that is a prepatory cleanup as part of a larger series of patches that is working on resolving some old driver core design mistakes. It will build and apply cleanly on top of 6.3-rc2 on its own, but I'd prefer if I could take it through my driver-core tree so that the driver core changes can be taken through there for 6.4-rc1. drivers/acpi/acpi_lpit.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/acpi/acpi_lpit.c b/drivers/acpi/acpi_lpit.c index 3843d2576d3f..73b5c4800150 100644 --- a/drivers/acpi/acpi_lpit.c +++ b/drivers/acpi/acpi_lpit.c @@ -98,6 +98,8 @@ EXPORT_SYMBOL_GPL(lpit_read_residency_count_address); static void lpit_update_residency(struct lpit_residency_info *info, struct acpi_lpit_native *lpit_native) { + struct device *dev_root = bus_get_dev_root(&cpu_subsys); + info->frequency = lpit_native->counter_frequency ? lpit_native->counter_frequency : tsc_khz * 1000; if (!info->frequency) @@ -111,15 +113,18 @@ static void lpit_update_residency(struct lpit_residency_info *info, return; /* Silently fail, if cpuidle attribute group is not present */ - sysfs_add_file_to_group(&cpu_subsys.dev_root->kobj, - &dev_attr_low_power_idle_system_residency_us.attr, - "cpuidle"); + if (dev_root) + sysfs_add_file_to_group(&dev_root->kobj, + &dev_attr_low_power_idle_system_residency_us.attr, + "cpuidle"); } else if (info->gaddr.space_id == ACPI_ADR_SPACE_FIXED_HARDWARE) { /* Silently fail, if cpuidle attribute group is not present */ - sysfs_add_file_to_group(&cpu_subsys.dev_root->kobj, - &dev_attr_low_power_idle_cpu_residency_us.attr, - "cpuidle"); + if (dev_root) + sysfs_add_file_to_group(&dev_root->kobj, + &dev_attr_low_power_idle_cpu_residency_us.attr, + "cpuidle"); } + put_device(dev_root); } static void lpit_process(u64 begin, u64 end)