From patchwork Mon Mar 13 17:04:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 68998 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1324729wrd; Mon, 13 Mar 2023 10:57:18 -0700 (PDT) X-Google-Smtp-Source: AK7set/fVeJnYuiZscnoOmlZHNLYN02Ef0xw8FVd6WCm1lg9NbcB/klX4jLtE+8JSWk4efKUsQVG X-Received: by 2002:aa7:93c8:0:b0:625:500c:35c4 with SMTP id y8-20020aa793c8000000b00625500c35c4mr860707pff.29.1678730238498; Mon, 13 Mar 2023 10:57:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678730238; cv=none; d=google.com; s=arc-20160816; b=rumEYrEtPWcYc9LKJVK6oRQWzMR8JdXnVpypgNxKs+FVqRTl8xRqNU1m7ABQbpBy85 UduZoVtYb6i8t9w28LyzwDCkrpncJ2vTGUIoLjCYUyUz3nVit/crIUZ7pelYUW75y0mW wCtol1P1CSay/iRM1dqqux3lvH8H2vSOT+UoXZqCKOCxzkfiLj39DzzO5x5Y16sUPJUm Q2NVTKklRQw27WnhI8VM7Zv30qzL534Jb1mH+MikvY98Jj9cqBXojxRKRGLrxgXbBQFb Jb14wyrb5tNu3Rykg/Yh+MWAjEV7N89Uw6ma8SpRqHhsd+J+JSU4ikOayQZmy5ZK0L/y xaeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6kaf3rGwzUSGiOuakOdFpdA/lkeHpTJO3jWJqdHdQRU=; b=iZI5I3wJdMc9nynrLSNbqxPakL8PJfAVkxBE0f0QLeRRjMJJkcq7c/RObrpfkXyNzr 2oAZy0Bfv73M0sY8JZjlhHgIVPycD5eA9V6OpuwXzhPPQdVXrBrZBiVVHXrLlSJeLnXw 3oi06HMG9CyWHqP1BGwhpcRyGQk8MPtWapWBX4C9k4VnnuQqhrAyqTAHCMDriDD3Mqvq n++h9k9H03rk5kgqYWYw0h2obCDy9IBAoMWKTtN/Oly33NagdcRFuxXsgq7iyeIFm4aP D8pRK4auIJA2e30UDv2sW9C4Ugly+Cl+1HGVyHu0c64sniR22/1dUUhgR14oKmVhlEIO LOTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OynKBULD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q205-20020a632ad6000000b00502e521cf81si82879pgq.356.2023.03.13.10.57.04; Mon, 13 Mar 2023 10:57:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OynKBULD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231535AbjCMRRh (ORCPT + 99 others); Mon, 13 Mar 2023 13:17:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231575AbjCMRRX (ORCPT ); Mon, 13 Mar 2023 13:17:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C56E5D44F; Mon, 13 Mar 2023 10:16:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5DABE6134E; Mon, 13 Mar 2023 17:15:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7667C4339C; Mon, 13 Mar 2023 17:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678727735; bh=18h7yJ4dungwOKffwnbsdGXL7tiydULOEDbCcZ66iBs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OynKBULDCoI/qcQGwd4Pr1fRMeE9xZRbwZyH/ENX9IxzsA5qb6ew9/0hl/W8SkZsa kPUXJz/V21M9lpDz9ycnnp8FdcNLsMBN1ECYYu6Ngpua00Kk5MEp8k+avfYhE3UuTj 2rtzJtf/mlB05WgEK1xQ2mZWWo0Hc2PZmvI12Zhe8qo4kiy5SW9EB897FJOZEoGVz+ xmqehOH+JGNeKNP/qys0RiJEupqI2F03msT/1a3Grl0aAFBHpTVEbjfleoZnjNrVoW zetoHu7WbstMVeEugIWb6Q77eIZFueshv1mq3AXD9T8pNmQj64tuv3mqHbDmbiixzc mAPVz3m2rcChg== From: Jisheng Zhang To: Eugeniy Paltsev , Vinod Koul Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/11] dmaengine: dw-axi-dmac: remove unnecessary devm_free_irq() calling Date: Tue, 14 Mar 2023 01:04:41 +0800 Message-Id: <20230313170450.897-3-jszhang@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230313170450.897-1-jszhang@kernel.org> References: <20230313170450.897-1-jszhang@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760276238798057658?= X-GMAIL-MSGID: =?utf-8?q?1760276238798057658?= In dw_remove(), We have disabled the irq from the dw-axi-dma side, so we are safe against the case "The irq is still ON when devices remove is executed and irq should be quiesced before remove is completed." Signed-off-by: Jisheng Zhang --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index 23a10dbdecb7..56f12dfa410d 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -1542,8 +1542,6 @@ static int dw_remove(struct platform_device *pdev) pm_runtime_disable(chip->dev); axi_dma_suspend(chip); - devm_free_irq(chip->dev, chip->irq, chip); - of_dma_controller_free(chip->dev->of_node); list_for_each_entry_safe(chan, _chan, &dw->dma.channels,