From patchwork Mon Mar 13 17:02:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fenghua Yu X-Patchwork-Id: 68974 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1310124wrd; Mon, 13 Mar 2023 10:23:58 -0700 (PDT) X-Google-Smtp-Source: AK7set/gp85zYHnVC0MtZ/RhZ9lXxbq9O/6iFSDMpZ9R1ShjTe64Ut7RtHwT4zDnItr+Gjd32B7J X-Received: by 2002:a05:6a20:1582:b0:ce:5bf0:3be7 with SMTP id h2-20020a056a20158200b000ce5bf03be7mr11616937pzj.27.1678728238653; Mon, 13 Mar 2023 10:23:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678728238; cv=none; d=google.com; s=arc-20160816; b=kOdLBsPFkfFJe1G2vUzqprzeH2VbNu/vBBaeDu9pu8orYSddwSZdJX+yw8w+LgK00A HqGOeh0D982Yovc7/ecOuZ6leDneRjjv20T8F5axHBm5YrvrJPCLsMkqV8LqFlUCk21N 3WD0X15s/uq8XNz5fq4qC+O3bWqCHDgZGAnRZXJ/D79CK0H9JSqtIMN68wCBuwbwG3QH LFKk+2q9gX7VolZ9EJTe4T96ZH7YM0a1us55E828W1s0o5mubsQvfifSXODGjUiNDj/z kQqMvxtSVsR/KMirKvU7r506U+Zv/Rh5m6P6khYn+we8V5XsACrd2mAuzJ3DSfHoQJXh vTGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QcthPXCXeFXjZ9ptWd0SLKUd/bUt6IGaaFMR1shFnCc=; b=cIZP8hS+gV+OJIktQcK3w/U6ZtGYBI64n0vrj3xzdx6qPiTtfvWmXIhA5eejP1qOmi May7i8tXKnb3i3s00q/WTlIorxBmQxT3S6qh8HGq22dGHPCjM08Tp4lahXPSuaTric/n 9WOsTu3HsT0Gv8bBOXHp6qw0/NnsnVGA6cdSOKOG4Wvmi/K9lKPuI3aXJ0VjsJvYrPyg eSAFSwdHPkWSBzwW7yNGkQqtAYicMzHeziod1Qb95nSkDlQlMsxl442SFi/WRHKNhtCQ FqyNFLSx5b2ffzliiPA7nKN2bS91lTeJaTW/3ZJ2QGfKShe05QXdSBx0cPGh2PcAHwqe A6Cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eVQgSYpr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n2-20020a654502000000b00503012d18f8si7169951pgq.858.2023.03.13.10.23.44; Mon, 13 Mar 2023 10:23:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eVQgSYpr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231139AbjCMRF4 (ORCPT + 99 others); Mon, 13 Mar 2023 13:05:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230354AbjCMRFe (ORCPT ); Mon, 13 Mar 2023 13:05:34 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8E321716D; Mon, 13 Mar 2023 10:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678727097; x=1710263097; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mn1nFVof/uaU7GNK/6NGBnoeC6aCmePHCwCCzsaRLNQ=; b=eVQgSYprQ57B++z+/2qJdOICYZFfsDDhfrFdcvUWQfFlDN7GtHsikR+R P8mvNf5NAzIvh28mghGgecX7fSTrO1TMym9nHKXXUZHFSixrasxn9nYCq bL5BUM76657yz8P3PxH36k/TczkaFQZDnp21iaCD2IsfXPOkb3tyYPjOP yHsJhIcWfSFPPIhaNSaHRrukJPCrycr9yaB+OZpsmZMsYqZxpgel7h3ub ui3S+RRN1omw2UqwUU5AvHtNrEIQnDyrxIlH67FdMDvVxG5sB3AC2gy4n 6ceOXR6V0sKj7VhmH9BvRRb+1hnYVM84cEgTb9VQY0P1XPZc9eqxgggVM w==; X-IronPort-AV: E=McAfee;i="6500,9779,10648"; a="334679653" X-IronPort-AV: E=Sophos;i="5.98,257,1673942400"; d="scan'208";a="334679653" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2023 10:02:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10648"; a="708950914" X-IronPort-AV: E=Sophos;i="5.98,257,1673942400"; d="scan'208";a="708950914" Received: from fyu1.sc.intel.com ([172.25.103.126]) by orsmga008.jf.intel.com with ESMTP; 13 Mar 2023 10:02:41 -0700 From: Fenghua Yu To: "Vinod Koul" , "Dave Jiang" Cc: dmaengine@vger.kernel.org, "linux-kernel" , Tony Zhu , Fenghua Yu Subject: [PATCH v3 07/16] dmaengine: idxd: create kmem cache for event log fault items Date: Mon, 13 Mar 2023 10:02:10 -0700 Message-Id: <20230313170219.1956012-8-fenghua.yu@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230313170219.1956012-1-fenghua.yu@intel.com> References: <20230313170219.1956012-1-fenghua.yu@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760274141724586015?= X-GMAIL-MSGID: =?utf-8?q?1760274141724586015?= From: Dave Jiang Add a kmem cache per device for allocating event log fault context. The context allows an event log entry to be copied and passed to a software workqueue to be processed. Due to each device can have different sized event log entry depending on device type, it's not possible to have a global kmem cache. Tested-by: Tony Zhu Signed-off-by: Dave Jiang Co-developed-by: Fenghua Yu Signed-off-by: Fenghua Yu --- drivers/dma/idxd/idxd.h | 10 ++++++++++ drivers/dma/idxd/init.c | 9 +++++++++ drivers/dma/idxd/sysfs.c | 1 + 3 files changed, 20 insertions(+) diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h index 6e56361ae658..c5d99c179902 100644 --- a/drivers/dma/idxd/idxd.h +++ b/drivers/dma/idxd/idxd.h @@ -274,6 +274,15 @@ struct idxd_evl { u16 head; }; +struct idxd_evl_fault { + struct work_struct work; + struct idxd_wq *wq; + u8 status; + + /* make this last member always */ + struct __evl_entry entry[]; +}; + struct idxd_device { struct idxd_dev idxd_dev; struct idxd_driver_data *data; @@ -331,6 +340,7 @@ struct idxd_device { unsigned long *opcap_bmap; struct idxd_evl *evl; + struct kmem_cache *evl_cache; struct dentry *dbgfs_dir; struct dentry *dbgfs_evl_file; diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c index d19bc6389221..a7c98fac7a85 100644 --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -346,6 +346,15 @@ static int idxd_init_evl(struct idxd_device *idxd) spin_lock_init(&evl->lock); evl->size = IDXD_EVL_SIZE_MIN; + + idxd->evl_cache = kmem_cache_create(dev_name(idxd_confdev(idxd)), + sizeof(struct idxd_evl_fault) + evl_ent_size(idxd), + 0, 0, NULL); + if (!idxd->evl_cache) { + kfree(evl); + return -ENOMEM; + } + idxd->evl = evl; return 0; } diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c index 163fdfaa5022..8b9dfa0d2b99 100644 --- a/drivers/dma/idxd/sysfs.c +++ b/drivers/dma/idxd/sysfs.c @@ -1718,6 +1718,7 @@ static void idxd_conf_device_release(struct device *dev) kfree(idxd->wqs); kfree(idxd->engines); kfree(idxd->evl); + kmem_cache_destroy(idxd->evl_cache); ida_free(&idxd_ida, idxd->id); bitmap_free(idxd->opcap_bmap); kfree(idxd);