From patchwork Mon Mar 13 16:31:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 68923 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1289911wrd; Mon, 13 Mar 2023 09:46:36 -0700 (PDT) X-Google-Smtp-Source: AK7set9Oh6xt/Vrjf6ZGIU1EnWl0H6zbm49wbwQk8Hgyk4DG69VzMdUAJfjkp1nX505yPIjbuu08 X-Received: by 2002:a05:6a20:918a:b0:be:ea27:3c16 with SMTP id v10-20020a056a20918a00b000beea273c16mr34140238pzd.35.1678725996653; Mon, 13 Mar 2023 09:46:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678725996; cv=none; d=google.com; s=arc-20160816; b=FfEH8y36Eby3WOJ7KhrwlXuZLnqzN+SGCDNFr6RP2ntfqz+CHT6hkMglW2xK9EKh5/ cFpPkGPRoeg3sQL3+2+eJabp9dcjIOJQaT/yBWIjNRA5VCc63/OQwBjZlKIW+swszEXm vC1D8rcWXIgiDqUHIiSLd2inGOk5PVWfKoK7VON+qrceplx4K5uo2FsUGKEEsJD1ic9z KM9IXtfFwy8uaAJTRg78AB9tls5Ybufww0MxkWP5g9yvn56p258Dkldki04IfBFIiplg stcplw3fPKBpPlEum5ZLaXF7metRJfFelZYEyGz9WjgnRgVTSBkHiw92AXk7p4NcbIBS vnmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=IacwAyjPTNhi/tmrdS6hhYpxHKnIxK7jZ03eSL+e44E=; b=vECZID5Yvgs7E+7q5IiplgB2JAfZJ43uD5H501KKPtvpGy3PaR5ut0NANiqlMfxO/i GGbFfqRIDOMUWNBGPSCG3O7O8lE9lJa7rNsi6La4qEqixAi+sIrEkFYg0zbWfY4OvE69 /MfwZZOZK9i12qLOnjsKfaHU+qH6vjMg4Mif26Ql64ed/7ItWMxiMFRGMaYJhjhpwuMI YgI2ny4svLiEDDNpotxcbAtip4U4YWezUZqOzvOT3xNFMUynoekQccdvKp4ZWjJGFrlm kyds3dVYb78CVi2qN8SibrYdfiWfDJCnKvRCPYl9gR3eBLDsuAw766N8QRxUo6s561QV 6+pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=SQGyceuW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z66-20020a623345000000b006248c83c4d9si2820132pfz.242.2023.03.13.09.46.24; Mon, 13 Mar 2023 09:46:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=SQGyceuW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229983AbjCMQeI (ORCPT + 99 others); Mon, 13 Mar 2023 12:34:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231279AbjCMQdu (ORCPT ); Mon, 13 Mar 2023 12:33:50 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7AB01C169; Mon, 13 Mar 2023 09:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=IacwA yjPTNhi/tmrdS6hhYpxHKnIxK7jZ03eSL+e44E=; b=SQGyceuW32BcU07IBhF1R ygBdWL1vj+hmYGv//ILgyM++7Z0b9ih5TQhVUr5vQaEPGa8MlPY1tInrA+dHfSNk WahBZnCPUa0/q4XczHmZq3p7xGMTzt9jkILpnQB1Gc56sQ5dqtORP1nLaYGmaxvF skU35mp3ealNe5Rw4OLDHo= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g5-3 (Coremail) with SMTP id _____wDnTI3aTw9kcosTAA--.14497S2; Tue, 14 Mar 2023 00:31:23 +0800 (CST) From: Zheng Wang To: mchehab@kernel.org Cc: hverkuil@xs4all.nl, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH v2] media: cedrus: fix use after free bug in cedrus_remove due to race condition Date: Tue, 14 Mar 2023 00:31:20 +0800 Message-Id: <20230313163120.3741811-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wDnTI3aTw9kcosTAA--.14497S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7uw15uFyUCF1fAryDGrW3KFg_yoW8GF4rpa yYka45CayUtF4Yg3y7Ar18ZFy5W34I9w1Fg34xJw1xtas5Jr1Sqr1Fy3W7Gwn8Z39Yka1a vF15X34Iqan7AF7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zi-eOJUUUUU= X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiQgMxU1aEEpIz3AAAse X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760271790667732495?= X-GMAIL-MSGID: =?utf-8?q?1760271790667732495?= In cedrus_probe, dev->watchdog_work is bound with cedrus_watchdog function. In cedrus_device_run, it will started by schedule_delayed_work. If there is an unfinished work in cedrus_remove, there may be a race condition and trigger UAF bug. CPU0 CPU1 |cedrus_watchdog cedrus_remove | v4l2_m2m_release | kfree(m2m_dev) | | | v4l2_m2m_get_curr_priv | m2m_dev //use Fix it by canceling the worker in cedrus_remove. Fixes: 7c38a551bda1 ("media: cedrus: Add watchdog for job completion") Signed-off-by: Zheng Wang Acked-by: Jernej Skrabec --- v2: - use cancel_delayed_work_sync instead and add Fixes label suggested by Hans Verkuil --- drivers/staging/media/sunxi/cedrus/cedrus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c index a43d5ff66716..a50a4d0a8f71 100644 --- a/drivers/staging/media/sunxi/cedrus/cedrus.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c @@ -547,6 +547,7 @@ static int cedrus_remove(struct platform_device *pdev) { struct cedrus_dev *dev = platform_get_drvdata(pdev); + cancel_delayed_work_sync(&dev->watchdog_work); if (media_devnode_is_registered(dev->mdev.devnode)) { media_device_unregister(&dev->mdev); v4l2_m2m_unregister_media_controller(dev->m2m_dev);