From patchwork Mon Mar 13 15:49:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Fitzgerald X-Patchwork-Id: 68910 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1277800wrd; Mon, 13 Mar 2023 09:22:30 -0700 (PDT) X-Google-Smtp-Source: AK7set+J96uc6VCF1+vWuYuYhB2E6dtOhQDikQJB+Ye8mrFHElEJsCFV0EQxP8N2H9BbonBd62eZ X-Received: by 2002:a17:902:e88e:b0:19a:8636:9e2c with SMTP id w14-20020a170902e88e00b0019a86369e2cmr42448845plg.57.1678724550178; Mon, 13 Mar 2023 09:22:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678724550; cv=none; d=google.com; s=arc-20160816; b=NOU1yo0OCubVk+OYcSr7JTylJmZYzofawIDAy74A7HlZUaxtx/DyI1NdZosjmca3N1 Zp3/Ek7m+qyZsgh65QP05FLFbZI7OoGoBrH07tMtSEsdBJs6DFulyqJtVE31ZJrtve+F Znh4uzOrBvqoPhrnDFnPyuTa3fJOjeZH1vTxhSbRbO/PzORNoCuPfEiapywAfucAwjlk tR7I/0sdLxSCME1SGE2oa9dTNlX0BhmCIkzO5tgfvvHK89t/6MR0s/W/3RIwq/Pphmpm JTrxFn862sQOKGqjRs/gT8piMlwggwIOqAraQU4IFo3KBglSE8sonkNstlVtvoKNHJ7j rnmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KSx4vfnoG0hKeX0+I8Xc6vC4Q61Hdoi1UYzczfNsx1Y=; b=tfgPVkVfxO707x2idpi6iZwQdPxwNZIx3egC8gnfeC+AjoS6N2ptH5uBhh9bKodkVI FZVZFb68rzLMBN+soHklj48wiSz/Apa9DI5EJqMZUFc2u0F5asCF7RqqrFx4SJk4HzrR +b0NNed0RnpSo9OADjmkGoxkLvRDnErywQU/KbTksdaOt4pvNp4GjXvDl+5i4Adr5a7Q /9p5eq6Mm9gYqELFB8XMNigHHDAAxwadgn8vr0G4LqookWu9N2po+DCrwSgEGiQ1ecZB 2lBv9pJORk67x9oyPO0K7/+EgcOAYVp2pka3Fx8oMBZH+xssTLq/FMUkZUAf3oAt3uxb sDpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=kGObCyT8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z13-20020a170903018d00b0019e95180a08si139123plg.59.2023.03.13.09.22.17; Mon, 13 Mar 2023 09:22:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=kGObCyT8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230382AbjCMPuo (ORCPT + 99 others); Mon, 13 Mar 2023 11:50:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230250AbjCMPul (ORCPT ); Mon, 13 Mar 2023 11:50:41 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFF5151CA3 for ; Mon, 13 Mar 2023 08:50:26 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32D5bF4B000339; Mon, 13 Mar 2023 10:50:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=PODMain02222019; bh=KSx4vfnoG0hKeX0+I8Xc6vC4Q61Hdoi1UYzczfNsx1Y=; b=kGObCyT8HDSo3bqsnFcpTx3x8hkeu6dvBqFi4dqTMpoaoH8waBP4fYgGO7lTRHWvpg7V 5WMKkdAtNASodLRPckCaDQ5LxGOEKnbPRb0l7IDOYGCYIV4+1Oyy5q7GMHim+4R1+iwc h9I8j/xuZPDuuKansrp+NYIHMednQZLvspVB0KC6gkn1mP0pnuuN0hvnauDQn44Htwbw 35qgNqLSD/e3VK+3STcZl1xTLbg3v7MiHzOg3YCguRckCbLBZFmgKoIHPr7ILQrNnf6m HG2K1xYZ4KcpJppSXfpIUGiOZoljvxDWXf5hwBk7a3x5jjFYIHpdTWt0TPtbsGNlgRjD pg== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3p8pxvb6hn-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Mar 2023 10:50:06 -0500 Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Mon, 13 Mar 2023 10:50:05 -0500 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Mon, 13 Mar 2023 10:50:05 -0500 Received: from EDIN4L06LR3.ad.cirrus.com (EDIN4L06LR3.ad.cirrus.com [198.61.64.92]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 4DCC311D4; Mon, 13 Mar 2023 15:50:05 +0000 (UTC) From: Richard Fitzgerald To: , CC: , , , , , Simon Trimmer , Richard Fitzgerald Subject: [PATCH v2 3/8] firmware: cs_dsp: Support DSPs that don't require firmware download Date: Mon, 13 Mar 2023 15:49:50 +0000 Message-ID: <20230313154955.4268-4-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230313154955.4268-1-rf@opensource.cirrus.com> References: <20230313154955.4268-1-rf@opensource.cirrus.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: fx62dAPgC7-5CX24XJT20l2I_acxx3Xp X-Proofpoint-GUID: fx62dAPgC7-5CX24XJT20l2I_acxx3Xp X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760270274296200905?= X-GMAIL-MSGID: =?utf-8?q?1760270274296200905?= From: Simon Trimmer When a DSP can self-boot from ROM it is not necessary to download firmware during the powering up sequence. A DSP that required firmware download would fail in a previous configuration step if firmware was not available. Signed-off-by: Simon Trimmer Signed-off-by: Richard Fitzgerald --- drivers/firmware/cirrus/cs_dsp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/firmware/cirrus/cs_dsp.c b/drivers/firmware/cirrus/cs_dsp.c index 97b73a254380..513136a924cf 100644 --- a/drivers/firmware/cirrus/cs_dsp.c +++ b/drivers/firmware/cirrus/cs_dsp.c @@ -1301,6 +1301,9 @@ static int cs_dsp_load(struct cs_dsp *dsp, const struct firmware *firmware, int regions = 0; int ret, offset, type; + if (!firmware) + return 0; + ret = -EINVAL; pos = sizeof(*header) + sizeof(*adsp1_sizes) + sizeof(*footer);