From patchwork Mon Mar 13 14:49:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 68876 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1229907wrd; Mon, 13 Mar 2023 07:51:16 -0700 (PDT) X-Google-Smtp-Source: AK7set9w7nzKM8C8Pnv4tpT0ai0VBaeh1QwF0VQxwdSdNK9vTb+zGCASQh2EZfNDfZYQADu66/w5 X-Received: by 2002:a05:6a20:8ec6:b0:d3:7ac3:bc9e with SMTP id m6-20020a056a208ec600b000d37ac3bc9emr6691310pzk.49.1678719075890; Mon, 13 Mar 2023 07:51:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678719075; cv=none; d=google.com; s=arc-20160816; b=LGqgqfytyTFYpfOkHdr2iIEk4x7ne2CGBM/CUwGy/ZNeOvW3JC12A+yRkZB32NPTYj JKpwwWuXR/GEkpC+2MIifvvSAu2aHEEvy8el4tgBwKoeZeWdstBN6CvK24gsHRderyPe qddzbY0/SLhfKB3jjQIo2T2cKVlbXHjY4SWVd+F/sMwpY07yTbVbRuLJz2eXlai4uPp3 8hYh5jd2hfwESTzqW6OF8ZD6Bi/Wff5idYGM4PpTqDXLHkU3NrT31SV9dbXB1CEkZ7cQ VaCMxrA3leaRQUeLgB61smEgLwluD7n+36gYYqvQylsbrZzc0so/DH/tGx56/hbLcBmx uuJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZVDEkwpSNBnNA5bvC0eSecX/xh6oUxrJTLdGIKP8nY4=; b=T59zySUU7xrUatm+d27FG+EMYCB6ysAA0Q/4sCbmr32rifx/qks4s5QWCLbaqL3MBc uG6iq8/faePcwjqo0VP9o1TxnFoLDOkBUksFLgPBoCvkISz3HX0vXTadMmgL/hr2N7il a1QfoOuv4nEx553F4DHrG0LRMzpIbQc7fEkJMAFbAVpovn4idYEez2tfQrgpND0sEB9G suG10GYYPbIv18vFPdCZoiusDrHNEroE3nYEtg8BLRGiDfwl/Ww70mhqqHNorgd6RwJB AKY2L+CIoFhi1yVav0FdhTJN6KQuQmSCwl2aHHwet3eCU512ORoCAwSKKtO9pkBIkoC0 QAjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RXRkd3oQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i17-20020a635851000000b00503d90c16efsi6631995pgm.336.2023.03.13.07.51.01; Mon, 13 Mar 2023 07:51:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RXRkd3oQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231549AbjCMOuD (ORCPT + 99 others); Mon, 13 Mar 2023 10:50:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231524AbjCMOth (ORCPT ); Mon, 13 Mar 2023 10:49:37 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C14835940B for ; Mon, 13 Mar 2023 07:49:29 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id er25so21626903edb.5 for ; Mon, 13 Mar 2023 07:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678718968; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZVDEkwpSNBnNA5bvC0eSecX/xh6oUxrJTLdGIKP8nY4=; b=RXRkd3oQBZNGIksLWfy2ollTwlLx9KqZB/gsoL56C2mLEiy3owePjpNvyP9Q61uls6 ugV1YmgSSIroPFv4zbSXYYoTxtQvgyF4lCo00ZCDS4J5tc8DM2Gu8Iwhfw7aetLpexLc Gx+htkR7g7YyAH3iyaOpNIiLVFzggbUcT1Rj9rxwL6K+K3T1gwDFHV2pWMcBQ4OxDCC/ ZjM6bcJoiOUgu+YcB0xbA3tbujpl/waZKH4QvWGPy5Be9E0iSohARcIDn0XTAxmMec4P eV72mcrrPo9Hh3SUgOz1wGV8HMdCnkAwV+MCfDV645CGRBDwV5s6uQFE1XPqArOFg7KF aIPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678718968; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZVDEkwpSNBnNA5bvC0eSecX/xh6oUxrJTLdGIKP8nY4=; b=4HozZi/i7L8U2ZaAePOqQNa/BVwDICPc417YqJrD3hx3N0DMw1ozz/F0nwqqypvhoc gb/l03fQyqxNuVgtA3uVIQtLLh7u2EjeXswSiKlu5UOAcKV4fyrPC/T3AI6n29rKdf75 ebN2zYri0iPGDgZtOzPty9/vUXVF1/jReNPq5bMfIuGoAFJ8EApqMw7HSvGgYMY5GE6V AhWGm64Ubpn9tPlw0L0l67+xlIrXhsRWpFUnFfeQwz1Y8kO3eb3qiutLlp/LkVGuEQY+ gwJ4GHH82Y0nEaCxVvmxT1dF7lRbnJUV/lOm1exPK1yxA6tZ3teNIDa4/TZcOfS5MuDA 81MA== X-Gm-Message-State: AO0yUKVmzXmDONaPTO4tu2Hod84KTUTKD43TYYUb8Gka2tGfm2/01gjm a7kwW7dP5NyfHbeYyz6TCmimDg== X-Received: by 2002:a17:907:787:b0:8dd:76d5:a82 with SMTP id xd7-20020a170907078700b008dd76d50a82mr46118862ejb.47.1678718968371; Mon, 13 Mar 2023 07:49:28 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:69db:4882:d071:27c4]) by smtp.gmail.com with ESMTPSA id ia17-20020a170907a07100b0092153c6b549sm3030164ejc.22.2023.03.13.07.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 07:49:28 -0700 (PDT) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Sylwester Nawrocki , Andrzej Hajda , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v4 03/10] media: samsung: exynos4-is: drop simple-bus from compatibles Date: Mon, 13 Mar 2023 15:49:09 +0100 Message-Id: <20230313144916.511884-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230313144916.511884-1-krzysztof.kozlowski@linaro.org> References: <20230313144916.511884-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760264533683074373?= X-GMAIL-MSGID: =?utf-8?q?1760264533683074373?= The FIMC camera node wrapper is not a bus, so using simple-bus fallback compatible just to instantiate its children nodes was never correct. Driver should explicitly populate all its children devices. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Do not depopulate on errors because it causes several errors. --- drivers/media/platform/samsung/exynos4-is/media-dev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c index 22baa429ed5d..6839007edf1d 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.c +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c @@ -1440,6 +1440,10 @@ static int fimc_md_probe(struct platform_device *pdev) if (!fmd) return -ENOMEM; + ret = of_platform_populate(dev->of_node, NULL, NULL, dev); + if (ret < 0) + return -ENOMEM; + spin_lock_init(&fmd->slock); INIT_LIST_HEAD(&fmd->pipelines); fmd->pdev = pdev;