From patchwork Mon Mar 13 07:54:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 68671 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1059463wrd; Mon, 13 Mar 2023 01:17:01 -0700 (PDT) X-Google-Smtp-Source: AK7set/QDOT0L2rvhLST2nUkIs9Z69RUwZGJyNdehmBhl65Ly8miepZKyFqzrZxK4ClQRqvmATgD X-Received: by 2002:a17:902:d4cf:b0:19e:500b:517a with SMTP id o15-20020a170902d4cf00b0019e500b517amr39723134plg.69.1678695420798; Mon, 13 Mar 2023 01:17:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678695420; cv=none; d=google.com; s=arc-20160816; b=HLXXgeQX4NSugZi7E0dAMdIg1EoFfjbFWvRxGtLHuSjOqXHol2tFWA3CExMhSYWS9k SnX2Pi4oCRt49Gr399P+xe77bE1MHNVlaDsBWv5Blmev7rfzLwIYcj7oN0vzTy9eXMxi ksYAhMJGGVPZSvMP1qwjWgwuMaIWN1wFORmrBVx9VN9qmS+vjzFYsYSr6t5UxD/F6LLr poU9sWwdoXtDdRgbnjaxmzJPV3sGipowJXe6BbwqFWTZSlps/rw7LLDocEDFe3M49J2L XqoxQXvNjA4dgRxpRjqoUsNCiYji2+hJMWLmnDpUQSEORtfxVewQsBqDsc3paqPs0cYK rvBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=wXFwpL38cpVPsFfuTqy0wp3LN89Pinq43rhwBzosYAY=; b=m95N240hhO9HB1/BI64mEtG/qaB99ttu4/qAAKkdPixvmvJgT2OnjMQ/SkjDadQlAt u+xEwKcnS1VfLAEQtd2rpxUi2xoAcLTKrqWBe85VKqEDWCVw9nG2xj1bYSaNlM2DXLy5 IPW8VbkYgN29rmvuAXunIu7CKsC2t9cEHGOUp7kvqVwS7pXaeOuOm8jv5uBizN8GZggA EpsBbnxoCfW+8o7jPgR0FazFgz6q9Oq+8AqYJ6eycbQsNeM4H7Mbo54h+ACScJ/X1xjt 8q9nFsrx/NcRtJJVD/9wxF5TAEcDfJmk4r22lud+8wP7rKd40Y4LqLBCVNT5pKIem+3A AEvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kl15-20020a170903074f00b0019cbe4c22f6si5975784plb.516.2023.03.13.01.16.45; Mon, 13 Mar 2023 01:17:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230339AbjCMH44 (ORCPT + 99 others); Mon, 13 Mar 2023 03:56:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbjCMH40 (ORCPT ); Mon, 13 Mar 2023 03:56:26 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DE9554CAC for ; Mon, 13 Mar 2023 00:54:42 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbd0x-0001jH-04; Mon, 13 Mar 2023 08:54:39 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pbd0w-003nap-Bg; Mon, 13 Mar 2023 08:54:38 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pbd0v-004TOn-Il; Mon, 13 Mar 2023 08:54:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Daniel Lezcano , Thomas Gleixner Cc: linux-kernel@vger.kernel.org Subject: [PATCH 5/5] clocksource: timer-ti-dm: Convert to platform remove callback returning void Date: Mon, 13 Mar 2023 08:54:30 +0100 Message-Id: <20230313075430.2730803-6-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230313075430.2730803-1-u.kleine-koenig@pengutronix.de> References: <20230313075430.2730803-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1920; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=jWLwC9JWT1zAkN3MuVmGacjm0Ju2XN58CNDdUcULjW0=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkDtayowyjk/IGAmlFJ43CRKgvHOPq7G6WGJL55 GpXMyDV2KeJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZA7WsgAKCRDB/BR4rcrs CWXEB/9i8nksWGfGxjcU5//fTFQp0JrVL+aYr3XZNVBokMVlPNHovvmtXwb0ar6hVrucmdOaQHc HQbvBRj+FQSk1WtmBTgEF2wZWZGfY0FXFEvKHIguHvUYn5EHxB5b4VaOO/ZXbSOGBT7TEPcABA4 JZ31uuaja0mtksTBiwKJ1Z7VRc/m7FRUfWhVgUNIxfiAj8ulaYkciidGmEhhsbFp/mI4qpFmrRa 4SaPqeKVWPF5duWabzo5KDd1Fvm4VVd+6Oaeg21ORxpcuogQUXcbk3eKYRWCKLUtcrxcoVh4lea lQ4bqwekXbs5usuzy+hIv+AuE36wL46ttE4fjAIOSONntrze X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760239729523990541?= X-GMAIL-MSGID: =?utf-8?q?1760239729523990541?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/clocksource/timer-ti-dm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c index 098562bda487..ab7a6caa36c5 100644 --- a/drivers/clocksource/timer-ti-dm.c +++ b/drivers/clocksource/timer-ti-dm.c @@ -1177,7 +1177,7 @@ static int omap_dm_timer_probe(struct platform_device *pdev) * In addition to freeing platform resources it also deletes the timer * entry from the local list. */ -static int omap_dm_timer_remove(struct platform_device *pdev) +static void omap_dm_timer_remove(struct platform_device *pdev) { struct dmtimer *timer; unsigned long flags; @@ -1199,8 +1199,6 @@ static int omap_dm_timer_remove(struct platform_device *pdev) if (ret) dev_err(&pdev->dev, "Unable to determine timer entry in list of drivers on remove\n"); - - return 0; } static const struct omap_dm_timer_ops dmtimer_ops = { @@ -1275,7 +1273,7 @@ MODULE_DEVICE_TABLE(of, omap_timer_match); static struct platform_driver omap_dm_timer_driver = { .probe = omap_dm_timer_probe, - .remove = omap_dm_timer_remove, + .remove_new = omap_dm_timer_remove, .driver = { .name = "omap_timer", .of_match_table = omap_timer_match,