From patchwork Mon Mar 13 07:54:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 68663 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1053691wrd; Mon, 13 Mar 2023 00:59:36 -0700 (PDT) X-Google-Smtp-Source: AK7set+kSCYp/SMYfAbG3B1PawAjK71VrKmhqzO4XflHWMDDASEY+IM8xn4pVmqgIvt/pRekcU2U X-Received: by 2002:a17:903:22d2:b0:19c:d32a:befc with SMTP id y18-20020a17090322d200b0019cd32abefcmr37245751plg.15.1678694376089; Mon, 13 Mar 2023 00:59:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678694376; cv=none; d=google.com; s=arc-20160816; b=sSQMirVhH9ZvGR4BEivtoea2Rq9zUiXHMYoEWGsklbe2+RS7+00LSlo+RBKPxinLsS w7i9YGmRwmQX4zSbuwqBtPbh6KCd/gka1MHW3EJHL37ICO7H3GtUd4PlcJaPz63ESpmQ NCJcw3EW6wUPrjE7qgevTDkYNkKcnhzINpJmRnLO6B2gxHPlC4LBTKt0qQ7FBZrLyUvx RdJk/493iveNmbZJdvnHNLPjdhhXuk30FHP8hbqTYj45sV3H9HJGbPy3fo1gyg9tvAct aZn+JZJbQsl9YoQ2L6yFMHYNzrGCc0W/+9IHTL7e2KKjb8xDixIkoO1qC5rOAn80PvTs JOgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=jnJ6Jf2JoCDE1MTeqHLkiH+LcEp+8y2+PreobRZO818=; b=RjAgA08Fpfr3p1CIC5x4W6FtAtYKFb0ZIFztrkXsAVK/rxR9QzWKokPJ/913nmn24J hNHwFKZ41vUuf8e8XzuMgERJ5foyir+xcXqtnvpEWFTpOmNxcYj4KSYX85nfrc67+sYk RZd4wUMlZLlQAEVPKYkzYLDM8vZazh38f73Xt3YQJiZ9MeZSaz2rwXlMj8QzalvMQsiZ D9g0gXUbY9f6y3P0ArKJNUsFjH3yn+v91rPp+1PPHpEiCRArMVoLb4L7PcRYQngY3o6c DSLUCFnCYzekRcf6ZJGPWY9rGJ1xihXmfEFmgCPYiOCVMIosZlOYIwmZjpyUNDCDjJzo tDaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b6-20020a170902b60600b0019c354055d0si6318896pls.304.2023.03.13.00.59.21; Mon, 13 Mar 2023 00:59:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230311AbjCMH4v (ORCPT + 99 others); Mon, 13 Mar 2023 03:56:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230101AbjCMH4X (ORCPT ); Mon, 13 Mar 2023 03:56:23 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D3C52A16D for ; Mon, 13 Mar 2023 00:54:41 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbd0w-0001jA-OO; Mon, 13 Mar 2023 08:54:38 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pbd0w-003naj-2Z; Mon, 13 Mar 2023 08:54:38 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pbd0v-004TOg-8C; Mon, 13 Mar 2023 08:54:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Daniel Lezcano , Thomas Gleixner Cc: linux-kernel@vger.kernel.org Subject: [PATCH 3/5] clocksource: timer-ti-dm: Improve error message in .remove Date: Mon, 13 Mar 2023 08:54:28 +0100 Message-Id: <20230313075430.2730803-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230313075430.2730803-1-u.kleine-koenig@pengutronix.de> References: <20230313075430.2730803-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1137; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=JFLgDu9G0dZdZrBAfrFBT/sAvQRPGcgYsmNCWrrkkd0=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkDtascXVc4tZHw8XXjA2bAkq4kTxYDENhomOZK +lfPD6gXVyJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZA7WrAAKCRDB/BR4rcrs Cf9aB/0a266jejUWRQymegTjmEjuZiTNzMbIA04dKu7N7B/DOuxscYf29RX4rb4hsDH2wF1JC3z MHImda86n2RmtQ86FtByfnd6z0472OrMwFKfbjj36Tr+a9CwKKdVV/uhIrMMZpBiNH4ri2BGeec 0Y+cXV/jkOP0BtqqzijXSP6jniz1eJejlCI+rmDm2LOnmjWc/rdX9i/mieTsdJpgBfEwnqKam1r IgiOevEHY6Et2eHeRWA++fnRzqOENRBYnnbdchp1nO+FcAyTxTRAxMcH0LoFdWLKt/K1TF2UX57 c7+dXBm8Q7gYXSZ5vDTGE+myKjGxJ0Nr+QEz4+fu6ZoOhaSL X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760238634405387476?= X-GMAIL-MSGID: =?utf-8?q?1760238634405387476?= If a platform driver's remove callback returns an error code, the driver core emits a generic (and thus little helpful) error message. Instead emit a more specifc error message about the actual error and return zero to suppress the core's message. Note that returning zero has no side effects apart from not emitting said error message. This prepares converting platform driver's remove message to return void. Signed-off-by: Uwe Kleine-König --- drivers/clocksource/timer-ti-dm.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c index b24b903a8822..098562bda487 100644 --- a/drivers/clocksource/timer-ti-dm.c +++ b/drivers/clocksource/timer-ti-dm.c @@ -1197,7 +1197,10 @@ static int omap_dm_timer_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); - return ret; + if (ret) + dev_err(&pdev->dev, "Unable to determine timer entry in list of drivers on remove\n"); + + return 0; } static const struct omap_dm_timer_ops dmtimer_ops = {