From patchwork Mon Mar 13 07:54:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 68664 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1053699wrd; Mon, 13 Mar 2023 00:59:38 -0700 (PDT) X-Google-Smtp-Source: AK7set8m89kfmRwyz/7M+EmliHfwel7qP8lZqW/1nINh6wjkE/9PAoEInNtc4jONlqtes85DgxR4 X-Received: by 2002:a05:6a20:4d8a:b0:d4:9d94:8e7c with SMTP id gj10-20020a056a204d8a00b000d49d948e7cmr1146934pzb.2.1678694378605; Mon, 13 Mar 2023 00:59:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678694378; cv=none; d=google.com; s=arc-20160816; b=upMi+dFx1s5QjWc7SNqVSJh9JLmV5qsNVFCWXv9Wv9wU+mdX6XA9a7Uh+o4uVb8fz8 5wAAGvsXvYJkIRoZtI/58ENA6xWPh8PJQVmXKy0/17vP7SMzOOfusDQzN4taHz9B0jOn GH6DrU6J64l4tvDGfA0uDm907sglYB6xLUwiDRfw1XMfkU0IzdOHR1O6gZAePjS6fCdM ypuR53D/q8ynpDnbYTuPz64CsQIYP+7zMlQ0tA7QmqD5UZwKXXJODDvkazn3UYiaWDXg XbgHL3xHUkgbhKrjDyknhahfEk3cqz+WOQaFMezL4wDAHFr0ifeCL3J2PnG7skW+DP7X TgFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=pu4UaG9sDteehSaVU/0WbT5/oFqRuRbehJVx3F5C/vs=; b=TFGOw57XMT0gPMmz1uhnWbrQ9EgMfx7tlxkaLWWxbF56oYgA1LWJJIeFeva+XlHRMC B7W2N1U1dJlMmUNpYN/5QrC2FDEjIseNCvPucxndunBkYlSX3zvV0Mo3xipprjlS0zrU KyFe/LZ3BBNpi+weKlfAyIde/w/D1Moqfsei6sx0Ft9784qcQWRHCpqfM2jtPnnDiOp8 2lG7/5Y2J5VtqZPJFQojVA7QZZOVF/OTNfzAcKjaew/f3vYEGUNVRp2zxP1dphFCcEMl JTjjGr5b9V6p+IKXV0nN6d3LlBiymM7zbsKAVA+MhzkGIFdKs9wpM16r85pGng2dUo22 K02g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p185-20020a6229c2000000b0058c800a75f6si5813997pfp.335.2023.03.13.00.59.24; Mon, 13 Mar 2023 00:59:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230334AbjCMH4x (ORCPT + 99 others); Mon, 13 Mar 2023 03:56:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229927AbjCMH4Y (ORCPT ); Mon, 13 Mar 2023 03:56:24 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D33024BE2 for ; Mon, 13 Mar 2023 00:54:41 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbd0w-0001j7-E3; Mon, 13 Mar 2023 08:54:38 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pbd0v-003nab-IO; Mon, 13 Mar 2023 08:54:37 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pbd0u-004TOa-TW; Mon, 13 Mar 2023 08:54:36 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Daniel Lezcano , Thomas Gleixner Cc: linux-kernel@vger.kernel.org Subject: [PATCH 1/5] clocksource: sh_mtu2: Mark driver as non-removable Date: Mon, 13 Mar 2023 08:54:26 +0100 Message-Id: <20230313075430.2730803-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230313075430.2730803-1-u.kleine-koenig@pengutronix.de> References: <20230313075430.2730803-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1514; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=jqp6GOMjSpdCmxIeDGA+mPUOdQcsY6oyMOjjcWRDVUc=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkDtamyYLCZb7RA67Pd0H1tRCDLB8Z9mshljoqR fIrbRirSreJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZA7WpgAKCRDB/BR4rcrs CeirB/9d9M2QhXLH2MlvVnu6W3F8eUc5j9eAVNlOVHW5GUYGTTdANh5pqKxOBhEHx8KKIeLBTEB XpesoDuc3EJ0TqhsC9VQfsiPBNXUOVL8idLaMVCirR/fq1ROX6LRdQdXbtoGfDl5Mjz8RO/A9OL FbckDAI6HY7PCod4ycEW4C9lFycNfGAxQK+mk4RlhEWI0OJFn9Xqa2qLHv0J6YfEsn4qiCyZvUs Z3KwDmeQR4/mcVSA4svEkEGOhoddqnaj4cvqr4zJmrBqA4tBDFJInwklrH3E5fcY2VPpFA6n6Uq 5ucUyd/8ybZiuTQok+YBLfA8HSpNPb00gk8Ik1pS6tKIg4w0 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760238636940195040?= X-GMAIL-MSGID: =?utf-8?q?1760238636940195040?= The comment in the remove callback suggests that the driver is not supposed to be unbound. However returning an error code in the remove callback doesn't accomplish that. Instead set the suppress_bind_attrs property (which makes it impossible to unbind the driver via sysfs). The only remaining way to unbind a sh_tmu2 device would be module unloading, but that doesn't apply here, as the driver cannot be built as a module. Also drop the useless remove callback. Signed-off-by: Uwe Kleine-König --- drivers/clocksource/sh_mtu2.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/clocksource/sh_mtu2.c b/drivers/clocksource/sh_mtu2.c index 169a1fccc497..6bd2d0299397 100644 --- a/drivers/clocksource/sh_mtu2.c +++ b/drivers/clocksource/sh_mtu2.c @@ -484,11 +484,6 @@ static int sh_mtu2_probe(struct platform_device *pdev) return 0; } -static int sh_mtu2_remove(struct platform_device *pdev) -{ - return -EBUSY; /* cannot unregister clockevent */ -} - static const struct platform_device_id sh_mtu2_id_table[] = { { "sh-mtu2", 0 }, { }, @@ -503,10 +498,10 @@ MODULE_DEVICE_TABLE(of, sh_mtu2_of_table); static struct platform_driver sh_mtu2_device_driver = { .probe = sh_mtu2_probe, - .remove = sh_mtu2_remove, .driver = { .name = "sh_mtu2", .of_match_table = of_match_ptr(sh_mtu2_of_table), + .suppress_bind_attrs = true, }, .id_table = sh_mtu2_id_table, };