| Message ID | 20230312235553.26298-1-rdunlap@infradead.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp926022wrd;
Sun, 12 Mar 2023 16:57:34 -0700 (PDT)
X-Google-Smtp-Source:
AK7set9JK2Yw0XAcLbiW5N3L5O6MfhTVF17G9YrOJKWasfh2IWzKM8tF7YYM6pSPNoMzQ7iHCCJM
X-Received: by 2002:a17:902:c40e:b0:1a0:50bd:31aa with SMTP id
k14-20020a170902c40e00b001a050bd31aamr610984plk.66.1678665454107;
Sun, 12 Mar 2023 16:57:34 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1678665454; cv=none;
d=google.com; s=arc-20160816;
b=Byqq/Q/HI9AeNZ1EL/IIsCxj+9gXhGalJ28ryn9TslZPuoWBixaU33jLIn+ZdtJ2yu
E+pgHUFYRfsIOJIMzzRF25fqTypezeb75GCsfM4bM0G7HAwHanFydh6OYMRHF1z3X9wY
5SCqP8G4XCYt2LJkS+FV+JqI+TaduFKpzYBKvYAVA1XRQd2ANn+VdEnk7coHKZKcLuzG
0X/TTAyNEGDRnV2deJWi5cfM15PeNSRPkeYpbHrGib43zkrN7gppYbbOcKDOW9l2IKVW
anpEZsOy9Jr0q38hwgBMQMCb8zDkMZ/31h2+b2VudXbG7oIjgXeng0VI6tl8otvlUMq1
J8Fw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=qEMbQl2Qv6g66qdNT3wlbLmVyaW+mXSdO7SM3E7aHeo=;
b=g0cywx23LicJgwUXxDBafBSYKfjmi261Z+OOvOPwvJdzPdwJV/oVE2c6VUlzK62J69
vod2jTQ8qEtVV2/mQJCivo8B+HhXDmsUKAOJeceRfuWBQto/2EJg8TMzJ8AthqCxJbtK
WlMLw1TBA4RH3Uxx+9utNdLq5bwJOllVm/RU0zLpBqO31gpQgTdyjWwXuGL9LnJvtsHu
aXYwGxivTVJISBCbLCj8Qrn4JDDaqCw0sNVtIZWGk4F4VB1owTiwsmAzZ0W7P5eDWwri
Tjr+rgqmwvv7YKJrjTFICkbgcixWdYJFmSB3fZtp352EXWGYfUjnAnssMqlWkQ6yqfE9
QQYA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@infradead.org header.s=bombadil.20210309
header.b=S7RTbYbF;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
ka12-20020a170903334c00b0019644d4246csi5239185plb.418.2023.03.12.16.57.19;
Sun, 12 Mar 2023 16:57:34 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@infradead.org header.s=bombadil.20210309
header.b=S7RTbYbF;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229494AbjCLX4J (ORCPT <rfc822;realc9580@gmail.com> + 99 others);
Sun, 12 Mar 2023 19:56:09 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52736 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229493AbjCLX4H (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sun, 12 Mar 2023 19:56:07 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org
[IPv6:2607:7c80:54:3::133])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D87A330294;
Sun, 12 Mar 2023 16:56:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:
Content-ID:Content-Description:In-Reply-To:References;
bh=qEMbQl2Qv6g66qdNT3wlbLmVyaW+mXSdO7SM3E7aHeo=;
b=S7RTbYbFj5gW7oiAaCBXHZ5hw5
coS4p/FQbo7dgSsvroDZr/nYxuudIBkqZfWLSDRhbRqNGeGrjDzpqAjoNcOLY44RrTYzjko3lLUA0
lQl+mjBv6+4M5dwXJQIQuPczbASEfDK+MDS02DS41q8ByzIGmapMkvhLVJPZuual0aEWgOR1OL1Sm
bQmqijt3AmOpAGNL4qI8J3LYh0PXMhzip4FibxmHCM4nr72clxX5E3Z0Y9joEuXKIQa96IF+AnP47
bkQLfv4RBwsebu9kvPXiB1wkLF+lHD2oHfAsxN/Fo0H6C5Q64hSpuqHyMELQLZiqnoPdQBQ37fYWC
WGyaagIQ==;
Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org)
by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat
Linux))
id 1pbVXg-003qDa-9l; Sun, 12 Mar 2023 23:55:56 +0000
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
linux-ide@vger.kernel.org, linux-um@lists.infradead.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH v2] UML: pata_cs5536: fix build for X86_32 UML with
TRACEPOINTS
Date: Sun, 12 Mar 2023 16:55:53 -0700
Message-Id: <20230312235553.26298-1-rdunlap@infradead.org>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1760208307424390614?=
X-GMAIL-MSGID: =?utf-8?q?1760208307424390614?=
|
| Series |
[v2] UML: pata_cs5536: fix build for X86_32 UML with TRACEPOINTS
|
|
Commit Message
Randy Dunlap
March 12, 2023, 11:55 p.m. UTC
Current build of pata_cs5536 for i386 UML fails with:
ERROR: modpost: "__tracepoint_write_msr" [drivers/ata/pata_cs5536.ko] undefined!
ERROR: modpost: "do_trace_write_msr" [drivers/ata/pata_cs5536.ko] undefined!
ERROR: modpost: "__tracepoint_read_msr" [drivers/ata/pata_cs5536.ko] undefined!
ERROR: modpost: "do_trace_read_msr" [drivers/ata/pata_cs5536.ko] undefined!
Add the arch/x86/lib/msr.o binary to resolve these undefined symbols.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Richard Weinberger <richard@nod.at>
Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: linux-ide@vger.kernel.org
Cc: linux-um@lists.infradead.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
---
arch/x86/um/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 3/13/23 08:55, Randy Dunlap wrote: > Current build of pata_cs5536 for i386 UML fails with: > > ERROR: modpost: "__tracepoint_write_msr" [drivers/ata/pata_cs5536.ko] undefined! > ERROR: modpost: "do_trace_write_msr" [drivers/ata/pata_cs5536.ko] undefined! > ERROR: modpost: "__tracepoint_read_msr" [drivers/ata/pata_cs5536.ko] undefined! > ERROR: modpost: "do_trace_read_msr" [drivers/ata/pata_cs5536.ko] undefined! > > Add the arch/x86/lib/msr.o binary to resolve these undefined symbols. > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Richard Weinberger <richard@nod.at> > Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> > Cc: Johannes Berg <johannes@sipsolutions.net> > Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com> > Cc: linux-ide@vger.kernel.org > Cc: linux-um@lists.infradead.org > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > --- > arch/x86/um/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -- a/arch/x86/um/Makefile b/arch/x86/um/Makefile > --- a/arch/x86/um/Makefile > +++ b/arch/x86/um/Makefile > @@ -21,7 +21,7 @@ obj-y += checksum_32.o syscalls_32.o > obj-$(CONFIG_ELF_CORE) += elfcore.o > > subarch-y = ../lib/string_32.o ../lib/atomic64_32.o ../lib/atomic64_cx8_32.o > -subarch-y += ../lib/cmpxchg8b_emu.o ../lib/atomic64_386_32.o > +subarch-y += ../lib/cmpxchg8b_emu.o ../lib/atomic64_386_32.o ../lib/msr.o > subarch-y += ../kernel/sys_ia32.o > > else Looks OK to me. Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
diff -- a/arch/x86/um/Makefile b/arch/x86/um/Makefile --- a/arch/x86/um/Makefile +++ b/arch/x86/um/Makefile @@ -21,7 +21,7 @@ obj-y += checksum_32.o syscalls_32.o obj-$(CONFIG_ELF_CORE) += elfcore.o subarch-y = ../lib/string_32.o ../lib/atomic64_32.o ../lib/atomic64_cx8_32.o -subarch-y += ../lib/cmpxchg8b_emu.o ../lib/atomic64_386_32.o +subarch-y += ../lib/cmpxchg8b_emu.o ../lib/atomic64_386_32.o ../lib/msr.o subarch-y += ../kernel/sys_ia32.o else