From patchwork Sun Mar 12 18:36:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 68536 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp833679wrd; Sun, 12 Mar 2023 11:49:57 -0700 (PDT) X-Google-Smtp-Source: AK7set8ND/ZB2dOVVW9JiCxXrQjMwbwHdAOwTLe1ckt1SAD9xK8F03UyEVIAKJofq+Xwz3bpL5/M X-Received: by 2002:a05:6a20:3d87:b0:be:da1c:df65 with SMTP id s7-20020a056a203d8700b000beda1cdf65mr36772811pzi.28.1678646996973; Sun, 12 Mar 2023 11:49:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678646996; cv=none; d=google.com; s=arc-20160816; b=m9VC3RLOqAvlUjX38OxUpGo0igbIaXC7l0RXCjOYrA6QgcEp3+NARD5yaCDh09RxuE Nk2zqkuQg1fb8N1Iifc7pzbgXTRKNlGWkZU/pOJdCMEGLgN8YFcahm8nQsl6r3RmCwov JjrDjYoITICvKot4zbv1xlv7TRqTrhRnusmsHomm4TRsmkPnOrQpNyXe4TtX7XFPu0KF XMnZ2rw3t6UAK7aU0Ga8tqNBe/xghQMYPMTBViRsbWONwgeQygTMr0rfOq5uUGBMw/y/ e6VYK8ylZUlxXywRwzAX8J9gklqB75uPcwTwiecCUSY5p/6PwbMgQ8Vh4IpEErUquo5u zfXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SuPzeXIkkvxZlmBGwuF8BA+hbLGZlSob+2JT6Oo/EEM=; b=v49z2fX3vE20wMCB+yUIqnEPJKexwPehFrF7o/orm7Var27O+EFKs++pnAeXVegKXG DL7SBpMJ3bdyol1xQTPhRwjAHTYDYUVJanCzmzudpTeAh4muI5HrVB1Ln6RAqrsxpESm Xs2r/MjYWXQlNn95y7k7qRcCOJMxkEQtlbIy/ymbv+2i54tSU2/azhnHtVIFqgEaDU8/ szrqOT2fjLs37rKKBIsdgG9znSHFjye5Xi74VjxxFUifZIx36jEpnsNEqttBAmuzekjW ja6h6e8wDXkHCgX2B513oekrG9WJSptGTvt656IbOeyOexSn48GYVT/N1U2VASRwDNv7 jrcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HOy1+bQP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s33-20020a632161000000b004e658a3b1b0si4543864pgm.183.2023.03.12.11.49.42; Sun, 12 Mar 2023 11:49:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HOy1+bQP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229839AbjCLSiR (ORCPT + 99 others); Sun, 12 Mar 2023 14:38:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230423AbjCLSiI (ORCPT ); Sun, 12 Mar 2023 14:38:08 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14266A25D for ; Sun, 12 Mar 2023 11:37:33 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id s11so40249896edy.8 for ; Sun, 12 Mar 2023 11:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678646191; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SuPzeXIkkvxZlmBGwuF8BA+hbLGZlSob+2JT6Oo/EEM=; b=HOy1+bQPa4p0NPb0+dDp2X9KViwR9fYIHAhZ8QfG2PdTYYULkJ2tKcmssHjeYG2oyt LUaj124iD2LEeKvnx94x7Bo8QxUudW87q5xc0RXZzrnFtJv/RLrWLE6jQrKS7pWdv/O7 EDxDbSTpKpWbGgUq6/yjuBJ4IfKBX/qJBYbtIXaXfT9v1MECLnPD14jLLNZBLlbuJOfq jUOE+M6I51ch40pJOZLBF/wGTOludsewVAQbDzYEN7Bjae8fFj3Ytd5TuJ+eyh532e4+ 0ewj4a7+zqTD6J9TUeQqrKEsdLiPWLaUbjIXkNfve2GOptPcoQ1oNfvp7T/6AkPC6C53 0/rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678646191; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SuPzeXIkkvxZlmBGwuF8BA+hbLGZlSob+2JT6Oo/EEM=; b=FwRfj09/H/FV2lienRi4aWev3oRWd1aHv8EHETKb/kznvQMcM05hbDbSgKG3+HWalb kHmbhArOtkZKnowdLorH734ymNhN6rLLHf1068UmZQd90IIhiF6xBcrOtjEEzqQ/mqUi KGzCxLGz0V2VEDn+xtYRYAlwtA5vea0O60l31qfs9KDkJA+ut0YLayyBY93tAo/5YWWf KDHSmLHFE8vnCuEz2AhfDsPuvxYCzQXDlzlbxK64kg2KDc0o85IaShid4lpndgH9/G6+ PEUbkxTnFULG03wi92D1CfEzbMrGVQZnM4I/1eew7odisLagjDj7ystbrDPjnmmpzWy1 qPLQ== X-Gm-Message-State: AO0yUKXDO28kcIVU3O2w/XrZBtvPvsL07/S4Su+xT87kNMKEitvxOJlb idcXHaTtoQ7IgoEAIg1WUphOpg== X-Received: by 2002:a17:907:7f0b:b0:907:9470:b7ab with SMTP id qf11-20020a1709077f0b00b009079470b7abmr35591538ejc.71.1678646191153; Sun, 12 Mar 2023 11:36:31 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:d9f6:3e61:beeb:295a]) by smtp.gmail.com with ESMTPSA id p14-20020a1709060dce00b0092669fb4ba1sm893806eji.130.2023.03.12.11.36.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Mar 2023 11:36:30 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Douglas Anderson , Stephen Boyd , Matthias Kaehlcke , "Joseph S. Barrera III" , Gustave Monce , Vinod Koul , Rajendra Nayak , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 5/8] arm64: dts: qcom: msm8998-oneplus-cheeseburger: revert "fix backlight pin function" Date: Sun, 12 Mar 2023 19:36:19 +0100 Message-Id: <20230312183622.460488-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230312183622.460488-1-krzysztof.kozlowski@linaro.org> References: <20230312183622.460488-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760188953123234019?= X-GMAIL-MSGID: =?utf-8?q?1760188953123234019?= This reverts commit 46546f28825cf3a5ef6873b9cf947cd85c8a7258 because it mistakenly took PMIC pinctrl/GPIO as TLMM. The TLMM pinctrl uses "gpio" function, but PMIC uses "normal", so original code was correct: msm8998-oneplus-cheeseburger.dtb: pmic@2: gpio@c000:button-backlight-state: 'oneOf' conditional failed, one must be fixed: 'gpio' is not one of ['normal', 'paired', 'func1', 'func2', 'dtest1', 'dtest2', 'dtest3', 'dtest4', 'func3', 'func4'] Fixes: 46546f28825c ("arm64: dts: qcom: msm8998-oneplus-cheeseburger: fix backlight pin function") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- Eh, embarrassing. I would say to myself - use dtbs_check on patches, but I think that time there were too many errors coming from Qualcomm pinctrl bindings. --- arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts index d36b36af49d0..fac8b3510cd3 100644 --- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts @@ -34,7 +34,7 @@ led-keypad-backlight { &pmi8998_gpios { button_backlight_default: button-backlight-state { pins = "gpio5"; - function = "gpio"; + function = "normal"; bias-pull-down; qcom,drive-strength = ; };