From patchwork Sun Mar 12 16:14:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 68381 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp782752wrd; Sun, 12 Mar 2023 09:17:17 -0700 (PDT) X-Google-Smtp-Source: AK7set9Q8ulv5ZOqztlXricM5TW4x9qU6v+KT5KXm/y01XzBGX/zX469ubBO3nNrqy6B3UdEf17F X-Received: by 2002:a17:903:1251:b0:19e:d60a:e9e with SMTP id u17-20020a170903125100b0019ed60a0e9emr23002878plh.42.1678637837681; Sun, 12 Mar 2023 09:17:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678637837; cv=none; d=google.com; s=arc-20160816; b=XS/JEcuRTivEGlVlv7U8dkV+qnzNZw/DOtMMEx6Ee+3twjonCqRAA1/lbatIMSK7LI ixCGXcgWvjH48y0zMsxiWY0RPtuFKZp7IhTRZFS4CpKjtwigcIj08Xitlbci4LU1XdzO sW6lqe/cjxA6Hd0Sh/Fs9o9EJKTSJghPDZrE+DSj9pPjaFiptgInSrtrKMtwEyh8kyQJ TZDjOJjofqLV/48fMAkjuUQ/IWfm6YIIAOKhgOiqA8l1gwf/BqyGgc9Z+axXQwxZo29M HLy0H3sSV1BURCJKIy0tIbFACb2DCeGVGXzqoKHxmWY2gHw8++7sUjNJjRy8R3PvJIio 2lnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8PiSTVH0whsDB0W0/pCvcWtMqaGqnpZlb+b+VFWQh6E=; b=oVeFjPxm+OhKf8TBXk+jayBv6JHCkAQaHwUvq4JsZFywu/t8WydMNjFzyBN0sJbHk5 c3hOLsf9D+qHYXp+XEajVG6lPg8i0YaJr7mNes3vMcWvt9i4gY5edMvKOK718edgSvQt 7iOWlZh4FLzPSAIlFecOJ8nQO6l0fy8VoxALHrzRzXJ+6GUVh6K0peZWBla9IdxFa5yZ CEzpysSe7T/e71eos7EnGCAcn6SSsT0PrQwL1U+HHr0tvDJbGySGsrnLOPCn6GyV3lZd HaD3z4MhTe7/Cy4Zp9Q4iAKfRZksxBJCFs5OrP7DNA6C38iVJATZ+U4yUlhdxsSXwZ4L VDyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n11-20020a17090a2bcb00b002290cb1ca2csi4400521pje.177.2023.03.12.09.17.03; Sun, 12 Mar 2023 09:17:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230256AbjCLQQS (ORCPT + 99 others); Sun, 12 Mar 2023 12:16:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229934AbjCLQPc (ORCPT ); Sun, 12 Mar 2023 12:15:32 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44258366A0 for ; Sun, 12 Mar 2023 09:15:30 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbOLz-0007pw-4T; Sun, 12 Mar 2023 17:15:23 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pbOLy-003f2c-Ed; Sun, 12 Mar 2023 17:15:22 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pbOLx-004K8w-C4; Sun, 12 Mar 2023 17:15:21 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Sudeep Holla , Michael Turquette , Stephen Boyd Cc: Cristian Marussi , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 15/30] clk: scpi: Convert to platform remove callback returning void Date: Sun, 12 Mar 2023 17:14:57 +0100 Message-Id: <20230312161512.2715500-16-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1794; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=5MjW7VOTnBQN8nKLLIpeOEnNz12SyhOVFAuyxtqwJh0=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkDfpSJ8kZ9YYoZicMME15YLeYOAXzTzoRJd/w9 RbWIYoa46uJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZA36UgAKCRDB/BR4rcrs CcajCACIKTV9216hk4TxgtFgcKybJIbdXSl3GMe5VLuQ7axtMl+Klu0Q7fo9MvpT91uFkZmg3U6 W5WidGSi0mjFJefT8EkBXtargZJR+FcJmGPTPAa9G9Iis5Fu0NRROc4ha52DBddGxSCdsCRuWn3 kaYrg6Aw08UOEAONWa2EmGyxDTfwsm7Z/qpJP56CQxwD/VppH3q+uGUbe1O7iOoOyuxlw52FvNN YupboOkvhmLL/yJBsmNOwH9yEdsSr7zPuaZVa9HhQ0GB6pt0caFZnxGujA6lMwgXmJZmziLOTdm r/S5yxYXPu/qW92WjVhjlXCttm+xnyxyUxJQ9ChzaueomuSW X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760179349332776719?= X-GMAIL-MSGID: =?utf-8?q?1760179349332776719?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Sudeep Holla --- drivers/clk/clk-scpi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk-scpi.c b/drivers/clk/clk-scpi.c index a39af7616b13..3fb4003453ee 100644 --- a/drivers/clk/clk-scpi.c +++ b/drivers/clk/clk-scpi.c @@ -246,7 +246,7 @@ static int scpi_clk_add(struct device *dev, struct device_node *np, return of_clk_add_hw_provider(np, scpi_of_clk_src_get, clk_data); } -static int scpi_clocks_remove(struct platform_device *pdev) +static void scpi_clocks_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct device_node *child, *np = dev->of_node; @@ -258,7 +258,6 @@ static int scpi_clocks_remove(struct platform_device *pdev) for_each_available_child_of_node(np, child) of_clk_del_provider(np); - return 0; } static int scpi_clocks_probe(struct platform_device *pdev) @@ -305,7 +304,7 @@ static struct platform_driver scpi_clocks_driver = { .of_match_table = scpi_clocks_ids, }, .probe = scpi_clocks_probe, - .remove = scpi_clocks_remove, + .remove_new = scpi_clocks_remove, }; module_platform_driver(scpi_clocks_driver);