From patchwork Sun Mar 12 15:34:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 68372 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp782226wrd; Sun, 12 Mar 2023 09:15:59 -0700 (PDT) X-Google-Smtp-Source: AK7set99FG3RICeQj20e0H6CYU0zVSJcKPa4H8w0QvAaArlfGl7qfQSffy7dasJYXWjdjNNRD5Rp X-Received: by 2002:a17:90a:b704:b0:23b:3699:b8a9 with SMTP id l4-20020a17090ab70400b0023b3699b8a9mr4736082pjr.17.1678637758979; Sun, 12 Mar 2023 09:15:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678637758; cv=none; d=google.com; s=arc-20160816; b=Peo5r03rStMiHBN5PHXu2f3ihq6YM5TTKZANMUg1nXaVOMwKhekEQZmNPhYIoHOAVH 79QKp3fOqSfPbDq1iENDY6t6Yj9SbhUABaIE7L31APzMnPIuccrIfdfnq38gmd58nQcl gziEfskYJ34tuY1NJgjFiiqEnf/gf7fRlQiFUOYisEph3KuBeIO3/F8O6uAHic3KfMdF wVK7wH1W1mFjU1Dud5XoV0iS0DkRO5/cYKldcyMzBs69vb2SjsUcitWBYsCcZdc+0yPC FuIKPjyBUGlvweM7Q62waw7zsSbDBEO0HlUA8fjyjU4diofHK4ioBgjGCd4jcowpdUYI F5FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Jo2NqS2zRnOmFXuAfigU28D6znKyOMxuJ/PtqM8xL/o=; b=MAjKak900dXtN5dtC7pLFVfc29hFlRvwEEvjHShYghZTX1r++ItC2WEUb2bVROC25a /x9UlwZSO31vo9Py6FK73YTgB5Dddsip6P1edsx1T1Ma15ucUN1AKOA5YZDp5wlRAbJ1 zbK5rLj/giF9LXXwzazig2qxjZXOd6gIbkiFBvx+UP+vpR2r8yugZwY/AyCHLInW5II9 bnk7e1+/v5KFEvAehLd8PCVo6OU7qnjzR7npx68J78IqfZQdgUmkLOLbMfcwRv8RSizr dPF1SlEvcI7OU6xwObp6fMupeQJfgy+b8e7O9XvXnR7zNd0VVEQf3GCQtLiW/Tinba+L UrUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mWDprQhs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b7-20020a631b07000000b004fb47ad7ff5si4448589pgb.200.2023.03.12.09.15.44; Sun, 12 Mar 2023 09:15:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mWDprQhs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229942AbjCLPei (ORCPT + 99 others); Sun, 12 Mar 2023 11:34:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229712AbjCLPef (ORCPT ); Sun, 12 Mar 2023 11:34:35 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74E6C41B5F for ; Sun, 12 Mar 2023 08:34:34 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id er25so11128059edb.5 for ; Sun, 12 Mar 2023 08:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678635273; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jo2NqS2zRnOmFXuAfigU28D6znKyOMxuJ/PtqM8xL/o=; b=mWDprQhsa9VdEHPAceKFNkoijx6mTG37ZiUg/JljzXlRXxx4JM8rWKVoJ4HbgFbtjv rxn5Ck7IOVo7IXIZg83E+GmK+SMgTlNWePAPn4ErAYdu9aLt/37x0jhal6wSFRFf35Ef 2EkuVZpEjy7A2YNK5HGbdB3fjrbf5Nme5LjFGG63ie8Qx0aRgCtaqZCoTwB3VPygWR3i rww28efnI0bNJSVuRTObqeQ5p0q1JKGfJM7agGrgndPJrqb8T99UM7louhioa5K3He19 jzbdSq8EvDyK6Td71EAjuVBsHNXzVNNYDfQf4tIjOgfD8GgSgsjtQLM4/Jci6BHGepXI pkWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678635273; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jo2NqS2zRnOmFXuAfigU28D6znKyOMxuJ/PtqM8xL/o=; b=DYXaHU3JpCdokol1hL3H9jX1HVDydjJmi8Wlm8RPM7t9pcZ40e9LW9HafRKqSAkMrp e8+6yFyroeZ3EJMcWjrmdKs8xwUy7qudu3pM40QagQYRGArxOutBnariAlFgD2GLON4D 8arbfh4s7hMMHkuEemYZD5pUKzuMdmgyIMron1cSldC2gQhBroZl3dQKtnc8/7F6ZjHw k7WslfzR4XUAF2rJPJrfI+G7utNF4C9GcPmNOrvMy4xzbcmvDVxIX2ddfuDrONFPJyep J1cYQjm/jBu95N0yxnEto8qM9NmpdNEaqkruc6paKJDY+rzFKezp2rvxap5sK4MfkbOn 49tw== X-Gm-Message-State: AO0yUKV4A2kQIhNkGTkhZgxyQV1U5sD0IMvPW2o9T4XbfiHPFy9eI7dE ci882Q0KmrZLiMz7IcxPO8U2Sw== X-Received: by 2002:a17:906:99d4:b0:8ed:5aac:6973 with SMTP id s20-20020a17090699d400b008ed5aac6973mr31069426ejn.35.1678635273004; Sun, 12 Mar 2023 08:34:33 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:d9f6:3e61:beeb:295a]) by smtp.gmail.com with ESMTPSA id z2-20020a170906668200b008e0bb004976sm2312723ejo.134.2023.03.12.08.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Mar 2023 08:34:32 -0700 (PDT) From: Krzysztof Kozlowski To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Robert Eshleman , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 2/3] iio: light: max44009: add missing OF device matching Date: Sun, 12 Mar 2023 16:34:28 +0100 Message-Id: <20230312153429.371702-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230312153429.371702-1-krzysztof.kozlowski@linaro.org> References: <20230312153429.371702-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760179266434473024?= X-GMAIL-MSGID: =?utf-8?q?1760179266434473024?= The driver currently matches only via i2c_device_id, but also has of_device_id table: drivers/iio/light/max44009.c:545:34: error: ‘max44009_of_match’ defined but not used [-Werror=unused-const-variable=] Fixes: 6aef699a7d7e ("iio: light: add driver for MAX44009") Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Drop __maybe_unused/of_match_ptr --- drivers/iio/light/max44009.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/iio/light/max44009.c b/drivers/iio/light/max44009.c index 3dadace09fe2..176dcad6e8e8 100644 --- a/drivers/iio/light/max44009.c +++ b/drivers/iio/light/max44009.c @@ -527,6 +527,12 @@ static int max44009_probe(struct i2c_client *client) return devm_iio_device_register(&client->dev, indio_dev); } +static const struct of_device_id max44009_of_match[] = { + { .compatible = "maxim,max44009" }, + { } +}; +MODULE_DEVICE_TABLE(of, max44009_of_match); + static const struct i2c_device_id max44009_id[] = { { "max44009", 0 }, { } @@ -536,18 +542,13 @@ MODULE_DEVICE_TABLE(i2c, max44009_id); static struct i2c_driver max44009_driver = { .driver = { .name = MAX44009_DRV_NAME, + .of_match_table = max44009_of_match, }, .probe_new = max44009_probe, .id_table = max44009_id, }; module_i2c_driver(max44009_driver); -static const struct of_device_id max44009_of_match[] = { - { .compatible = "maxim,max44009" }, - { } -}; -MODULE_DEVICE_TABLE(of, max44009_of_match); - MODULE_AUTHOR("Robert Eshleman "); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("MAX44009 ambient light sensor driver");