From patchwork Sun Mar 12 15:15:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 68365 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp766291wrd; Sun, 12 Mar 2023 08:37:07 -0700 (PDT) X-Google-Smtp-Source: AK7set9XKiSCb2Z/V05hozTdLCgotu9hev4kNZKKUZ4+XpsbxrakxADzDQrbNuX27WDYv2/kibKJ X-Received: by 2002:a17:90b:4396:b0:23c:ffd2:6502 with SMTP id in22-20020a17090b439600b0023cffd26502mr1096953pjb.12.1678635427067; Sun, 12 Mar 2023 08:37:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678635427; cv=none; d=google.com; s=arc-20160816; b=UHEFBf/T/W3FlMuqYjgpgK7/dcsQeTsXXl657hC5msRLP+SZQqbvVa+v7ctkElX3E9 7xhUwddAPJKmqMi9ILK3BWYwEBdYML9t1S3dgVW8AkhggIL90ckZLa1aU5yXoFDE/qL0 u/UX75IbLY0172zlJIDslaLCMg+9DcQIiU+7PyGofITzgNEaWqmjnzeVLGBGwGkLCEWI ztRr2fHS0xHThHzcf6+g1rV8R6xKmm1k47JMHAKnotxnI41Ku3O5/iPgyh0IS/fJAGbx 6zEE66+QI4DAjDpDkDeBR7AqwhKHgcEGGyjY1/QB9NIIugWStfHIL3L6GtL4brk4WIWP qzNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=R6PigHiiBwTtJAt6wF4POpu3Up9Ey4iqAzf3m+gNp9g=; b=kSTGqusDaKAUX8PrcseXlfSMV2/gG2y7b62QJsLk7+yrdzSS3H6ETDEUJxDczJHqMF xPfr+TR1jfqffbiHhNwqWtrlqLn+jFtsx69kOf5nJYc/G66MT+Y0retLPIKYbEAPUTyO KYeIsfloVx57wqjbOLO5SBhEdowHF6tSDC0oWJTuhmAG48XHcSgnjkfLzdYErZsSScPu jx5LnNy8/YbofnjKL8V5JkvGnZ+rc4aS01H1AEDpyMSgK0YHJRJM0wo/Zckp8oS0YO/f zeTCMbLl6Av0n0VylO1rEd4BQN/zJKGumDDMYKN/4LYoJ1o5Wqvo1faO83E0EQE7NjVq ChSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=GRvL6zUa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lw7-20020a17090b180700b00205da45d8a5si4636581pjb.124.2023.03.12.08.36.51; Sun, 12 Mar 2023 08:37:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=GRvL6zUa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229845AbjCLPQ2 (ORCPT + 99 others); Sun, 12 Mar 2023 11:16:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbjCLPQ0 (ORCPT ); Sun, 12 Mar 2023 11:16:26 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.214]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D2C0634F4E for ; Sun, 12 Mar 2023 08:16:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=R6Pig HiiBwTtJAt6wF4POpu3Up9Ey4iqAzf3m+gNp9g=; b=GRvL6zUadxpYe4ABzcLeA dyb72nSvP0czUxWvAQhGAuGO5+Si6fNgWiG0Bjk98HWewt+Nc6B0ukHXybfnYquQ cbi3HzJkc9OQf5kD1qAfD04z3E9eyrp9xfgy4wW3cDdZkbXJqpLGyXighUDVbKLS RwHQIDnHymA6ltcVqd5nWk= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g4-0 (Coremail) with SMTP id _____wBHZlqq7A1kBNdiDA--.58665S2; Sun, 12 Mar 2023 23:15:54 +0800 (CST) From: Zheng Wang To: arnd@arndb.de Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH] misc: ti-st: st_kim: Fix use after free bug in kim_remove due to race condition Date: Sun, 12 Mar 2023 23:15:52 +0800 Message-Id: <20230312151552.1947700-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wBHZlqq7A1kBNdiDA--.58665S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Ar1kXFykXrWxKF4fJF1DWrg_yoW8Wr1Dpa yjgrW29rW8KFWIqw4DJr4Uua42kw47t34YgF47Cw43Z34YkrWYgFnFvryIvFZayFZ5tr4F yr18ZrZxWa9rZ3JanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zikwIPUUUUU= X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiQhAwU1aEEoaXHgAAs+ X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_VALIDITY_RPBL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760176821556007882?= X-GMAIL-MSGID: =?utf-8?q?1760176821556007882?= In kim_probe, it called st_core_init and bound &st_gdata->work_write_wakeup with work_fn_write_wakeup. When it calls st_tty_wakeup, it will finally call schedule_work to start the work. When we call kim_remove to remove the driver, there may be a sequence as follows: Fix it by finishing the work before cleanup in kim_remove CPU0 CPU1 |work_fn_write_wakeup kim_remove | st_core_exit | kfree(st_gdata)| |st_tx_wakeup |//use st_gdata Fixes: b05b7c7cc032 ("ti-st: use worker instead of calling st_int_write in wake up") Signed-off-by: Zheng Wang --- drivers/misc/ti-st/st_kim.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c index f2f6cab97c08..160258a78c7b 100644 --- a/drivers/misc/ti-st/st_kim.c +++ b/drivers/misc/ti-st/st_kim.c @@ -785,9 +785,12 @@ static int kim_remove(struct platform_device *pdev) /* free the GPIOs requested */ struct ti_st_plat_data *pdata = pdev->dev.platform_data; struct kim_data_s *kim_gdata; + struct st_data_s *st_gdata = kim_gdata->core_data; kim_gdata = platform_get_drvdata(pdev); + cancel_work_sync(&st_gdata->work_write_wakeup); + /* * Free the Bluetooth/FM/GPIO * nShutdown gpio from the system @@ -800,7 +803,7 @@ static int kim_remove(struct platform_device *pdev) pr_info("sysfs entries removed"); kim_gdata->kim_pdev = NULL; - st_core_exit(kim_gdata->core_data); + st_core_exit(st_gdata); kfree(kim_gdata); kim_gdata = NULL;