From patchwork Sun Mar 12 14:00:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 68350 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp739263wrd; Sun, 12 Mar 2023 07:27:13 -0700 (PDT) X-Google-Smtp-Source: AK7set8Aq69ylBGLqodBhZDaSwO97GMwwDmWbum5f0g3Tvb8WWf1UDFqN4HUI1B3kFtXb7TL5Wfm X-Received: by 2002:a05:6a20:1d59:b0:cc:d891:b2ad with SMTP id cs25-20020a056a201d5900b000ccd891b2admr25887299pzb.20.1678631233537; Sun, 12 Mar 2023 07:27:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678631233; cv=none; d=google.com; s=arc-20160816; b=GYHRkDDdTG8nKFd0Tlttw+sjUvTQ2AfHuS/Pnm7JEIVP0vH1tTMnEI6D7foiE4aMwc InuT+NF3PNhBwdlYWhKfkpFRvjJE0o3IkkRjZsCLyEKOwhm8uJfxdlWFnAODbheusTo+ vB5cVDYmuwzgnqRBKyJomGJJMOr9mmN5i7tPUjUycQ+k/9JNueMk+hhgG3bt5TXuVihQ aNFGW8kjj1Nqp7RH/DRFoXQlSPsSp+R/p+U9Dtc+ooQ617rywyvIlbAOURrurqOnvnW5 3V7E0tmzq/sNuWG9gjfOttg2SU51nfek92BLPUXRFhzC4F3avwDa314iVprh40CIl4Lj vXNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=GU4BtiF/mURnT05J+b2ZAAYVXtRHoTughkALlexgzGg=; b=JV1RU8qMvFgsReJMfDVlsfzxRwx9mcQUB9cTJaCwFWPnV90ql6b/Z2jGrOq/Ym9UA7 eoe7d2oCfYpEkaUf1V1G9TP/fdOBBOxKCeyCEhXWfChRwf8S40SV0hd+ZJtNQz1748tA c9zzG63JNMUw5ONu7wwP4yRuAa5eDM/ReBhFQrb3bpwkd+2wZlZqUvaYgbZWgsXBPLuI eszQKGTe3fJ5WRyO9DlTBN5nMKXIs95g0CjDSwI2/aaYmgjy2VgcoTeCIrbrgL1ku5/+ 0Nxihcysr71P8nfByR/pUCw6xR2457947Dbn3CT9Nk4PiJoNe1Nr6oLygEmsz57EN7w7 GxUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b="qJoU/4vI"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p8-20020a654908000000b004fab1ea0112si4343557pgs.528.2023.03.12.07.26.58; Sun, 12 Mar 2023 07:27:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b="qJoU/4vI"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229914AbjCLOAa (ORCPT + 99 others); Sun, 12 Mar 2023 10:00:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229509AbjCLOA3 (ORCPT ); Sun, 12 Mar 2023 10:00:29 -0400 Received: from m12.mail.163.com (m12.mail.163.com [123.126.96.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CDE6836442; Sun, 12 Mar 2023 07:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=GU4Bt iF/mURnT05J+b2ZAAYVXtRHoTughkALlexgzGg=; b=qJoU/4vI/YVTuX1+AsU3r GVVp1mtVWe6qKliIRQoSM0Por/g/ix+MJValgPRVgCa6Kh7lzJydz6Z5XnCdpZis FBwqKyYBOJcw0jW0RmaZhXfo73ZAhWX6XnbcYnxRv2ZI39rHur4wMQGTXA0u5+S/ W6pTwBBikv5NauKTmc5fyo= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by smtp16 (Coremail) with SMTP id MNxpCgBXMzIW2w1k8rBRHQ--.17887S2; Sun, 12 Mar 2023 22:00:54 +0800 (CST) From: Zheng Wang To: mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH] media: dm1105: Fix use after free bug in dm1105_remove due to race condition Date: Sun, 12 Mar 2023 22:00:12 +0800 Message-Id: <20230312140012.1816214-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: MNxpCgBXMzIW2w1k8rBRHQ--.17887S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7GrWDtr43Cw48Aw1kuryxAFb_yoW8Jry5pr ZxCFyYkFWfGry8Jr1DGw17XFy5JrZxJFy3WrW7Ww43Xr15ZFWDtayqv3WUAry3AFZ7ZrWa qa1rXr13W3yUAF7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0ziJUU8UUUUU= X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiXAgvU1Xl55FePwABsO X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_PDS_OTHER_BAD_TLD autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760172424072697792?= X-GMAIL-MSGID: =?utf-8?q?1760172424072697792?= In dm1105_probe, it called dm1105_ir_init and bound &dm1105->ir.work with dm1105_emit_key. When it handles IRQ request with dm1105_irq, it may call schedule_work to start the work. When we call dm1105_remove to remove the driver, there may be a sequence as follows: Fix it by finishing the work before cleanup in dm1105_remove CPU0 CPU1 |dm1105_emit_key dm1105_remove | dm1105_ir_exit | rc_unregister_device | rc_free_device | rc_dev_release | kfree(dev); | | | rc_keydown | //use Fixes: 34d2f9bf189c ("V4L/DVB: dm1105: use dm1105_dev & dev instead of dm1105dvb") Signed-off-by: Zheng Wang --- drivers/media/pci/dm1105/dm1105.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/dm1105/dm1105.c b/drivers/media/pci/dm1105/dm1105.c index 4ac645a56c14..9e9c7c071acc 100644 --- a/drivers/media/pci/dm1105/dm1105.c +++ b/drivers/media/pci/dm1105/dm1105.c @@ -1176,6 +1176,7 @@ static void dm1105_remove(struct pci_dev *pdev) struct dvb_demux *dvbdemux = &dev->demux; struct dmx_demux *dmx = &dvbdemux->dmx; + cancel_work_sync(&dev->ir.work); dm1105_ir_exit(dev); dmx->close(dmx); dvb_net_release(&dev->dvbnet);