Message ID | 20230312131318.351173-26-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp716120wrd; Sun, 12 Mar 2023 06:27:27 -0700 (PDT) X-Google-Smtp-Source: AK7set9yg35kVXBHY6IKxQ/iphXmoRlPibca9P2AxkL8GhdP8YtH4ywxLSIEqy8w5zKj/eT3+CLM X-Received: by 2002:a05:6a20:1bdd:b0:cc:a0fd:67bd with SMTP id cv29-20020a056a201bdd00b000cca0fd67bdmr30460169pzb.14.1678627647618; Sun, 12 Mar 2023 06:27:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678627647; cv=none; d=google.com; s=arc-20160816; b=h/gSGgqvdUE7j5Zd9dAsm/7xTwOqliMaUkV3Tgs0gX59arHkO4kT3u/KxpDfXcYnV9 fCCmuiTV1KHeOeV3xrZyJIlHRPffAdfQ8D6aeeMbae8sqqMILhY91jPCbeeJBh/YeKHs Zf/+JjnX4oYa4JUHNgB87LrSKKaxVncYVAFzTO8ovW0Ezam4lNwaAuclJtK5V431kyau Ci2QL/PJAU/+hj+WUlXuDAsE+U/Ifam0LQJwx+10172foqKNVrTKm2VdvPq9fTIaJlvB xWhBpJkBy5UL7s/XL2u1DOOBddqSYiSWMcki/lORpjYAPopqN/5qEX52uIJzsKR0d6Yt CrWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=k/JwivpSWSUp7SGgg579h7vvWa7gXoSaXDjfT9QxQC0=; b=s6eWtgx5IuNEJ+Jr6jDkJf5sNJI6+RrzNRVvEJP5zisis1dobfA/4TF8wnbDH5FYZB MEHWWWg2GwkAJg2sFvmOy7zlA9bKmi2fDnlx3hxcuaosd3jvtAE/u2fd7Z/TdoWsLc2y zrH9Tz+5N9iO78n5jzDqqZATjKlF2TS0OsF2TDM3GAsaovNlUf90t2yjqxZlcDZLxSWf 8jbDyYeGHYulJF3Ld8rmNTq8MgFRgElqINmxIextmb7LbYqw2j+7e5RPqHZXJ7CKdtyZ UN76SBjwdHCTk7ymB8JeQbzF2KURapM4jS6Fxb4ReiJ+NOba5uF3i2Z0Tiwbt3fUhfBa nVkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CXU5Sft4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s138-20020a632c90000000b0050951c7f3e7si2360943pgs.192.2023.03.12.06.27.12; Sun, 12 Mar 2023 06:27:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CXU5Sft4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230401AbjCLNQY (ORCPT <rfc822;realc9580@gmail.com> + 99 others); Sun, 12 Mar 2023 09:16:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230192AbjCLNPo (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 12 Mar 2023 09:15:44 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D30E279B7 for <linux-kernel@vger.kernel.org>; Sun, 12 Mar 2023 06:14:36 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id r15so11317805edq.11 for <linux-kernel@vger.kernel.org>; Sun, 12 Mar 2023 06:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678626854; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k/JwivpSWSUp7SGgg579h7vvWa7gXoSaXDjfT9QxQC0=; b=CXU5Sft4Qo94NqQz3mPSkb9P2d9WUUzBRab27MBYfCDp4zAJtkVa4U2gt8ruuAK2fx bYmi5lZFbKvFh7jAiwga20LHYuPZuLJ6WwFDw37JcecknQr1EZ6tbXpKsSHrRFM6dH42 G9jmlFKCdF2j0PJTIZv91TvmWvYmxJetJ5eGnZpcumSgmaLtlgm4+ONduSKLc+F6aFmS 2wbtsxeM7XjreClsKD102rjyRJhh1sgoZRixqozGJ4sff/5C87OVnI8gkQkfEaJBXzHN PLG7p5dhHufbK/Jk1Kg16Rh8G+p1NrvtMOVierX90bJ5vpXVZA5+RMdYqOUEGm66DbRf t+sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678626854; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k/JwivpSWSUp7SGgg579h7vvWa7gXoSaXDjfT9QxQC0=; b=6LZDWiWesH3lSeb8Tur4EcVhkezRYZ/+cWH2N1PjZGJV1CUf/MKtppiVHNHjBYoqri Gzf8K0ys0Og5T3XKtxSefD8BCTcT1uYzsnjvkDdca+RUBqNfQ9cfacEbpU0aAAqR8vOa UKliAZduD1ILOS5q+Q6n5PkJSUYkT/hVOPqLzZL9eLPO1q3oe99BYlSBHZ8SIcWLKJjz FbeMiNWsAhvHvAwyF8XDPkvvV8DMBw5tx0BZyZnVcZf/GEvN6JIwshewCQyhJJXivFSI +/OLYDorpY30ML5CpAWxGB7pYk7veoPWpN6pHT71twmrPko4/zglbK7P5NYcyvA3hQY8 Lmzw== X-Gm-Message-State: AO0yUKXPmhyFrdHPxA6zcVlCgZv8odaZCcac/526nHhkFraVY9d+aKYp YvTxRX3Gjy570QnOJIEXwv/8hg== X-Received: by 2002:a17:906:5ca:b0:8f6:ad32:cd51 with SMTP id t10-20020a17090605ca00b008f6ad32cd51mr35131755ejt.62.1678626854759; Sun, 12 Mar 2023 06:14:14 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:d9f6:3e61:beeb:295a]) by smtp.gmail.com with ESMTPSA id r19-20020a1709067fd300b008eddbd46d7esm2213279ejs.31.2023.03.12.06.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Mar 2023 06:14:14 -0700 (PDT) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Joe Tessler <jrt@google.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Mauro Carvalho Chehab <mchehab@kernel.org>, Neil Armstrong <neil.armstrong@linaro.org>, Kevin Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Manivannan Sadhasivam <mani@kernel.org>, Michael Tretter <m.tretter@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Jacopo Mondi <jacopo+renesas@jmondi.org>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, =?utf-8?q?Nik?= =?utf-8?q?las_S=C3=B6derlund?= <niklas.soderlund+renesas@ragnatech.se>, Rui Miguel Silva <rmfrfs@gmail.com>, Wenyou Yang <wenyou.yang@microchip.com>, Bin Liu <bin.liu@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Minghsiu Tsai <minghsiu.tsai@mediatek.com>, Houlong Wei <houlong.wei@mediatek.com>, Andrew-CT Chen <andrew-ct.chen@mediatek.com>, Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>, Jacek Anaszewski <jacek.anaszewski@gmail.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Patrice Chotard <patrice.chotard@foss.st.com>, Yong Deng <yong.deng@magewell.com>, Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, "Lad, Prabhakar" <prabhakar.csengg@gmail.com>, Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>, Philipp Zabel <p.zabel@pengutronix.de>, Sean Young <sean@mess.org>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 26/28] media: i2c: imx290: drop of_match_ptr for ID table Date: Sun, 12 Mar 2023 14:13:16 +0100 Message-Id: <20230312131318.351173-26-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230312131318.351173-1-krzysztof.kozlowski@linaro.org> References: <20230312131318.351173-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760168664456477242?= X-GMAIL-MSGID: =?utf-8?q?1760168664456477242?= |
Series |
[01/28] media: cec: ch7322: drop of_match_ptr for ID table
|
|
Commit Message
Krzysztof Kozlowski
March 12, 2023, 1:13 p.m. UTC
The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it might not be relevant here). This
also fixes !CONFIG_OF error:
drivers/media/i2c/imx290.c:1354:34: error: ‘imx290_of_match’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/media/i2c/imx290.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Krzysztof, Thank you for the patch. On Sun, Mar 12, 2023 at 02:13:16PM +0100, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). This > also fixes !CONFIG_OF error: > > drivers/media/i2c/imx290.c:1354:34: error: ‘imx290_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/i2c/imx290.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c > index 49d6c8bdec41..3c9470fbfd53 100644 > --- a/drivers/media/i2c/imx290.c > +++ b/drivers/media/i2c/imx290.c > @@ -1363,7 +1363,7 @@ static struct i2c_driver imx290_i2c_driver = { > .driver = { > .name = "imx290", > .pm = &imx290_pm_ops, > - .of_match_table = of_match_ptr(imx290_of_match), > + .of_match_table = imx290_of_match, > }, > }; >
diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c index 49d6c8bdec41..3c9470fbfd53 100644 --- a/drivers/media/i2c/imx290.c +++ b/drivers/media/i2c/imx290.c @@ -1363,7 +1363,7 @@ static struct i2c_driver imx290_i2c_driver = { .driver = { .name = "imx290", .pm = &imx290_pm_ops, - .of_match_table = of_match_ptr(imx290_of_match), + .of_match_table = imx290_of_match, }, };