Message ID | 20230312131318.351173-25-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp718789wrd; Sun, 12 Mar 2023 06:34:14 -0700 (PDT) X-Google-Smtp-Source: AK7set/xohaNV5iWLyzA4kaz0YQSZkDw/q/zONtb/7Tm68soYm/a1bUnHayi30ozJOrMlZhBZn7U X-Received: by 2002:a05:6a20:6a1b:b0:cd:2d12:8176 with SMTP id p27-20020a056a206a1b00b000cd2d128176mr31626295pzk.19.1678628054317; Sun, 12 Mar 2023 06:34:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678628053; cv=none; d=google.com; s=arc-20160816; b=ME7OhGKxCWtLU+Av4fWQ4de2Aob4RNtMyduMZ+F5vMoeIm6xiZn2CDWtyox7yi4BqJ pa6ZqBs6MOsAdNpB5MsGOYoiNlckET2ki/9MksnWGPlpSY6Fz7lsVSMBotTVzngqlxUu 8/G6O2YApuaKJgyuD28FF/W6hxQ58bWDudq8PhFZ1z1NGIxKIg6cG4i0T/1ZszzaQlVP pC9QoTH3Xm8AQehxYoEhn94dQyfLmUOd8GdFQueIG7Cl3XRKJHftgTWb6dh9GT34DNpz +86v1QKJ4bSadFPAp3r4zmYhVCF1HfGp24vIrlMrcug4AHPWmUX7z8kvIGT02M1C6TkK Qbvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=m+WYHU/SqewTwrfZuCdGJulxf+5ECuJ2svWptTLYXIE=; b=ek0yCvCY5Hj22qRjZKqWImeytPnizIJjM1hi4ZLbp0PF3H4D575SZX/w+UZeAO0Yf6 zgsFnV6LS0iy1nIanDe4bVE/OPeVVLeV9Sf5pujakR0gPnCuj66ulrUrok0JeD6CYGfv 2LO1gVEflL1wV7PryC+rlwK0rWqWnKu5XH/VJ8T0qve74Lu3QF9xpdcsoJ2GMh3WHaZk tkB5cTuAq7w0aJOeSuclHjAQ03m5RN42Aol86auqHPHS2m6Oyo7RrSgTuow0/bnKmPOg s+yf8PbcHtl0dvRCNpM/qacpu+2xbuI2hACZfLwxUrZ57aB7z0Ts6SHBQ9Bv/BplkAPb tvUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qa63Qo9f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v13-20020a63464d000000b005007daa08b3si3355470pgk.278.2023.03.12.06.33.39; Sun, 12 Mar 2023 06:34:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qa63Qo9f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230219AbjCLNPx (ORCPT <rfc822;realc9580@gmail.com> + 99 others); Sun, 12 Mar 2023 09:15:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230085AbjCLNO6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 12 Mar 2023 09:14:58 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59B8B497D1 for <linux-kernel@vger.kernel.org>; Sun, 12 Mar 2023 06:14:13 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id s11so38495558edy.8 for <linux-kernel@vger.kernel.org>; Sun, 12 Mar 2023 06:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678626853; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m+WYHU/SqewTwrfZuCdGJulxf+5ECuJ2svWptTLYXIE=; b=qa63Qo9fSC+Ap6jq8NDE2/EKVxm+oVWK3PFoPnwE4yBlATkz7TLk5YW9j1Aus6jlO4 6yc4oApxJj/EDKros+pMJB38lQNWN1egudsvqOCBUzYW64WGkXUr4UF5uvMAhzPeK5rn MFPFUDZQfSOayCcp9U5gDPkJDFkGju6UWmsy9KCRljegOCC7go6mgN7GfCuyf/VdVbFD RI2fxqf3sl093J1Dwc5Jpz0d+PVkRtuxgBckuhSs48nPfSE/o9nrnsQU4Mp4x4rkVe1u GMHKWSQnkdmVR/BpH9WvboP+5QMDYLm5XUHxVqEXRB/RgiCPMXI3gOvVA9FVBVyWZXAk RPlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678626853; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m+WYHU/SqewTwrfZuCdGJulxf+5ECuJ2svWptTLYXIE=; b=U/q8A/MYLvNM/FCbmbhQkhEl52gunvwpUhir5I5srpffvOyW7q3qeYIbEXvQRxoo8z uAxzVHjuXkzr7MCKUTPt2/DssFBddz5xUiSiIuIR4+kHQmUZhGb1kuPWqjR/hbL+vhNo f/tKWo23yLyuyP/f22HsNasY+qvHUZ2Jebpl+5Z7csVSJQUO1Iy3cpTroWjjs5X1qlA5 YeEZKDgXaLEPM6AZLtuj638jZg0qxm7LzVzesuxyaAM87ePEocmmVO82wAFLbB4GYeHu xupObjsCd/aSSQ4htPNk4BOrc+1r3tfCv5elBIemkqXTQjOrhG5LeWng89l4+7PzkE1v YSzg== X-Gm-Message-State: AO0yUKUskHdLyQfqPWywwk+FGxnQCaTmtHlPig9XfYkfCgI0MSC+7p/Q bjPsjEy7augb2Q48ZJzKKaoH6g== X-Received: by 2002:a17:907:72c7:b0:889:d156:616d with SMTP id du7-20020a17090772c700b00889d156616dmr37155221ejc.27.1678626852856; Sun, 12 Mar 2023 06:14:12 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:d9f6:3e61:beeb:295a]) by smtp.gmail.com with ESMTPSA id r19-20020a1709067fd300b008eddbd46d7esm2213279ejs.31.2023.03.12.06.14.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Mar 2023 06:14:12 -0700 (PDT) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Joe Tessler <jrt@google.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Mauro Carvalho Chehab <mchehab@kernel.org>, Neil Armstrong <neil.armstrong@linaro.org>, Kevin Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Manivannan Sadhasivam <mani@kernel.org>, Michael Tretter <m.tretter@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Jacopo Mondi <jacopo+renesas@jmondi.org>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, =?utf-8?q?Nik?= =?utf-8?q?las_S=C3=B6derlund?= <niklas.soderlund+renesas@ragnatech.se>, Rui Miguel Silva <rmfrfs@gmail.com>, Wenyou Yang <wenyou.yang@microchip.com>, Bin Liu <bin.liu@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Minghsiu Tsai <minghsiu.tsai@mediatek.com>, Houlong Wei <houlong.wei@mediatek.com>, Andrew-CT Chen <andrew-ct.chen@mediatek.com>, Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>, Jacek Anaszewski <jacek.anaszewski@gmail.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Patrice Chotard <patrice.chotard@foss.st.com>, Yong Deng <yong.deng@magewell.com>, Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, "Lad, Prabhakar" <prabhakar.csengg@gmail.com>, Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>, Philipp Zabel <p.zabel@pengutronix.de>, Sean Young <sean@mess.org>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 25/28] media: i2c: ov7740: drop of_match_ptr for ID table Date: Sun, 12 Mar 2023 14:13:15 +0100 Message-Id: <20230312131318.351173-25-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230312131318.351173-1-krzysztof.kozlowski@linaro.org> References: <20230312131318.351173-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760169088820154031?= X-GMAIL-MSGID: =?utf-8?q?1760169088820154031?= |
Series |
[01/28] media: cec: ch7322: drop of_match_ptr for ID table
|
|
Commit Message
Krzysztof Kozlowski
March 12, 2023, 1:13 p.m. UTC
The driver will match mostly by DT table (even thought there is regular
ID table) so there is little benefit in of_match_ptr (this also allows
ACPI matching via PRP0001, even though it might not be relevant here).
This also fixes !CONFIG_OF error:
drivers/media/i2c/ov7740.c:1203:34: error: ‘ov7740_of_match’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/media/i2c/ov7740.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Krzysztof, Thank you for the patch. On Sun, Mar 12, 2023 at 02:13:15PM +0100, Krzysztof Kozlowski wrote: > The driver will match mostly by DT table (even thought there is regular > ID table) so there is little benefit in of_match_ptr (this also allows > ACPI matching via PRP0001, even though it might not be relevant here). > This also fixes !CONFIG_OF error: > > drivers/media/i2c/ov7740.c:1203:34: error: ‘ov7740_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/i2c/ov7740.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/ov7740.c b/drivers/media/i2c/ov7740.c > index c9fd9b0bc54a..42121916d25f 100644 > --- a/drivers/media/i2c/ov7740.c > +++ b/drivers/media/i2c/ov7740.c > @@ -1210,7 +1210,7 @@ static struct i2c_driver ov7740_i2c_driver = { > .driver = { > .name = "ov7740", > .pm = &ov7740_pm_ops, > - .of_match_table = of_match_ptr(ov7740_of_match), > + .of_match_table = ov7740_of_match, > }, > .probe_new = ov7740_probe, > .remove = ov7740_remove,
diff --git a/drivers/media/i2c/ov7740.c b/drivers/media/i2c/ov7740.c index c9fd9b0bc54a..42121916d25f 100644 --- a/drivers/media/i2c/ov7740.c +++ b/drivers/media/i2c/ov7740.c @@ -1210,7 +1210,7 @@ static struct i2c_driver ov7740_i2c_driver = { .driver = { .name = "ov7740", .pm = &ov7740_pm_ops, - .of_match_table = of_match_ptr(ov7740_of_match), + .of_match_table = ov7740_of_match, }, .probe_new = ov7740_probe, .remove = ov7740_remove,