From patchwork Sat Mar 11 17:46:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 68169 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp396091wrd; Sat, 11 Mar 2023 10:23:57 -0800 (PST) X-Google-Smtp-Source: AK7set8m0zHp4+Ap4QGGfTwI3BDHOLQ5XosZbWWs8zWchW9GC7HAZo0rtm47AjaZywOwBiOeaVAG X-Received: by 2002:a05:6a20:841a:b0:bc:96bd:d701 with SMTP id c26-20020a056a20841a00b000bc96bdd701mr42240674pzd.13.1678559036957; Sat, 11 Mar 2023 10:23:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678559036; cv=none; d=google.com; s=arc-20160816; b=z+xDaV/nY0c5tepe4a0iZAPzZ0Yqj6GA1anW5B4d4qqutGRwo2JX2+hinNBAYOQt+M vl+pmphQlrIkKs07IbinELS1hwQs/A/Sk3GDBbUGRqYuaA6dL09LpBu41mDCtYCWzbKI Ntj+PuJVFw3H8EQE3bFBRsS4xItLRtrtfu+I7rc6J656gnenr8nc+qcaM+ma8oEfyFcs ErCMozW6BGAg5x+ahoCzDuzRjZu9fIB/C853AdF/8p7CX0xgkEuCG4K+zIKab6JgXsFq D70NpCzmqCNfEvPTENA4HZQvoAua/JiFkZ7mNkVvPkQ58nttq7E0o4TxSBy8q4FmO6ED 6uBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=O/eC/VP3xR/fK2+k85eSTE/1aYsChEdTIJsTVPzdm+w=; b=uyvYWlLnkmcsFOJZNcJMw7gI+am7m75ORgUbaqQrXzGJF2SxXyumGapMM4HSbUPez9 BKGWnRP7FNyWWcfuCkY7e/taUZmCROIO5FijC3DfHO0Wh3pLFxpy93t+fiFixDDBl5k6 7vG59QbD+Z+Gdfvxra7D8BJCeZb4w8ujBUFkID8oZorqHyocmCgP+k+XpdEGPmCZbYZT 3jJt7iGBScpN/l3VuO+hnZN6JATaMmJ1zMSmKvc04LHQNR9cocxKp/4MSYOh2r7VJ7Z2 qfdOkrSA0qLsxaA2CcpE+hV19x4/aqdW2rmYw+5tW5Wit8jlZJ1J7arkJtSA4fx1+Bjh 29pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=Dq8AWLQj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x22-20020aa78f16000000b0058b9025bd61si2466280pfr.53.2023.03.11.10.23.45; Sat, 11 Mar 2023 10:23:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=Dq8AWLQj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229968AbjCKRrT (ORCPT + 99 others); Sat, 11 Mar 2023 12:47:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjCKRrS (ORCPT ); Sat, 11 Mar 2023 12:47:18 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.216]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A863393FA; Sat, 11 Mar 2023 09:47:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=O/eC/ VP3xR/fK2+k85eSTE/1aYsChEdTIJsTVPzdm+w=; b=Dq8AWLQjBIAdKjsGBDdLV 0SqVYZJsj2F28HXZp2zDZ4h2UwznSG15KVQV0hNeXzqlvjfh5q+f2/XTnT9iX6oM uff0wkgGJNwWW0GhhFa8QYAflQ4Jh57GPekicving74Ujun7NQ0u5vyE7qIFN4m9 LJkeXNELEWFB1aKRZCKMkk= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g2-1 (Coremail) with SMTP id _____wBnbZmLvgxkO4YPDA--.56172S2; Sun, 12 Mar 2023 01:46:51 +0800 (CST) From: Zheng Wang To: njavali@marvell.com Cc: sebastian.reichel@collabora.com, mrangankar@marvell.com, GR-QLogic-Storage-Upstream@marvell.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH v2] power: supply: da9150: Fix use after free bug in da9150_charger_remove due to race condition Date: Sun, 12 Mar 2023 01:46:50 +0800 Message-Id: <20230311174650.3979517-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wBnbZmLvgxkO4YPDA--.56172S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7AFy7trWftrWkCF4DXr1UWrg_yoW8XFWrp3 98Cr9xGF48tFWUtF4kt3W7CFyUGa43CryY9r4xG345Zw13Zw4jqr15JFn8tFy7Ar4fAF4I vanYq3y2g3W5GrUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0ziID73UUUUU= X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiXRMvU1WBo4DxnQAAsp X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760096721200186831?= X-GMAIL-MSGID: =?utf-8?q?1760096721200186831?= In da9150_charger_probe, &charger->otg_work is bound with da9150_charger_otg_work. da9150_charger_otg_ncb may be called to start the work. If we remove the module which will call da9150_charger_remove to make cleanup, there may be a unfinished work. The possible sequence is as follows: Fix it by canceling the work before cleanup in the da9150_charger_remove CPU0 CPUc1 |da9150_charger_otg_work da9150_charger_remove | power_supply_unregister | device_unregister | power_supply_dev_release| kfree(psy) | | | power_supply_changed(charger->usb); | //use Fixes: c1a281e34dae ("power: Add support for DA9150 Charger") Signed-off-by: Zheng Wang --- v2: - fix wrong description in commit message and mov cancel_work_sync after usb_unregister_notifier suggested by Sebastian Reichel --- drivers/power/supply/da9150-charger.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/power/supply/da9150-charger.c b/drivers/power/supply/da9150-charger.c index 14da5c595dd9..a87aeaea38e1 100644 --- a/drivers/power/supply/da9150-charger.c +++ b/drivers/power/supply/da9150-charger.c @@ -657,6 +657,7 @@ static int da9150_charger_remove(struct platform_device *pdev) if (!IS_ERR_OR_NULL(charger->usb_phy)) usb_unregister_notifier(charger->usb_phy, &charger->otg_nb); + cancel_work_sync(&charger->otg_work); power_supply_unregister(charger->battery); power_supply_unregister(charger->usb);