Message ID | 20230311173735.263293-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp383823wrd; Sat, 11 Mar 2023 09:51:41 -0800 (PST) X-Google-Smtp-Source: AK7set9tJqbb++6b7TY50/9eRz+YZwAXwVNnWqtiFpUL6Itz+9iHqokBLxoxnVEnM7zqbE3VtNcv X-Received: by 2002:a17:902:d2c7:b0:19e:8bfe:7d70 with SMTP id n7-20020a170902d2c700b0019e8bfe7d70mr37297246plc.52.1678557101278; Sat, 11 Mar 2023 09:51:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678557101; cv=none; d=google.com; s=arc-20160816; b=Gx/D60otKo8AlJmqrdjJJXuT5W/yf9SiU5ewYt69WX+Wrebd7n9hyjMtGPyn2SNil0 F3ID2KHP/nLji6skh36pb8BzFOO3CuRzSE6TN7ppaiD8m3I1kf3Rk7ERBxXrsQyShG1p a9ZvTbtqd2WvRu2rKExmF+bIhUu1a+Dk2JfaVfZcZdhFg2SptAdI6vH8OyjjwD/fy4ik c5bd7W4mGxNMFbvk/98396fU3PzAc3N+3bkPEog0gAbRwdrdxZjuCp7jDCmrPhdFuQ2y fWoVeLCiz4HzoqNCbQM1HRusWELBljwM3NCfVrUkGKHtp6172dyiosbkVfE/JSLW6pBV 6qHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=B0p0qqpSJoTCtFb+Kr7i0GNnHTIvTQKai2vdNlxuKcM=; b=GPkWR/PO00TqTbaCa1exnwNC0xvpnd2sa0COD1UYREIoC2A3/NukZJu42wUK/03/FI PNYegBimGyhd/j4LFK4QBx7sPjVtF1cIozdpeWbODx24GZIyfbCfw2kqpaSj/4eEHURz OUa8sGpSrJ/ip4vxFL5sK+QRDmJeJ6EvoAiQhxPzgdAZ/zfpE3aX6gXSY0FgIY4p35L8 HVSJQebM4/wG+NTZ6INIhGf2adZJPxOu5jriYFWyTbdaavCFetFHPhskgI381TFaKSR6 9mpMZYVnyvIBzPIMj5QI9lvBU7Z6N5JkUTdn3uGilGB2bkkUt4dt5G9YmefNC5gM9A9g vsUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WK3QS4sD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id az3-20020a170902a58300b001870c4d4378si2499803plb.498.2023.03.11.09.51.26; Sat, 11 Mar 2023 09:51:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WK3QS4sD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230284AbjCKRjP (ORCPT <rfc822;toshivichauhan@gmail.com> + 99 others); Sat, 11 Mar 2023 12:39:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230263AbjCKRi6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 11 Mar 2023 12:38:58 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2E46B456 for <linux-kernel@vger.kernel.org>; Sat, 11 Mar 2023 09:38:15 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id x3so32975395edb.10 for <linux-kernel@vger.kernel.org>; Sat, 11 Mar 2023 09:38:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678556257; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=B0p0qqpSJoTCtFb+Kr7i0GNnHTIvTQKai2vdNlxuKcM=; b=WK3QS4sDwcl1MqsLZ8ZlJxBQN83C2NF1ZVUas7Zl16IihZuW8nnIiAdMlXVMQstawm aSFXBEdoeRHAIlLChzTvHtvDu26dyUkunrmDxTMVkpIkxs2BkyC5bOVJyCR0YxQLFJSa x/depFRKep/anvIBotssZD8NTUXO1cfEOd3ZXEFJ+un3wIKGeIS6yibWWrSKqBTEAjOl jMN+Ct87AroeiHIqPLojAgVZZ733+E8IUZ9Ap1uT5gT3PezCbTk4W3g+bIL9RAnHRdMV S8ODEW3VD0b9RaZmdAiddu87FtWTOM6/TrhR9jBcOi7tV9E9yJruCRrsSBcqNiHs7KPm 6nxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678556257; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B0p0qqpSJoTCtFb+Kr7i0GNnHTIvTQKai2vdNlxuKcM=; b=57un8sYyaZwWcDCVJ+n7UkCJK+8EAkJ0QGBhEBcnFmYlMvh0YSdBDjU7WbBjKYHxRt b75ET6VfaPmu1J6ssIYRWn05GzQhgDhYUhLLvpuJOzYAqXzaTYaBkeMYNn9ZeNZl970U gU+8H9LMKc4TPv7tNuuEDLB1p5Qw8s+t1g3NERyd3iTqcbfrdGB6H3Fu29lAkecOd9u0 6zQWqIjX7tXIXLnbfDXVD3UDpTBR3BZ8dut200w3u7bkzXv7q2VmdIRrbeJzc5kx6jLd HfqaZc6c2KL/8U5S8N4q4REEcrYjFdW6omsBVEYXh7oh1F/kDszH86dQQKMqeHRThSDZ zwuQ== X-Gm-Message-State: AO0yUKXnrWU8HfhlYz1sQRc8uB6KM6PKO4SUqOOthk18+aJulD0UfkD4 3SUGQeBIusbz/n+KY4LkOXVJ2A== X-Received: by 2002:a05:6402:10c9:b0:4f9:9be3:a538 with SMTP id p9-20020a05640210c900b004f99be3a538mr3722729edu.13.1678556257370; Sat, 11 Mar 2023 09:37:37 -0800 (PST) Received: from krzk-bin.. ([2a02:810d:15c0:828:6927:e94d:fc63:9d6e]) by smtp.gmail.com with ESMTPSA id k15-20020a50ce4f000000b004d8287c775fsm1444903edj.8.2023.03.11.09.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 09:37:37 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Thierry Reding <thierry.reding@gmail.com>, =?utf-8?q?Uwe_Kleine-K=C3=B6n?= =?utf-8?q?ig?= <u.kleine-koenig@pengutronix.de>, Fabrice Gasnier <fabrice.gasnier@foss.st.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 1/2] pwm: rcar: drop of_match_ptr for ID table Date: Sat, 11 Mar 2023 18:37:34 +0100 Message-Id: <20230311173735.263293-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760094691253609063?= X-GMAIL-MSGID: =?utf-8?q?1760094691253609063?= |
Series |
[1/2] pwm: rcar: drop of_match_ptr for ID table
|
|
Commit Message
Krzysztof Kozlowski
March 11, 2023, 5:37 p.m. UTC
The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it might not be relevant here).
drivers/pwm/pwm-rcar.c:252:34: error: ‘rcar_pwm_of_table’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/pwm/pwm-rcar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Sat, Mar 11, 2023 at 06:37:34PM +0100, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). > > drivers/pwm/pwm-rcar.c:252:34: error: ‘rcar_pwm_of_table’ defined but not used [-Werror=unused-const-variable=] The commit log text sounds like a harmless optimisation, but the error message here either means you're fixing a compile failure, or (and?) the patch was sent out before the commit log was finalized. Looking at it this is the error message that triggers if you compile this driver with OF unset. I'd like to have that mentioned, then the patch looks fine. Ditto for the 2nd patch in this series. Best regards Uwe
On 12/03/2023 14:46, Uwe Kleine-König wrote: > On Sat, Mar 11, 2023 at 06:37:34PM +0100, Krzysztof Kozlowski wrote: >> The driver can match only via the DT table so the table should be always >> used and the of_match_ptr does not have any sense (this also allows ACPI >> matching via PRP0001, even though it might not be relevant here). >> >> drivers/pwm/pwm-rcar.c:252:34: error: ‘rcar_pwm_of_table’ defined but not used [-Werror=unused-const-variable=] > > The commit log text sounds like a harmless optimisation, but the error > message here either means you're fixing a compile failure, or (and?) the > patch was sent out before the commit log was finalized. > > Looking at it this is the error message that triggers if you compile > this driver with OF unset. I'd like to have that mentioned, then the > patch looks fine. Ditto for the 2nd patch in this series. Sure, ack! Best regards, Krzysztof
diff --git a/drivers/pwm/pwm-rcar.c b/drivers/pwm/pwm-rcar.c index 55f46d09602b..8f31f3cc93d5 100644 --- a/drivers/pwm/pwm-rcar.c +++ b/drivers/pwm/pwm-rcar.c @@ -260,7 +260,7 @@ static struct platform_driver rcar_pwm_driver = { .remove = rcar_pwm_remove, .driver = { .name = "pwm-rcar", - .of_match_table = of_match_ptr(rcar_pwm_of_table), + .of_match_table = rcar_pwm_of_table, } }; module_platform_driver(rcar_pwm_driver);