From patchwork Sat Mar 11 16:12:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 68131 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp356568wrd; Sat, 11 Mar 2023 08:31:48 -0800 (PST) X-Google-Smtp-Source: AK7set/YxjmlVsZndHy26n42394l1Pxt4S5DvpqnPD2VHUDzy07jjfZYSeSS8mc0lv/kpZ9Zeqx8 X-Received: by 2002:a17:902:708c:b0:19a:9686:ea8b with SMTP id z12-20020a170902708c00b0019a9686ea8bmr25843198plk.28.1678552308274; Sat, 11 Mar 2023 08:31:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678552308; cv=none; d=google.com; s=arc-20160816; b=uDuJsJAQcKkdIY/cG3ryPX05EF5Icg9Ncr4E3Eyl3YDV7xz5sP/VnvbdEnagBwqmfJ e6o6aKTDg3OCUSXcRS/4vvHhauhffWNNiYvb+OnCNW7SPlEuVTGZujEk34BFQvpIRp0q RfRT/Qe3XVHDXBo08V9qdggpUBGadyTi8iwVJN36EWIF1eECoC7hOG8stckcq2izV4J+ bhntRM9Xocoi9xbkQU1Rd5aa8jZz0IjFPAmMWf15UZi6xx1vWRD4tYaPt9meDqoYsjCq 13btHO9VVYOZ9nawEcYN78eJNu3pmP8a04dJpMGtPcLODlqPiqnrkelJmdeK8iSxEvMg EhLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=fz36AkXpYMaBUJI+NqgAwqVO9nDPS2Gc+hOC9+rtMto=; b=ynCW8HZIhTloBRbuWr/tGoTlWxC+tfeyJGsZhA7bB5cyxKALjyGBQjNVoDjZnBimOs 1qtAlqMkN9LgwebXHnTQncuqlMXxd812yzP7ilWpO98E/rVz5ciEHgRbU3Nm3QhIGHo5 Y1lcF2rpiBbcqjHh2iDCS+/VcbG5wXfbN5OxIiCreRi5bkm862y3aixISYxRddEQg8G2 3zFiuq05VieVoJG+T5mJfIODLGDUNUYzr1T8IUInF+OLwsZc4KSYa6TUMk6Bcn3W5+sX DOVKp2bWdTgchDwhMJ4Wlt6So14GArXwaQMIOueCrmxfdWSyW1IJdVq9rVnB2ib58+om 0cxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=iun3BZKG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v14-20020a170902e8ce00b0019b0b0079a7si2395045plg.550.2023.03.11.08.31.32; Sat, 11 Mar 2023 08:31:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=iun3BZKG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230432AbjCKQOC (ORCPT + 99 others); Sat, 11 Mar 2023 11:14:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230179AbjCKQOB (ORCPT ); Sat, 11 Mar 2023 11:14:01 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6EC4228E50; Sat, 11 Mar 2023 08:13:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=fz36A kXpYMaBUJI+NqgAwqVO9nDPS2Gc+hOC9+rtMto=; b=iun3BZKGbRyvtMGci4XWb 5+q8Bnul2sk1NAdC2sntb7J5eYYMFXYnV5s9M2WWjTkb5LKgRvfz8HGLLxTMmvM1 WmwmckcWV0Z87ib5gFa/ajIzlsc9WeQnP98326axnd5o6/iYzL+CTeVQtyRNUtrm +CwEsscXWEyf4ysZ5VGKZ8= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g4-2 (Coremail) with SMTP id _____wAndn58qAxkIM8FDA--.21310S2; Sun, 12 Mar 2023 00:12:44 +0800 (CST) From: Zheng Wang To: gregkh@linuxfoundation.org Cc: p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com, phil.edworthy@renesas.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, yoshihiro.shimoda.uh@renesas.com, Zheng Wang Subject: [PATCH v2] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition Date: Sun, 12 Mar 2023 00:12:42 +0800 Message-Id: <20230311161242.3773432-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wAndn58qAxkIM8FDA--.21310S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7tF1DGryfJr47ArWxZFyDAwb_yoW8Gw13pF Z8KFW8Jr4rGFW0q39rGFykZF1rCF9rKry7ZFWxKws7uF1rG3y8tr92qa1j9F1xJFZ3Ar4F qa4Du340qay7u37anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0ziaZXrUUUUU= X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiQh8vU1aEEn8ixQAAs5 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760089665194205419?= X-GMAIL-MSGID: =?utf-8?q?1760089665194205419?= In renesas_usb3_probe, &usb3->role_work is bound with renesas_usb3_role_work. renesas_usb3_start will be called to start the work. to make cleanup, there may be an unfinished work. The possible sequence is as follows: Fix it by canceling the work before cleanup in the renesas_usb3_remove CPU0 CPU1 |renesas_usb3_role_work renesas_usb3_remove | usb_role_switch_unregister | device_unregister | kfree(sw) | free usb3->role_sw | | usb_role_switch_set_role | //use usb3->role_sw Fixes: 39facfa01c9f ("usb: gadget: udc: renesas_usb3: Add register of usb role switch") Signed-off-by: Zheng Wang --- v2: - fix typo, use clearer commit message and only cancel the UAF-related work suggested by Yoshihiro Shimoda --- drivers/usb/gadget/udc/renesas_usb3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c index bee6bceafc4f..a301af66bd91 100644 --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -2661,6 +2661,7 @@ static int renesas_usb3_remove(struct platform_device *pdev) debugfs_remove_recursive(usb3->dentry); device_remove_file(&pdev->dev, &dev_attr_role); + cancel_work_sync(&usb3->role_work); usb_role_switch_unregister(usb3->role_sw); usb_del_gadget_udc(&usb3->gadget);