From patchwork Sat Mar 11 11:13:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 68065 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp233288wrd; Sat, 11 Mar 2023 03:18:39 -0800 (PST) X-Google-Smtp-Source: AK7set+FhP8VSVr6x3TlRnXGQZkQrRqshxDGkTruPSMWxOJbi1id+FYJQpCXQT9h7Ab2HUN0CkwO X-Received: by 2002:a17:90a:19d:b0:233:ab9b:f86a with SMTP id 29-20020a17090a019d00b00233ab9bf86amr11977921pjc.8.1678533519223; Sat, 11 Mar 2023 03:18:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678533519; cv=none; d=google.com; s=arc-20160816; b=oRov4HbT2NzTOD8E6dTy2JyH2c/YM1yDRRQ/da/sPeE0zcGK2nTQNJpKgxWv716Z3J d/uTGfGgE8SxQpvexYp3WcC51KzZsKR6EulRmNQesQL2Gif2m27X0Wk1mGqgkRabm1bu 6DPhYhDOBbpoEFrgY6Rdk95jxK2nHBK2c98IwFcj+cQzWPzkbJdl4xVl54ewurtnPtlK 7orv+LzmeFCT4Ks1G2yrOBUnX0e/hNqr/sllxDUufb4M1X3d+px5jc/Tn/2tgPjUZgSb s9BYto26ayNvcBaFXznTOmUq6ihP5AjfSYdF+UzLkwan1LlCeyGEc2nWP/DRbpqI7bwK IPzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VC9LP4Mz3ZehLFvi2CSx22bsql7JNCcQ0viTq1wmSCc=; b=NWPoPkfivSN8BLWEXKRZCb3qMvYWM/ySDCMMHld1gm4QosT5B29yIP5bsbWkI5rBM7 JcHqzuhG+ytihhyyqU5I0m6mdsvYRgMIxPoIKpUUw1u07K5IHNRv0L999COu6KyR1xsZ gKGdaeXyx7LlDoGNutmoJbAcaikZchkW96QIXl9SBQq2vWEhaOFbdjoVJtR++74sCHOC 36zve6MweoNBIZVUClcliqydVU6CU/Llsa5CybQCRIWNtjZxlAIXW7DXHU9hBD3SpxbK kOS6U8cbEPnIIX1IVoQPlfpvcGsNxEeC8elK/gUbngGu1VcIuoJZjF5Sl6LBn5j6ToZ0 77kQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=O4S33oHN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mt17-20020a17090b231100b00237a82e4f35si1946468pjb.126.2023.03.11.03.18.23; Sat, 11 Mar 2023 03:18:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=O4S33oHN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229965AbjCKLNo (ORCPT + 99 others); Sat, 11 Mar 2023 06:13:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbjCKLNV (ORCPT ); Sat, 11 Mar 2023 06:13:21 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 122E210AB7 for ; Sat, 11 Mar 2023 03:13:15 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id r15so3535896edq.11 for ; Sat, 11 Mar 2023 03:13:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678533194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VC9LP4Mz3ZehLFvi2CSx22bsql7JNCcQ0viTq1wmSCc=; b=O4S33oHNUCZoaXa1/QENkscGWzkVC5vXemfIKwaGTgV94h9Skey96TbQiRRLkCDmBP xRoabFrs2wASqubivqfcgL4ZsVoG/abE12Fgx86eMPRytCmEtI0Dp3mts5s+NnTbS3TN SnhU523+D2+a25wrW3xsy+knBpl6l8eDUY1F36c6Nr61tOouSC7iBtl5356TiCC76BG+ ZTBnnJcXcdo2WoHDxL9iyQG0JeMNpnfRQdaCCxfJtjgiy5o6xNvnGPWAdzuk5Ui44u5U zQyFJXKE4jtrQ8KFv9mpx2N0fNcURBaoMTVMTLkTAeIXssbN8Zs+Zqpu48Oc/p5fkBc4 sC0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678533194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VC9LP4Mz3ZehLFvi2CSx22bsql7JNCcQ0viTq1wmSCc=; b=bhNWTvlpe4c6wYnOuRbM/+DCY3YHEkfQb4KWVkNGckwP4uhag8iTkrvyEypUuoKH7b JCtR7Q/NP7SqADT8btRUtvkxEI502OqbN5dYotyEmk0ZlVme3Y8TsNnymPl0ojoN1dMW QU8amjyDc0ORdo7a0rkGRuCjC8TsD/3cRvoqlV1KmHStwXgXszBQ3hoG+T0nGpLR1Woq 8xXV8Ykiq74tZ0Xwf6niZ2IfP/f69N1qUchTYXlMPvuLy5eNmdHlh/7/GwZvr0xz/Pur 6n5j4bTOBVGS4E8Rxr89ciKTwsa7TPEzTab2y6tPVagA8A0BWlAFGSuqBsPxtPlRM4ds a28g== X-Gm-Message-State: AO0yUKVWf7cYM2W/d79Lv2sUBGd6yDlpnOV2jYzy4wUErQ/LB5Z5Ao/o Fvw4IpngpkhelOXRFHw/LbJs5w== X-Received: by 2002:a17:906:4f94:b0:8ed:e8d6:42c4 with SMTP id o20-20020a1709064f9400b008ede8d642c4mr27839053eju.12.1678533194223; Sat, 11 Mar 2023 03:13:14 -0800 (PST) Received: from krzk-bin.. ([2a02:810d:15c0:828:fa97:2d7c:bdd7:e1b]) by smtp.gmail.com with ESMTPSA id s11-20020a170906bc4b00b008ee95ccfe06sm973189ejv.119.2023.03.11.03.13.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 03:13:13 -0800 (PST) From: Krzysztof Kozlowski To: Mun Yew Tham , Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Broadcom internal kernel review list , Ludovic Desroches , Palmer Dabbelt , Paul Walmsley , Nobuhiro Iwamatsu , Nandor Han , Semi Malinen , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [PATCH 5/8] gpio: sifive: drop of_match_ptr for ID table Date: Sat, 11 Mar 2023 12:13:04 +0100 Message-Id: <20230311111307.251123-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230311111307.251123-1-krzysztof.kozlowski@linaro.org> References: <20230311111307.251123-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760069963203551758?= X-GMAIL-MSGID: =?utf-8?q?1760069963203551758?= The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). drivers/gpio/gpio-sifive.c:263:34: error: ‘sifive_gpio_match’ defined but not used [-Werror=unused-const-variable=] Signed-off-by: Krzysztof Kozlowski Reviewed-by: Linus Walleij --- drivers/gpio/gpio-sifive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-sifive.c b/drivers/gpio/gpio-sifive.c index bc5660f61c57..98939cd4a71e 100644 --- a/drivers/gpio/gpio-sifive.c +++ b/drivers/gpio/gpio-sifive.c @@ -270,7 +270,7 @@ static struct platform_driver sifive_gpio_driver = { .probe = sifive_gpio_probe, .driver = { .name = "sifive_gpio", - .of_match_table = of_match_ptr(sifive_gpio_match), + .of_match_table = sifive_gpio_match, }, }; builtin_platform_driver(sifive_gpio_driver)