From patchwork Sat Mar 11 09:37:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 68036 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp202200wrd; Sat, 11 Mar 2023 01:42:01 -0800 (PST) X-Google-Smtp-Source: AK7set9j27VO7vmpcjpaYPGIBHIt0qhL0/0vcbH1HoLcoXTl8vKuZrSw34NcelxRQIqv1pbby7Zj X-Received: by 2002:a17:903:18e:b0:19a:75b8:f4ff with SMTP id z14-20020a170903018e00b0019a75b8f4ffmr34920313plg.35.1678527721128; Sat, 11 Mar 2023 01:42:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678527721; cv=none; d=google.com; s=arc-20160816; b=veewXynBG75UzTZQoo/8fWycjSsyD3I6S0S8T7KeOnV1wERur0jiJOqbo6HLu7q7Tz RiOK6L2ByKHuPIMN6Ev/5zq3umyaOgNTPZpeGzHnRrLN54DhSHVbYm+EqxEO9a4+Wtc+ sfGNapnX769tAs6GU8Tly5jK2HNnueiDZ2QwJA/ND+rBFgro6DZ180EJQ6VhekWoU+BT T3PpNX1ZNkWuRivEIkL62mOf5Jz+fHPbv/77FAalWpPudEFSoXqfma/BYx14gWDcWkrd vntGvKsEeRUjwyl1eifN2lgrSidus997zXpTCYQkvUKfDxe3RVQK+Em950D9swWIMBxi sfxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=zoFNgJXSeI0QXkwv/gajPhMKTUx0Ql0+UzzulYKcp8I=; b=CG6LHvYKgm55S4FlVuw//Ka+lYflKIHbJtuNq9wNpVkAhheMN4LN2I2BqkhU7n6E2q 5GEBl9154cKQS8Ip9e0UvJQHKDeu8JSWfUY5NbXTGrZaH3k2ti5eu15gRWEpzB2yLcZf OBYKtr/XNekX6Dq9CU0qO91J6EKbYEm8w8fAHx1mLJ/1GBQM4MxQW2WnYOcFcBJbkfcg JTzplcr04fHnf7i0AH1QJaJp4zUDbyHlwDrp8iyhCY0MeEu/Ae73seT5jC8FWSCGXkJa Stqaqu420M7lN0jrN6cG5g7Nnw6sFwIEyB0PQKeE5Cy7D831kDH2XmJIcq1KECk8cJIU seHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vbuq92uT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k7-20020a170902ba8700b0019e4154578esi1906917pls.76.2023.03.11.01.41.48; Sat, 11 Mar 2023 01:42:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vbuq92uT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229929AbjCKJhg (ORCPT + 99 others); Sat, 11 Mar 2023 04:37:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229954AbjCKJhX (ORCPT ); Sat, 11 Mar 2023 04:37:23 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32F1B12BAC3 for ; Sat, 11 Mar 2023 01:37:22 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id s11so30159102edy.8 for ; Sat, 11 Mar 2023 01:37:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678527440; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zoFNgJXSeI0QXkwv/gajPhMKTUx0Ql0+UzzulYKcp8I=; b=vbuq92uTrFcz1QXjN5cnSNlg96KPUOHqt6l5sS8LDJThuZLSkQYO/OQrvtyyeBmhzp sIbfpuPfWkyChMnwl7W4s7V/HKIv5VnPpEpXl06TZFbCxw2ycBL/2WvRvW44dBg73LO1 wSLA5oKyKHTLaRseDmGziNzcR/bRllDnyLZETF1LvRFbNor45Z7mCLhbNjYcx/3qPR7G S6LH9YzhGt8e/uZ0tO2ymY6F2qIS9P8gtbuvzF8K+dZjmZ0eQ74V6CuQGlW4PM6P9Vrh rRTWovXPqepPEPxPK+6lkkgDvw1f+UvtSx0iYOgq1i+gQjv0+tMtWdxA/ucVpqcFFNIc kgvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678527440; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zoFNgJXSeI0QXkwv/gajPhMKTUx0Ql0+UzzulYKcp8I=; b=p88aNT1ngswmZWOK8woRo32iCeIgre8LYjswrcV8IX1c7vGhlBfEhDz6hwCzlOUP6W HgPSIANqolFJcxpwMp2kV6c0d5Uwb/LaeynA8tkS7DgYmi+Jcky0kmq3MiFzNbHRUy/D LRFXQsnVykCFsPvnU3NcmoBR806GKDOOYI9WnOQPOHNtUFn7+xE3eUMuoOL9t22zq/yj R6RiVGJn6khQoIYv+TO0Eu+UKhSQ8GfEDrMx/vbmKthFfsZPBHVIMH+aqNFtRmHw1w1K MVqI4svQPBt/LEBKJbgC7G2Vd7bNdag62Y2ML9AxXFt2mNOr6i5OsLIVbtxcG9fxKh4d ITgA== X-Gm-Message-State: AO0yUKVQK7tE09+shmDA1/rEUz4Bxf+XT1uSl3voIf9poyeDP0sAMgrO DnDMB/EdF86AC8QbXG0Lm9T42A== X-Received: by 2002:aa7:ccd6:0:b0:4af:59c0:5add with SMTP id y22-20020aa7ccd6000000b004af59c05addmr25985018edt.37.1678527440685; Sat, 11 Mar 2023 01:37:20 -0800 (PST) Received: from krzk-bin.. ([2a02:810d:15c0:828:fa97:2d7c:bdd7:e1b]) by smtp.gmail.com with ESMTPSA id y13-20020a50ce0d000000b004fa380a14e7sm631645edi.77.2023.03.11.01.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 01:37:20 -0800 (PST) From: Krzysztof Kozlowski To: Tony Lindgren , Liam Girdwood , Mark Brown , Jerome Neanne , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , stable@vger.kernel.org Subject: [PATCH] regulator: tps65219: fix matching interrupts for their regulators Date: Sat, 11 Mar 2023 10:37:18 +0100 Message-Id: <20230311093718.70803-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760063883711919736?= X-GMAIL-MSGID: =?utf-8?q?1760063883711919736?= The driver's probe() first registers regulators in a loop and then in a second loop passes them as irq data to the interrupt handlers. However the function to get the regulator for given name tps65219_get_rdev_by_name() was a no-op due to argument passed by value, not pointer, thus the second loop assigned always same value - from previous loop. The interrupts, when fired, where executed with wrong data. Compiler also noticed it: drivers/regulator/tps65219-regulator.c: In function ‘tps65219_get_rdev_by_name’: drivers/regulator/tps65219-regulator.c:292:60: error: parameter ‘dev’ set but not used [-Werror=unused-but-set-parameter] Fixes: c12ac5fc3e0a ("regulator: drivers: Add TI TPS65219 PMIC regulators support") Cc: Signed-off-by: Krzysztof Kozlowski --- Not tested. However the cood looks so trivial and so buggy (could have never worked), so I am really confused... --- drivers/regulator/tps65219-regulator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/tps65219-regulator.c b/drivers/regulator/tps65219-regulator.c index 4b5acaa45049..7f100361cbaf 100644 --- a/drivers/regulator/tps65219-regulator.c +++ b/drivers/regulator/tps65219-regulator.c @@ -289,13 +289,13 @@ static irqreturn_t tps65219_regulator_irq_handler(int irq, void *data) static int tps65219_get_rdev_by_name(const char *regulator_name, struct regulator_dev *rdevtbl[7], - struct regulator_dev *dev) + struct regulator_dev **dev) { int i; for (i = 0; i < ARRAY_SIZE(regulators); i++) { if (strcmp(regulator_name, regulators[i].name) == 0) { - dev = rdevtbl[i]; + *dev = rdevtbl[i]; return 0; } } @@ -348,7 +348,7 @@ static int tps65219_regulator_probe(struct platform_device *pdev) irq_data[i].dev = tps->dev; irq_data[i].type = irq_type; - tps65219_get_rdev_by_name(irq_type->regulator_name, rdevtbl, rdev); + tps65219_get_rdev_by_name(irq_type->regulator_name, rdevtbl, &rdev); if (IS_ERR(rdev)) { dev_err(tps->dev, "Failed to get rdev for %s\n", irq_type->regulator_name);