From patchwork Sat Mar 11 06:57:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 68005 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp170391wrd; Fri, 10 Mar 2023 23:52:15 -0800 (PST) X-Google-Smtp-Source: AK7set9k4A38rDD4/FD4git1Ahb3UrTZRPAPdP0qeMXROX5s25I1vmvvXCgFkWnFEK9Zmm6yQoAy X-Received: by 2002:a05:6a20:4905:b0:cc:fdfa:9091 with SMTP id ft5-20020a056a20490500b000ccfdfa9091mr21511261pzb.57.1678521135540; Fri, 10 Mar 2023 23:52:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678521135; cv=none; d=google.com; s=arc-20160816; b=N+lzfGJIy4iFVF8dDdVOj/m5dQhKKrNdn4nUlUkcxiSf3mh0OiFcI+oxAFvUoLqY63 Al6KkWMvLel07dNz9uS0vm9H8Qi7Tpyz8598QAIsaGanXXiHMpa2qMJAW1rDbhFY/e0v VhYmOLj8+ksp44owk/CiNwF/Z/6yCCSQv3bPor3JFfFo9IfQd+QqM3tCQFyMZGr9R3G3 pnxDgMbtWrCxzVRC8pWjJshouvoEa1q9EIx2q+tKaf7hYz0N+m/F4TiRieNLQ024kO7h JpJtEMyEa1wQlxU2TjOFzQ6fBGz+hAxbpPh83KTmjdsOu+Um/ZWY7nWngElDnLneGyb5 bQrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:references:mime-version :message-id:in-reply-to:date:dkim-signature; bh=suA+bwgJNWM1ViYRwliFKAa9dMDLpk9Qwp1WJkMdxcc=; b=TWjYmSuCyb3Iyzs/dprpmx8/hAsDYnCF224i0ROoHdhBGkJzm7Hs1Xcvh5+YRzp074 8PD8xmjglZKa0L7CT9UOOUge6OnyCjL3A/OCOQG7ph6E7emomQlDo9pWkbxBd5cgMmte +/bEvlOZ0QdRn8Ox5oiwhpaSakCb/UizVs7xWX1chHMtYxJWMfhoaoldlbmicX5PvNEk zl0z6Eo00UkeLTXG0TkuFW4pC1ZNd5mk3xI7mQfCqUcwnBO3z1P8dl+dgbUgZHoWR6uj EHCS2ERJD7U7ueRLX9owpO7QQFEoYD2jBOlGjpOs91kUt1Movg5AwdMzdi3d8UtwUIar idQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=CQZt3tWj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y30-20020aa793de000000b005827af240basi1497612pff.289.2023.03.10.23.52.03; Fri, 10 Mar 2023 23:52:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=CQZt3tWj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230200AbjCKHA7 (ORCPT + 99 others); Sat, 11 Mar 2023 02:00:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230188AbjCKHAZ (ORCPT ); Sat, 11 Mar 2023 02:00:25 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9ECDC144977 for ; Fri, 10 Mar 2023 22:59:56 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id e20-20020a25d314000000b00b33355abd3dso2704141ybf.14 for ; Fri, 10 Mar 2023 22:59:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678517995; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=suA+bwgJNWM1ViYRwliFKAa9dMDLpk9Qwp1WJkMdxcc=; b=CQZt3tWjAs16t6INtGV8MfbsFPXnxShEd3XQr0Eg2M1Lq8aK2hi5j69UBZR4nZvzQk s70YdoH35sqKBKPjWDpSYMFsqUFh0N/2F4nVGpQMSCBVJcFiDIavD87dGD04hX8KnzQO 872HqHIhAoE6Y39RvB4exu295r38ilJ6XdN22SVd+X4CzDldEZzpLwiDUDuJgFIXo2JB DQ0r3g7RnmpHwriEWOT1iX4UDptqU27wyA0chat1UyI4L+vzaMegrBm+fA9mCexnzQb/ ProMYdMUTJIItTVUbMrA9mEo6o7msjnB11hVk/pqvLYWAGyciPvgRwd37MCBKBNz7Hbl l1Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678517995; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=suA+bwgJNWM1ViYRwliFKAa9dMDLpk9Qwp1WJkMdxcc=; b=cH1gtR1izGnB4mdBbSu8eA92pzOIUNedDv8CcAIBz7mzcDY/neeD3r6YdUtZsHh7gJ 0+cnzrhUPdmD954Qqb0atUn21I2pkrfRgFUF5NJjQxUbNsiYqsGgXNDgG81MDl6FWvNk OUEyn8roLNxP0MORI1v0bt4zK9J6D7qLGGVQej6Ng97oEInppkl76Eqi46io2dHcBkFT 6+4hPTluHXOhhI9G6MhW8ZAfBGU53G8bmYXv4syJRvv8BNmpbGSzx6bh9P8flCKCl8/T y2q7JGFPEQvbLcIHx4rA3zdpHjCaqjr70MhB8Qnj+qDf/CNYUxocN7j4GufwX+549V43 2mfQ== X-Gm-Message-State: AO0yUKW2jisOEgwDGCkAsllt1tNozntRs2EsqvkV5JhN4XTSc5iHaqj2 3ENDkmk3QrpLp2AlKP4OQaImgdOI9ek1 X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:a11d:a763:a328:f2d6]) (user=irogers job=sendgmr) by 2002:a81:a983:0:b0:52e:e095:d840 with SMTP id g125-20020a81a983000000b0052ee095d840mr18667452ywh.0.1678517995660; Fri, 10 Mar 2023 22:59:55 -0800 (PST) Date: Fri, 10 Mar 2023 22:57:53 -0800 In-Reply-To: <20230311065753.3012826-1-irogers@google.com> Message-Id: <20230311065753.3012826-14-irogers@google.com> Mime-Version: 1.0 References: <20230311065753.3012826-1-irogers@google.com> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog Subject: [PATCH v1 13/13] perf build: Remove redundant NO_NEWT build option From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Nathan Chancellor , Nick Desaulniers , Tom Rix , Roberto Sassu , Quentin Monnet , Andres Freund , Tiezhu Yang , Pavithra Gurushankar , Yang Jihong , Adrian Hunter , Leo Yan , " =?utf-8?q?Martin_Li=C5=A1ka?= " , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, llvm@lists.linux.dev Cc: Stephane Eranian , Ian Rogers X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760056977790161573?= X-GMAIL-MSGID: =?utf-8?q?1760056977790161573?= The option controlled nothing and no code depends, conditional or otherwise, on libnewt. Signed-off-by: Ian Rogers --- tools/perf/Makefile.config | 4 ---- tools/perf/Makefile.perf | 2 -- tools/perf/tests/make | 6 ++---- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index 1b598c5e68eb..b7a9cb4a3526 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -752,10 +752,6 @@ ifndef NO_LIBCRYPTO endif endif -ifdef NO_NEWT - NO_SLANG=1 -endif - ifndef NO_SLANG ifneq ($(feature-libslang), 1) ifneq ($(feature-libslang-include-subdir), 1) diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index 3e06915f6bd0..dc9dda09b076 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -44,8 +44,6 @@ include ../scripts/utilities.mak # # Define WERROR=0 to disable treating any warnings as errors. # -# Define NO_NEWT if you do not want TUI support. (deprecated) -# # Define NO_SLANG if you do not want TUI support. # # Define GTK2 if you want GTK+ GUI support. diff --git a/tools/perf/tests/make b/tools/perf/tests/make index 47c665659022..a74b4be446c6 100644 --- a/tools/perf/tests/make +++ b/tools/perf/tests/make @@ -72,10 +72,9 @@ make_nondistro := BUILD_NONDISTRO=1 make_no_libperl := NO_LIBPERL=1 make_no_libpython := NO_LIBPYTHON=1 make_no_scripts := NO_LIBPYTHON=1 NO_LIBPERL=1 -make_no_newt := NO_NEWT=1 make_no_slang := NO_SLANG=1 make_no_gtk2 := NO_GTK2=1 -make_no_ui := NO_NEWT=1 NO_SLANG=1 NO_GTK2=1 +make_no_ui := NO_SLANG=1 NO_GTK2=1 make_no_demangle := NO_DEMANGLE=1 make_no_libelf := NO_LIBELF=1 make_no_libunwind := NO_LIBUNWIND=1 @@ -115,7 +114,7 @@ make_install_prefix_slash := install prefix=/tmp/krava/ make_static := LDFLAGS=-static NO_PERF_READ_VDSO32=1 NO_PERF_READ_VDSOX32=1 NO_JVMTI=1 # all the NO_* variable combined -make_minimal := NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 +make_minimal := NO_LIBPERL=1 NO_LIBPYTHON=1 NO_GTK2=1 make_minimal += NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 make_minimal += NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 make_minimal += NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 @@ -139,7 +138,6 @@ run += make_nondistro run += make_no_libperl run += make_no_libpython run += make_no_scripts -run += make_no_newt run += make_no_slang run += make_no_gtk2 run += make_no_ui