From patchwork Sat Mar 11 03:14:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 67967 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp97016wrd; Fri, 10 Mar 2023 19:17:13 -0800 (PST) X-Google-Smtp-Source: AK7set8wKnSX+D3FV5Gn0wO9Vq7C4CoMiz0AhCLUY+JFGUVjvCaotieqO71z9vDNOgORPf9TplgA X-Received: by 2002:a17:90b:1c87:b0:236:73d5:82cf with SMTP id oo7-20020a17090b1c8700b0023673d582cfmr27973604pjb.9.1678504632823; Fri, 10 Mar 2023 19:17:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678504632; cv=none; d=google.com; s=arc-20160816; b=Cn5LKC+fuy67myVjtGNMLE2zPVJUzMwob6FSQVUtuNJwfUKP83gjwUqeNTULwX5UuJ hAD+mg7lnvAxJdXJnNIWOfrOJDAPblX9ORbfzuymOl4GJMAv7thElby4zZasCRQaXS5F z40p111Uf1HscO/D6WkwoO6qrT1zIzUzK9ELHhVtHkAsjgZywRLxbq0t32C0Eh+QPlRf JNxh4sDKFsbOKPUMCi4FUuetzn8Uu3NsH3fFPZ7SFwImknPf9+WvGW0MsB6Sv66mzgxm yBs93GjYdBx/4Biy966fUxXl8d4w1KLUXX9Mq1vn81R8AfDqL/ej0Aylhm4aj6MveEt2 Ivew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:dkim-signature :from; bh=cPqTJGly2Vap5U+Eo6PgcDUirkgrha96cV2djrF36Ro=; b=BJ8F1I/B5F3EYorF5Q2jzdGWDBEQqkzKP2au9ajclAnaAGXYwrgpW/UGs7XaFeNAaD mdkK+f7cvPC+rSgXEn+XAwhQYX9CTNVZ840iO9tweAiVBpjIivv0+UB72Yi0/2OJyoZX 1A6rAKACra9aBJgWOfGA0PEKZG9hMEzXH5tBZLqysp/Gnm88jq7/0slQQfSjyBfDDy2n ACF+mVSPuWlujsONr+K5f0wvEpExiTfigzs1S3yDfQk1h4+CgvG+3TuYMAbRbYmM7OSk k+p4+DhWL+gVa9OPuaPqFF1NhuhWW9PacnVsOcqsnvdh0F2ipMlKBMrcMhOHBvdyuBOj ROSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=hBhcLJv3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nk6-20020a17090b194600b0023406918cbasi1226220pjb.157.2023.03.10.19.17.00; Fri, 10 Mar 2023 19:17:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=hBhcLJv3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229895AbjCKDPN (ORCPT + 99 others); Fri, 10 Mar 2023 22:15:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbjCKDPC (ORCPT ); Fri, 10 Mar 2023 22:15:02 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A33A132A94 for ; Fri, 10 Mar 2023 19:15:00 -0800 (PST) From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1678504498; bh=pCEog6vxwSuKmvKLhc80450ur1XxkLoLlCfazqFt1F0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=hBhcLJv3vkpuVK0jz9kWGargi8oM/bWAOYD6b4P03pAkENPLv8TeRN2rJbLaUmet5 IveFF1TAXhGbIly7PajneFQT5Jdc+hGo47BFvsWy2bx6AlZfQQR4AMzWdbwgFXJHcf pnJS6C4tsZgfrqkZMEdRpXeacTh+b6IIf7boqCzg= Date: Sat, 11 Mar 2023 03:14:47 +0000 Subject: [PATCH 2/4] kobject: align stacktrace levels to logging message MIME-Version: 1.0 Message-Id: <20230311-kobject-warning-v1-2-1ebba4f71fb5@weissschuh.net> References: <20230311-kobject-warning-v1-0-1ebba4f71fb5@weissschuh.net> In-Reply-To: <20230311-kobject-warning-v1-0-1ebba4f71fb5@weissschuh.net> To: Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1678504493; l=1551; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=pCEog6vxwSuKmvKLhc80450ur1XxkLoLlCfazqFt1F0=; b=4MfIfOAfHwH+ONwUjubatS0nY+UNzyAioLh2YI5evEhAVmI2SI6nfiNqost8qs2AkmLHZ+MnA Qy30P6yFsQJB/MX3UbN6LRaFSgyzDqODqAOxjyJmumiLFKIOgiyhq3G X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760039673494963675?= X-GMAIL-MSGID: =?utf-8?q?1760039673494963675?= Without an explicit level the stacktraces are printed at a default level. If this level does not match the one from the logging level it may happen that the stacktrace is shown without the message or vice versa. Both these cases are confusing, so make sure the user always sees both, the message and the stacktrace. Signed-off-by: Thomas Weißschuh --- lib/kobject.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/kobject.c b/lib/kobject.c index 09c81ffb8b33..f79a434e1231 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -340,7 +340,7 @@ void kobject_init(struct kobject *kobj, const struct kobj_type *ktype) /* do not error out as sometimes we can recover */ pr_err("kobject (%p): tried to init an initialized object, something is seriously wrong.\n", kobj); - dump_stack(); + dump_stack_lvl(KERN_ERR); } kobject_init_internal(kobj); @@ -349,7 +349,7 @@ void kobject_init(struct kobject *kobj, const struct kobj_type *ktype) error: pr_err("kobject (%p): %s\n", kobj, err_str); - dump_stack(); + dump_stack_lvl(KERN_ERR); } EXPORT_SYMBOL(kobject_init); @@ -413,7 +413,7 @@ int kobject_add(struct kobject *kobj, struct kobject *parent, if (!kobj->state_initialized) { pr_err("kobject '%s' (%p): tried to add an uninitialized object, something is seriously wrong.\n", kobject_name(kobj), kobj); - dump_stack(); + dump_stack_lvl(KERN_ERR); return -EINVAL; } va_start(args, fmt);