From patchwork Fri Mar 10 22:41:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 67831 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp9842wrd; Fri, 10 Mar 2023 14:55:11 -0800 (PST) X-Google-Smtp-Source: AK7set8sjxUwwq9ExdCydLrHFbJgqR6K8DohOt8IfjNIyrbmd+My2R49Tszolc1egnA9GY27T8It X-Received: by 2002:a17:903:11c9:b0:19e:cfbf:dcbb with SMTP id q9-20020a17090311c900b0019ecfbfdcbbmr17741124plh.66.1678488911524; Fri, 10 Mar 2023 14:55:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678488911; cv=none; d=google.com; s=arc-20160816; b=UMdhh5EB+jMMiFrsXqyOxtadPqHsfApk1B3EVT4ehFoTGvWe3P33lUaAfhDR0yiWPf p8Ksn235gYwT4Iw4liWpU0tGlHCv0b8BkYyMJ71levNUq/8Fr5WCkvcmwJd0DnxGloEM QgC9ij4BDMc0ZZKIyRmY9EvEXXwFVmYA70gpI/gmZ1LhnS3Um/VCUQBXvXhxA3Ly2vQo 6ay1T55AKGQh8gxMPp9RsF2dmdAu/ksJoC4vuaG4bFAUyF8rHSwOuBazsI+BpKwYmyEF ak/2nxmQg03nbRwY7k+isVMQIi6LkPlLEqB6VtvUUgeG9O7eOFadOEatPvYXM2zHuPBH KQxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=EiQ1R6WbbuaD3Hc9uREXBOCOenJitTBvcYzmZS6NQhM=; b=g7YYuDUCLqG2hCpu1vaLPX4tt6ifxI54YUXnj4eLQeV1tLRJUtizzpEgbSBns+NH5L X4uwXKuZnIqcKKTU1EcrHZ2UiWGdExUrQCKk10UALGcf9+sXbnZegqn2DYzW4QRHhGbj kmVb9qtbYXHrnKR4mljDP1F6iL0Eu5VmT40n8+EdqO8c3qPWpREW/PTZ9BQR76qNvzff an5txrwYU3ppkMSVZtkA4z6nySYZuC+f5novDs7cwfY6K7NUyTdR5odwubtlDKdRNJlu 94gz4rX/sJ9eYV3B+Ksn3WLhh4FSaiHlH1MpH3YzO96g8Rtgd6iHeruf0hpzfdKYJpM4 a9PQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ke8-20020a170903340800b0019f24b0388csi171801plb.486.2023.03.10.14.54.58; Fri, 10 Mar 2023 14:55:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231682AbjCJWmc (ORCPT + 99 others); Fri, 10 Mar 2023 17:42:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231879AbjCJWmI (ORCPT ); Fri, 10 Mar 2023 17:42:08 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5029214FE05 for ; Fri, 10 Mar 2023 14:41:44 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1palQh-0002dE-9u; Fri, 10 Mar 2023 23:41:39 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1palQf-003GqY-Fa; Fri, 10 Mar 2023 23:41:37 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1palQe-003uEi-NF; Fri, 10 Mar 2023 23:41:36 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Roy Pledge , Li Yang Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 5/6] soc: fsl: dpio: Suppress duplicated error reporting on device remove Date: Fri, 10 Mar 2023 23:41:27 +0100 Message-Id: <20230310224128.2638078-6-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230310224128.2638078-1-u.kleine-koenig@pengutronix.de> References: <20230310224128.2638078-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1085; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=jrvcriG6LY6cgmfGJKCy0SYPFV25hxPQL+k/hItVWeg=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkC7IP8/ceFmpLmvUa+JsfOgJYo497N77Opym3s j+VaP7QeOGJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAuyDwAKCRDB/BR4rcrs CVd8B/0VPto9yl5L2YKsfnTkyeyixLFuoF5giyuRmEzixWQLgAOxwFlkNcvGPkZ90qZb21QU1mo Kpbs8F6zt3hXiJVvZkdaUt6uMVRB+lQaRELXDQuwrKi8hYbMGkumj0DA0FakSoQQrn1ouqd/T1S Ww8QCmU/aAl5ncKRoJZVQq20saEPSV0TPAj2QcjhHvOnjXRxt9QPjOt3UWJd5cezIJn5fEongop 0mVDsnqLmNQnn94Dw47gAAU1Zb9l94LVWyzPl8Qoxt6GxIZhT4uFBg0Hq5CT4RCSIX2J/eNV+dP 6bCsDwjxVFhZvC+ebQoPTnRGNS1ibo9X9qG7BsdO5O0B5J8g X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760023189220931625?= X-GMAIL-MSGID: =?utf-8?q?1760023189220931625?= Returning an error code from a fsl_mc_driver's remove callback results in a generic error message, otherwise the value is ignored and the device gets unbound. As the only error path in dpaa2_dpio_remove() already emits an error message, return zero unconditionally to suppress another (less helpful) error report. Signed-off-by: Uwe Kleine-König --- drivers/soc/fsl/dpio/dpio-driver.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/soc/fsl/dpio/dpio-driver.c b/drivers/soc/fsl/dpio/dpio-driver.c index 74eace3109a1..09df5302d255 100644 --- a/drivers/soc/fsl/dpio/dpio-driver.c +++ b/drivers/soc/fsl/dpio/dpio-driver.c @@ -297,14 +297,10 @@ static int dpaa2_dpio_remove(struct fsl_mc_device *dpio_dev) dpio_close(dpio_dev->mc_io, 0, dpio_dev->mc_handle); - fsl_mc_portal_free(dpio_dev->mc_io); - - return 0; - err_open: fsl_mc_portal_free(dpio_dev->mc_io); - return err; + return 0; } static const struct fsl_mc_device_id dpaa2_dpio_match_id_table[] = {