From patchwork Fri Mar 10 22:41:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 67824 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp8779wrd; Fri, 10 Mar 2023 14:52:02 -0800 (PST) X-Google-Smtp-Source: AK7set8NagPj2mZBK1HBu4bSHYzK4aK72vMMbeCGCG1XNAWh83O6sozmQrK1IgDhcsnF7uFuw/ud X-Received: by 2002:a05:6a20:840d:b0:be:c1b2:514d with SMTP id c13-20020a056a20840d00b000bec1b2514dmr4476405pzd.13.1678488722284; Fri, 10 Mar 2023 14:52:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678488722; cv=none; d=google.com; s=arc-20160816; b=AhITDCSwE+5KdS10j03DpFhR5M7V8kAJgdd4IXGNgUsDineZllBzGj/+lOfbOA0JI1 qKib/qx5icxRluoydnExnjjukwnfSNX5vWzH2m0/83Ra2HDTuZd3MXq03VWeVyJk4UtT y0EVbQBwlx9IeWda6GyIBcJnUlEEFaJtInPqBr3hjw32fkrUIAU9d1Qt7CLnqleU9nyv V6cTnx0MiMrga0/H/2mzKMiqJwEA3s0HvllmVxccQDbsoLO2O/rBjV6vbZ0uGOBW0KCG s2B1MJ8m1316mKV7xb/lsH0U4QUm9cDpm/XzpeFDyKGcM7r09e7sPmZjICELUS59tkfX JGAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=UbcYGmAGpv16KQ4GoVbrRe4aui/Oj1y5e4VDM10sNW8=; b=emjUpPCvcxKuBhgHlRlH36Gn++mlvcp+4dstvCIvQz8jAB95QfKjQHMHEgzCaEsLHs TbQ+kjh0fkn/GIC5qc/u0tIvzGu/knMTGiSTaP7i0XJ9fhwjT8UtLQPABAwOJ8zHHkVO XUTUFxKie37Ij/OukX5ya2a0G30NjYeBxBXuUxOu6GGuNDv7rXnMfDUXQnSZ2FtRV55k DU7/6ssXokUONaa6/NXU+dVwQ2OiOgz16sYAuHwNLDxXtj4z07QfgJARnr1+4jQln6qW /fTtIj8xn9bTsDBzNHaY+401Wx33vSkzSg40t9Ga5kJK71KnuWyFpXFVXGOaMW9ucgqu Z0gA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g5-20020a635205000000b005074d6754e3si827729pgb.255.2023.03.10.14.51.14; Fri, 10 Mar 2023 14:52:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231714AbjCJWm1 (ORCPT + 99 others); Fri, 10 Mar 2023 17:42:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231766AbjCJWmG (ORCPT ); Fri, 10 Mar 2023 17:42:06 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF3A214DA10 for ; Fri, 10 Mar 2023 14:41:42 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1palQg-0002dB-Cc; Fri, 10 Mar 2023 23:41:38 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1palQe-003GqN-Ss; Fri, 10 Mar 2023 23:41:36 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1palQe-003uEY-3g; Fri, 10 Mar 2023 23:41:36 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Stuart Yoder , Laurentiu Tudor Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: [PATCH 2/6] bus: fsl-mc: dprc: Push down error message from fsl_mc_driver_remove() Date: Fri, 10 Mar 2023 23:41:24 +0100 Message-Id: <20230310224128.2638078-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230310224128.2638078-1-u.kleine-koenig@pengutronix.de> References: <20230310224128.2638078-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1279; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=zyomHc/a8RjH8rB16Pl7Aa7f3JBTHoJGdtnzhJxLWMk=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkC7IFde5cyfUUkluP5sb7EamLPCdvIGyRB0CDc 6qzXQhBDUqJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAuyBQAKCRDB/BR4rcrs CbADB/9d/5bLFRXln06G6ARKHRV+gcjOlv4P0ca124EZ6TwrRFHYRbbXlkHt9INfzPIPHT7CS9f MkH+Dh01R5ZH+tmMcArElHWhm3c0nJGcySFZgTsZCH/+SJX5wCk+gHXRGWHWX8G6ATfvQ5eiQr5 53Q1y0De1BXCmJBdW29mm4GN5PLcdteL7oVKRJIYY+y41vtGXXxdwQAKv5nTZi9S4bcRe8GZmGe IM2JeI1mzP++cK2M6UCdd7KPCU7GTuhhQ6IoF35iA+JPHe8kV9dqtV83702BPxxVVPAgGmrKOTu eoNge9LwTl84FvjOIFkLuaHIg6EBzbeczfHkA1TO7Sx153Ra X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760022990345779598?= X-GMAIL-MSGID: =?utf-8?q?1760022990345779598?= The error message emitted in fsl_mc_driver_remove() is very generic. Replace it by a message that mentions the reason for the failure. Returning zero instead of a negative value has no side effect apart from suppressing the generic error message. The first if condition in dprc_remove() can never be true, as this would prevent successful probing of the device and then .remove wasn't called. So this can just be dropped. Signed-off-by: Uwe Kleine-König --- drivers/bus/fsl-mc/dprc-driver.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/bus/fsl-mc/dprc-driver.c b/drivers/bus/fsl-mc/dprc-driver.c index 4c84be378bf2..ef4f43f67b80 100644 --- a/drivers/bus/fsl-mc/dprc-driver.c +++ b/drivers/bus/fsl-mc/dprc-driver.c @@ -839,11 +839,10 @@ static int dprc_remove(struct fsl_mc_device *mc_dev) { struct fsl_mc_bus *mc_bus = to_fsl_mc_bus(mc_dev); - if (!is_fsl_mc_bus_dprc(mc_dev)) - return -EINVAL; - - if (!mc_bus->irq_resources) - return -EINVAL; + if (!mc_bus->irq_resources) { + dev_err(&mc_dev->dev, "No irq resources, so unbinding the device failed\n"); + return 0; + } if (dev_get_msi_domain(&mc_dev->dev)) dprc_teardown_irq(mc_dev);