From patchwork Fri Mar 10 22:41:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 67833 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp10087wrd; Fri, 10 Mar 2023 14:55:55 -0800 (PST) X-Google-Smtp-Source: AK7set/UzHF366LzrlmqaceBu7/rA7N+FgFufJ3XcP0CiYo9QILzd4DeMvQB97A0ExW40BV1Q2qg X-Received: by 2002:a05:6a20:8416:b0:b8:499d:7c9b with SMTP id c22-20020a056a20841600b000b8499d7c9bmr33433500pzd.51.1678488955037; Fri, 10 Mar 2023 14:55:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678488955; cv=none; d=google.com; s=arc-20160816; b=Njk85JRtanSPkopTk3rveLP9QhWS5dtOOhwDi7IFe7CxkW9fPJiJTZ/6OpIKC2XEk7 7pc6LAP6rCF3XaHxX40zkX+OF2l+L2pa/ekkEmD9+TInoUcQGBUolv43n6ubqQR+CRof F1/YuYLUcEEtdgWEN4RhpSOwQA6xkC0+uQHRI1dD+BQ6tdlZogRJN46j7CLYlrbrFb5U 9wxpc6BW92Ag7Rd2xat8wG5YTa1QzKuzGeYmaFt0ztEtBSPHRJxS7KG6jY8POwOC0nkY AseRu0yLcOg4XvLzGZTBwSV+k12i9OIJ0lO9Q8xJ8qUAmrT5NHYj7ViNhk29LZtH/YEC AvGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ev/yFEYhFKsMSdA8Uu/x7AxJCljFTv/aBx5MCXxYK7o=; b=k9cUOo/HBVlFxv/gKBPr/cAn+qR+qBcgTxbXCLBmgMQbB3kbvhLwk/2aLK6x9UgXp/ hbFfuq3gnsf2CS8eQEHoCem0PVjOzpa33NEKT6yvcbzM5ma79AeNtCEEVtSi7E+u8XH3 TCNanmSCJo9qIZiEqnZntXpetjrTiTj7atMK5Y5E4tNNOe/PktIVTS52wf1z17JsNcJF uuN2/r7cSpjbPyjv0REwuIvYdfAi/ZIgcmUYYil5B9ZKQzt4ZpVgOk4OFyuLyhHDgqE6 6gZdts7qU4/S7LKTySR9Na9cwU5XeA8P0ZO27oaM0qnLgkH9ql7kgWDJQn9kXGUhGeNr 7v7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w69-20020a638248000000b005074d06d833si803941pgd.427.2023.03.10.14.55.31; Fri, 10 Mar 2023 14:55:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231473AbjCJWmg (ORCPT + 99 others); Fri, 10 Mar 2023 17:42:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231830AbjCJWmI (ORCPT ); Fri, 10 Mar 2023 17:42:08 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFDE314D083 for ; Fri, 10 Mar 2023 14:41:43 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1palQg-0002dA-Ci; Fri, 10 Mar 2023 23:41:38 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1palQe-003GqK-PW; Fri, 10 Mar 2023 23:41:36 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1palQd-003uEV-Tw; Fri, 10 Mar 2023 23:41:35 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Stuart Yoder , Laurentiu Tudor Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] bus: fsl-mc: Only warn once about errors on device unbind Date: Fri, 10 Mar 2023 23:41:23 +0100 Message-Id: <20230310224128.2638078-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230310224128.2638078-1-u.kleine-koenig@pengutronix.de> References: <20230310224128.2638078-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=959; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=soyW7qTmvLYZjqko2bU9Wwukx4vz+pHXyLiUEo5BE/k=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkC7ICu4CcOxQg/SDY7ITR2qMbSiRlYm+mW1eYT 2LMemXdmyCJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAuyAgAKCRDB/BR4rcrs CTO4CACB4/9hoCCFS63udqPEt25X5YNtEcx6g17uulRdRr3YvP0UrswrzXQcFDuua+LWWn3jbt0 95PWumPSIH+HoznhsoXg4e5CWtEPRR9oM00ZSR5M5R6+HONbarn/jiE1eGrGK06hrOiKrXp2HQG DdWhR/qEGVjxNZmAw+cm3eS+4tiex/oIN+TgD3BZMS+iZMJI9wp4UN/Nx+IYFWLUp9Yfpl4IbxL PpFV3rzLosWHSubLoWl7WZWwhMku4s8cxeRduT00Dp3X5lEmPYkYW3ryh/aMlQeNsV/9hhQ7vAo tzihQ5oJECMj5dnRkfvBR37bT0n/BGO3saVBnptKAKFDqXot X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760023234726687008?= X-GMAIL-MSGID: =?utf-8?q?1760023234726687008?= If a platform driver's remove function returns an error code, this results in a (generic and little helpful) error message. Otherwise the value is ignored. As fsl_mc_driver_remove() already emit an error message, return 0 also in the error case. The only effect is to suppress the device core's error message. Signed-off-by: Uwe Kleine-König --- drivers/bus/fsl-mc/fsl-mc-bus.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c index 36cb091a33b4..1531e6101fb1 100644 --- a/drivers/bus/fsl-mc/fsl-mc-bus.c +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c @@ -457,10 +457,8 @@ static int fsl_mc_driver_remove(struct device *dev) int error; error = mc_drv->remove(mc_dev); - if (error < 0) { + if (error < 0) dev_err(dev, "%s failed: %d\n", __func__, error); - return error; - } return 0; }