diff mbox series

[1/6] bus: fsl-mc: Only warn once about errors on device unbind

Message ID 20230310224128.2638078-2-u.kleine-koenig@pengutronix.de
State New
Headers
Series bus: fsl-mc: Make remove function return void |

Commit Message

Uwe Kleine-König March 10, 2023, 10:41 p.m. UTC 
  If a platform driver's remove function returns an error code, this
results in a (generic and little helpful) error message. Otherwise the
value is ignored.

As fsl_mc_driver_remove() already emit an error message, return 0 also
in the error case. The only effect is to suppress the device core's
error message.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/bus/fsl-mc/fsl-mc-bus.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c
index 36cb091a33b4..1531e6101fb1 100644
--- a/drivers/bus/fsl-mc/fsl-mc-bus.c
+++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
@@ -457,10 +457,8 @@  static int fsl_mc_driver_remove(struct device *dev)
 	int error;
 
 	error = mc_drv->remove(mc_dev);
-	if (error < 0) {
+	if (error < 0)
 		dev_err(dev, "%s failed: %d\n", __func__, error);
-		return error;
-	}
 
 	return 0;
 }