From patchwork Fri Mar 10 21:46:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 67787 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1019wrd; Fri, 10 Mar 2023 14:30:35 -0800 (PST) X-Google-Smtp-Source: AK7set9hWhZ9NgTAX3+qOBzp3GfKg81ki9Ko/YZP7D4fCicwJhc0uX2XCVtpknD52owrVtGYk30x X-Received: by 2002:a05:6a20:3954:b0:cb:af96:ace7 with SMTP id r20-20020a056a20395400b000cbaf96ace7mr32474595pzg.46.1678487435666; Fri, 10 Mar 2023 14:30:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678487435; cv=none; d=google.com; s=arc-20160816; b=N4UgArK1VmGw+FD4fEkXvCk9zIw8OzcYz84qgsz+g7U0EJ58TbcXJCoBNdH6ZBnPz7 rEZkRyT+jpYdY9GVtONTO4p1qL3xyeP2Pz2+M1Rbnf6aY3o8BLgXlJ/azniiOBG+eN8P 4vgCWcQSY24zgfSMh0MfvY4JSedg9Tx5ZOXRYx3uCarf7d4nAY5indJbF4YssotyGX79 0w57JQueu7AGSJ3zI3S9iZCHKVVpet5kiDdkbOxnDS9WVE/pQ7CQ9MZJ9vB48cVrbeRL Dz+r99ySl3b3ZXl6Wjj4Jfk/NQo1nqjAG0C9IPeGPhCsFkj4w0oRevw3VVirAIUsOQGR HvtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mUBJvPnvYIjkmn4O8oZhEpaIiBhxp2RHHJ3TqWmbT9w=; b=yi0GB7LIg330p/gEXwRczBWq7RJ3B3KFzyl6jIvThQFra000K7cn0u9A4xeh4n2V2Z 8b8L0Wdrv9PUQKe11OyuVXnN8Q9n2KVaPCivKgU52sx35mcOeBvAfOQp0NMM0s1PEdZp uu9ZIPFjhHlQFV4o7R/TWe17D17ZCM+4lDkMQaJrwK24O4Y3uLsfVaBcrHafaGf6Vn0E l3tg0m2KKw+/95XKhtfZAKyRXPtbw2ubS3GfnNkaWgFuF2spY7T0UOKf8VzajAg3SzzR JKxmn5PKfczeYmai3iCFH/SoxARIRmXqNfPgx7tEYwbrGWJBF/ujloOO1g+JlQw/L+jJ r8DQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J+Tq6OtM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r203-20020a632bd4000000b004fabddccf93si736470pgr.778.2023.03.10.14.30.20; Fri, 10 Mar 2023 14:30:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J+Tq6OtM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232081AbjCJWBt (ORCPT + 99 others); Fri, 10 Mar 2023 17:01:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231597AbjCJWBW (ORCPT ); Fri, 10 Mar 2023 17:01:22 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F7ED13DE3 for ; Fri, 10 Mar 2023 13:58:03 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id ec29so26209132edb.6 for ; Fri, 10 Mar 2023 13:58:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678485481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mUBJvPnvYIjkmn4O8oZhEpaIiBhxp2RHHJ3TqWmbT9w=; b=J+Tq6OtM2ajO1NaR/jxu5zDmCfSVtNjAnVcHz/HABr9CpaZY6AXEkMgBqfYwT84EX7 4fqBbPlLJkL/0MH3bW5xl31CHs1w384PvsCfSGn6hKnG6M9baY3ywLvUboU85PCQfzHV UEOVEcvH98EZvfEbotsICjjOKVi39e5bBjN3nliWLPEjv/SV8G5fS8jTi4NH3HRIeSps 2Nb2wvyUbuf5I1GvmboQsL4g63JQvttMkRoJ0auSDKF9wKO7yQiY5Qb/AnSHHzviXE/X XJW21hH0BlT6yvOcT6roEP1tpBuM0JdeS3sR4ZYqUSlQK37ZKAjd6YAjQB7o72WAnZ7d 5GNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678485481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mUBJvPnvYIjkmn4O8oZhEpaIiBhxp2RHHJ3TqWmbT9w=; b=kK70Id73qb6bkn1faB3j8/8mB5p1TS2lx4mAxbHjEBc/eo/Qho2sUgnheFr+lPhZOA AHRwoLdvuh2Tpp2QqVQUeZEHxSP1+ktLoUo+O04Zx+UYF1DegPE7kqY5CmHrqSAurzw7 FY+aZ6cq+QLWhqGl4W7IVA1cYLxTxggxoKgATeDn2+V4eBjs+steTLL/sFy+S6hkNQKf icnrlQOnnctHapLR0oGohHTEI1IT4WXB9IF1oP/C43L8W4f4wQLTxCA2r0+3POO7Adpp f24O4cgBKOS0ARby8n8Zqv6jkJzTECanoeIgal6KPgfnHk5kYGu0fNrgk8e7dLIKERBK fM0Q== X-Gm-Message-State: AO0yUKURu7eN4mxWcwYLkB9diFbM4HqiYDps8xWvJYbetSD4ZoeJVJYW FjC3cpr0u70bfMw0QLqQfNBucXio9o5wRIMWvi8= X-Received: by 2002:a05:6402:1854:b0:4ac:b614:dd00 with SMTP id v20-20020a056402185400b004acb614dd00mr22252359edy.30.1678484804740; Fri, 10 Mar 2023 13:46:44 -0800 (PST) Received: from krzk-bin.. ([2a02:810d:15c0:828:34:52e3:a77e:cac5]) by smtp.gmail.com with ESMTPSA id t5-20020a50ab45000000b004bf7905559asm488088edc.44.2023.03.10.13.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 13:46:44 -0800 (PST) From: Krzysztof Kozlowski To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Byungho An , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Vinod Koul , Bhupesh Sharma , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/5] net: stmmac: generic: drop of_match_ptr for ID table Date: Fri, 10 Mar 2023 22:46:29 +0100 Message-Id: <20230310214632.275648-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230310214632.275648-1-krzysztof.kozlowski@linaro.org> References: <20230310214632.275648-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760021641380466932?= X-GMAIL-MSGID: =?utf-8?q?1760021641380466932?= The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it is not relevant here). drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c:72:34: error: ‘dwmac_generic_match’ defined but not used [-Werror=unused-const-variable=] Signed-off-by: Krzysztof Kozlowski Reviewed-by: Simon Horman --- drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c index 5e731a72cce8..ef8f3a940938 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c @@ -91,7 +91,7 @@ static struct platform_driver dwmac_generic_driver = { .driver = { .name = STMMAC_RESOURCE_NAME, .pm = &stmmac_pltfr_pm_ops, - .of_match_table = of_match_ptr(dwmac_generic_match), + .of_match_table = dwmac_generic_match, }, }; module_platform_driver(dwmac_generic_driver);