From patchwork Fri Mar 10 16:45:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 67580 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp988144wrd; Fri, 10 Mar 2023 09:06:43 -0800 (PST) X-Google-Smtp-Source: AK7set9zf8QlMWNpZxrB8yFk63F56Hk28yg0BnKqQs3Wk3h003pvH/p/TcGFe58XyQTOXXylOwQe X-Received: by 2002:a6b:ef11:0:b0:719:62d5:ed6c with SMTP id k17-20020a6bef11000000b0071962d5ed6cmr15565946ioh.18.1678468003252; Fri, 10 Mar 2023 09:06:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678468003; cv=none; d=google.com; s=arc-20160816; b=CrCwRR19HhUI9c1ouoCM6cXgMSwe1zg4dY2HBGHiNG8q8/P2K4eu63CW0WjFXg9REV od8/HNGALoYN1BQVGO/2Pylc+uS3hZHfU57odcFPbl6He9bFBt+k1jjIrwBabXdrp6JX Bvyv5t4pJtdmz0e35Nf6mrriYjTIEqJYVrVHdqUIWS5rtzg9ln1nxCQrjcJkCzmxi+gq Iy6pORLG7bD9kk7R8xXomB16hmgAFRSvo2iVoM7gm3OD6nKgW0sbYj/0/hU0g3REAkxw RcM/MwDpwePesyioMlHuTU5sy1FcoK/IGwVoT8weaSWoHRyNwJS8TAUUdRigypw6DIb1 WfxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=lhvnUhHloGr5Xxit+TxcTgtZ5guwb4bVCQWHwTvqR8o=; b=qexRlKfet4XS+kpT7q+bXFgNyOTz7Ornj9L0sGAUQaPsQgFeJv2Pt8p9y7n9RE7cYT SgxlbjtqiJtJE8R0T1kc1kxyWxAX8djxPsia+Xow6ZnR3Nie6pTyRfpuWejEKQ/G3ayx 3t2F+n875wXKvRNF7L2ZRkfARqj8QWdjFRq89seNhLW9SBP+OCr8Whu5hAfa8iKu2caV VjtrY/84/WM0UuNbeotZ+KRBj+KqaZEc1s/sEuJgeImsIkcV9iqXCPYaA1t2KTVgb6nG reAcxRsuts60uD+dkdJad9nmTIzO2Ec4NPDLm8U7X2JJZpo6Y5c6S0kqpM5XrUws3VDD Wz9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="UvbRx/Wd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v2-20020a6b5b02000000b0074c979db4afsi262491ioh.8.2023.03.10.09.06.28; Fri, 10 Mar 2023 09:06:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="UvbRx/Wd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231567AbjCJQu5 (ORCPT + 99 others); Fri, 10 Mar 2023 11:50:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231563AbjCJQuX (ORCPT ); Fri, 10 Mar 2023 11:50:23 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97C42119400; Fri, 10 Mar 2023 08:47:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678466849; x=1710002849; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=eyTEBx+P5LFmDblqHINk1Ff4ftWqw30rcM/wV51VRd4=; b=UvbRx/WdYp6JasE1wIiwTMgyaQUxPg8wXJb4B71+iMjWBCL56TACvZgE KYWj9XWnX2BQu7xpkv5+UmaNfvA9IiHybuqpbTrC+J+D9A25eHWs2YANa NiK6kAsCVkav1+BJpc6/ZNkgx5K7guUTEjxF5flQwfKRE4MgD9bhke6aI 9dHMZHRSSGUjyomPqb7Oc5r3tm5jNhFx+yOyBdQHQRsUsr2TO5iSaoqBg 0S2K6Yf6kkAolGjnJ4mTMe2cTem7LErjGAcx295nFs6NAfjaT5i6NmXwD d/2Eap9h4t/jaAxzyzjgfWRxB6bGL/iQjwPcghc0AD54Ms6OYp+4kl36R w==; X-IronPort-AV: E=McAfee;i="6500,9779,10645"; a="320621147" X-IronPort-AV: E=Sophos;i="5.98,250,1673942400"; d="scan'208";a="320621147" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2023 08:45:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10645"; a="677874311" X-IronPort-AV: E=Sophos;i="5.98,250,1673942400"; d="scan'208";a="677874311" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 10 Mar 2023 08:45:11 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 46BBC367; Fri, 10 Mar 2023 18:45:53 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Jens Axboe , Greg Kroah-Hartman , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/9] pktcdvd: Use DEFINE_SHOW_ATTRIBUTE() to simplify code Date: Fri, 10 Mar 2023 18:45:46 +0200 Message-Id: <20230310164549.22133-7-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230310164549.22133-1-andriy.shevchenko@linux.intel.com> References: <20230310164549.22133-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760001265003036351?= X-GMAIL-MSGID: =?utf-8?q?1760001265003036351?= Use DEFINE_SHOW_ATTRIBUTE() helper macro to simplify the code. No functional change. Signed-off-by: Andy Shevchenko Reviewed-by: Greg Kroah-Hartman --- drivers/block/pktcdvd.c | 23 +++-------------------- 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index a53d21dbf2ab..2c5441303e55 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -504,24 +504,7 @@ static int pkt_seq_show(struct seq_file *m, void *p) pd->write_congestion_on); return 0; } - -static int pkt_debugfs_seq_show(struct seq_file *m, void *p) -{ - return pkt_seq_show(m, p); -} - -static int pkt_debugfs_fops_open(struct inode *inode, struct file *file) -{ - return single_open(file, pkt_debugfs_seq_show, inode->i_private); -} - -static const struct file_operations debug_fops = { - .open = pkt_debugfs_fops_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, - .owner = THIS_MODULE, -}; +DEFINE_SHOW_ATTRIBUTE(pkt_seq); static void pkt_debugfs_dev_new(struct pktcdvd_device *pd) { @@ -531,8 +514,8 @@ static void pkt_debugfs_dev_new(struct pktcdvd_device *pd) if (!pd->dfs_d_root) return; - pd->dfs_f_info = debugfs_create_file("info", 0444, - pd->dfs_d_root, pd, &debug_fops); + pd->dfs_f_info = debugfs_create_file("info", 0444, pd->dfs_d_root, + pd, &pkt_seq_fops); } static void pkt_debugfs_dev_remove(struct pktcdvd_device *pd)