From patchwork Fri Mar 10 16:45:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 67581 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp988553wrd; Fri, 10 Mar 2023 09:07:17 -0800 (PST) X-Google-Smtp-Source: AK7set+m0p0T1T36E+Ki62RuumW7Q5u6kpnVDgLGprFH4LKBg3WSiaOXyBUE//3iJGIKD2vEqOCr X-Received: by 2002:a17:902:d506:b0:19e:2717:3de9 with SMTP id b6-20020a170902d50600b0019e27173de9mr32715735plg.52.1678468037018; Fri, 10 Mar 2023 09:07:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678468037; cv=none; d=google.com; s=arc-20160816; b=xMVDgInMSK9eUSiOIZijrRuL6kp4seo6nBPnDF6JfAKaO3uZQ4fyYmf/ogv1KlCMNL DjbfN4RPAllV5EORcdhObsn2Tn7EUTfOwiEQUA9wqpNcg8vWQ/l+JT3CdChHAUG1EOhQ ioa4s0YlLiKGK5BM+yRJPVtM8FhOk5PXB89f7Dfm8SQ2qFQAU85zJrcATXwRWayfQsau VBuLh9/5QsL4KLoYi3AvpnQHOG5MF+V6pabPm85LcPHJKEav9TyhJs7RRlPdW/JQFh1y Aqo6NnrShZuKnFcP8UShwgIFp/3htqbmfRFpWCrlbQ/OVVZmRUN+eJiSPZshpMVF05pE O0LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=DWzVKXmAXMnrU+W70oZ9l8hG2MXrF6hGiOSi4M6prYA=; b=Cerl63jZd1lcQGpBjAUWjY7ClDXVsNSFXpECWAFshM7JCTjuUw0K5jXjt8Adw8+xpJ MxzZnIuNZGzIkDKJkIwt8prcLIOAyGTrlO/To+KmSjTNZjueOpFLYPrnDZRUaLzA5oTL AzkHu/mPCpYAITaxNSJmNzpB/dGfnI7XaPzlTNjarTbGD3YlLZAxFiKZUGqAg3rwHRiy ZTg01PXG6ZA/bgqvaey3mILOtyemAo0ZR5+eVVqcmUeA72OyXtjU4PzjHyuXbhV1w5t9 KURIxEXnek62aHwxDPg0MzBBhluyOieImKT0iNVgbqonwM1le6v0xn295wuRzUMIqrZh uG3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=U5EmXpjl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c17-20020a170902d49100b0019c92ca0d05si388384plg.340.2023.03.10.09.07.00; Fri, 10 Mar 2023 09:07:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=U5EmXpjl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231638AbjCJQux (ORCPT + 99 others); Fri, 10 Mar 2023 11:50:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231567AbjCJQuX (ORCPT ); Fri, 10 Mar 2023 11:50:23 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98F25119FBC; Fri, 10 Mar 2023 08:47:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678466849; x=1710002849; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=P+cQavtHY/atkpwjlQlWntsoa6QJUnXRT+Gt23ep0Ww=; b=U5EmXpjlHG/y/fH3YBzhKZzG5Z3JbUlVvBCg+UXhU21WFuFhQELNaIZq vSAmKCdr4schqYC79A7b40AzUC0RblE9rDZ5949THcLvTqyb4lAM5TlSD gnHPjp/2TEIY+dBw0fcbWytahqrd7Lsxh1cy3CVyFy9omp+mt5loPEGmv bKH2iIpJqeoVPWPtt55WgLvjxZgkwM+BiY9zfBig+7lTtxVoFvITaKaoV QgiBIkorFLoSWmNSZsE77P14PeUn+rF6/ectolpXTx6Zf2dCuxoZ/a0Ph avDujkhd2dyr0NWBckzmRldSSkjDHgsYfKIotgIlgen4Sa7EWAnzzGdsg A==; X-IronPort-AV: E=McAfee;i="6500,9779,10645"; a="320621121" X-IronPort-AV: E=Sophos;i="5.98,250,1673942400"; d="scan'208";a="320621121" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2023 08:45:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10645"; a="746778621" X-IronPort-AV: E=Sophos;i="5.98,250,1673942400"; d="scan'208";a="746778621" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 10 Mar 2023 08:45:08 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2BF7C354; Fri, 10 Mar 2023 18:45:53 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Jens Axboe , Greg Kroah-Hartman , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/9] pktcdvd: use sysfs_emit() to instead of scnprintf() Date: Fri, 10 Mar 2023 18:45:43 +0200 Message-Id: <20230310164549.22133-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230310164549.22133-1-andriy.shevchenko@linux.intel.com> References: <20230310164549.22133-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760001300458897313?= X-GMAIL-MSGID: =?utf-8?q?1760001300458897313?= Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Andy Shevchenko Reviewed-by: Greg Kroah-Hartman --- drivers/block/pktcdvd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index ad4336ae9927..98a5c388eabf 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -339,7 +339,7 @@ static ssize_t device_map_show(struct class *c, struct class_attribute *attr, struct pktcdvd_device *pd = pkt_devs[idx]; if (!pd) continue; - n += sprintf(data+n, "%s %u:%u %u:%u\n", + n += sysfs_emit_at(data, n, "%s %u:%u %u:%u\n", pd->disk->disk_name, MAJOR(pd->pkt_dev), MINOR(pd->pkt_dev), MAJOR(pd->bdev->bd_dev),