From patchwork Fri Mar 10 14:47:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 67417 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp914530wrd; Fri, 10 Mar 2023 06:49:45 -0800 (PST) X-Google-Smtp-Source: AK7set9bPV0nFWc50x+QXi3VN9Ch7YlZH1pdlQBxzxUj7sD/3Jxip9dDSrNb+G8CUk4LjeRRmX8P X-Received: by 2002:a17:902:ccc9:b0:19e:874b:470 with SMTP id z9-20020a170902ccc900b0019e874b0470mr26594307ple.46.1678459785242; Fri, 10 Mar 2023 06:49:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678459785; cv=none; d=google.com; s=arc-20160816; b=FMXytFVwz38ImUHTaFXN2scUzt4k0+ZqdHXu0h+f7eq3fN65ZiwM1MJEG4Kcdn6eCq GtXWhCNBOabHGLh4Hv7YhEn9FQQAigixa+V0kOdDDuG9zlXsoRayGiEMEmphZXOkKfGi B6yUD+yxWaq8H9sTeKiu04PLhyaLD6ZFbnSYSDn9qjNsOE3AUGT2gXf7upQacfDITmeR wiCmCEEgeJMwBSX3DZ7yL6S++msd+W3jAl91gwHMuqC7za+Az2SVJZu1Cc4J+zJ8O877 rgGR7ukYmVY8k/yBsDduyeMsdC7Nyt47zr1HUSg/hTwcwFqDwdP0985WCq1/zzQ5mEuQ 1hGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=vOScINdVt5AO68Lh+/aSSo0LSJcWlj/v+OQKQopbrfE=; b=zg6XnJE4SOEbr1CAZJ+CfKGqIvVDXCTd3BeDdRNYVu+GpOayFHDWDWxb+JzuRNoyUK gPBzCDHzoneQeZVfSei+HA8EDyryGTx7t9giK/vRIVWgVhTfuquZalImPktplUfcAC+J K0fQTqHIlArIFC47uUFZCKruUrATINwLR9K0fy6ksfTHht9LO7gYaWSRg29SsCrXC1/p SmSQBQIUy4W2a3GrCJ0pZZgz2iofmT5HQnEXRx+8VRpSSw33068SX3zl7mrP5+7311AM MhmcSYG5030ClhKZTDMnC3KYdh77fKpSvfbzW3LTYwIl2Cgat7q3kC5SIIGxalh6hTbe Tfng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g7-20020a170902740700b0019ab44c2168si135406pll.382.2023.03.10.06.49.28; Fri, 10 Mar 2023 06:49:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233016AbjCJOsk (ORCPT + 99 others); Fri, 10 Mar 2023 09:48:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233046AbjCJOrf (ORCPT ); Fri, 10 Mar 2023 09:47:35 -0500 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D02412115C; Fri, 10 Mar 2023 06:47:19 -0800 (PST) Received: by mail-oi1-f172.google.com with SMTP id y184so4386047oiy.8; Fri, 10 Mar 2023 06:47:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678459635; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vOScINdVt5AO68Lh+/aSSo0LSJcWlj/v+OQKQopbrfE=; b=eolFuhBLjUSLjh4iH9KotyuBJTqQza0Ns9lw0nM5K0kS70QydcjOAOdONGKCf+NkVn amz7/eJhBRQMQpo+P5c8GayjcFdkAs+CnNu3IJ7EM4J1imFDx5fUKhFtt4T/KWYtN7V8 W67e9+BfNrh83/dWcyHjjLnGMSyaxVFQIviMBfHyP7Nkr9Kgj59VduVRw1YWTztfv002 BfBg3bTzsOPA/fdPUDrwFJ7puEgHWdvaHyHurkWU87PQKPBoVg8n2GGFXWbgDO4drash z43HG9iEzNiIKKORzs+ylVh9jtk59mYB9ub6fJR8WOnQRDFvikoh4p48jVg9GhyyXhl1 0qDg== X-Gm-Message-State: AO0yUKVcSoe+pQ6iYwHeI29T6JqbtXypSXx0dBOYKmhCZo/yaqOYOW3v XPu9z3avjgBNeuAtf6zf8HzyJw8/WA== X-Received: by 2002:a05:6808:8f1:b0:384:349a:15d0 with SMTP id d17-20020a05680808f100b00384349a15d0mr3352325oic.38.1678459634837; Fri, 10 Mar 2023 06:47:14 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id q194-20020a4a33cb000000b00517fc5fdf5bsm801303ooq.17.2023.03.10.06.47.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 06:47:14 -0800 (PST) Received: (nullmailer pid 1541776 invoked by uid 1000); Fri, 10 Mar 2023 14:47:02 -0000 From: Rob Herring To: "Rafael J. Wysocki" , Viresh Kumar , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sudeep Holla , Cristian Marussi , Thierry Reding , Jonathan Hunter Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: [PATCH] cpufreq: Use of_property_present() for testing DT property presence Date: Fri, 10 Mar 2023 08:47:02 -0600 Message-Id: <20230310144702.1541730-1-robh@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759992648062706381?= X-GMAIL-MSGID: =?utf-8?q?1759992648062706381?= It is preferred to use typed property access functions (i.e. of_property_read_ functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more. Signed-off-by: Rob Herring --- drivers/cpufreq/cpufreq-dt-platdev.c | 2 +- drivers/cpufreq/imx-cpufreq-dt.c | 2 +- drivers/cpufreq/imx6q-cpufreq.c | 4 ++-- drivers/cpufreq/scmi-cpufreq.c | 2 +- drivers/cpufreq/tegra20-cpufreq.c | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c index e85703651098..5ac6b9e5270e 100644 --- a/drivers/cpufreq/cpufreq-dt-platdev.c +++ b/drivers/cpufreq/cpufreq-dt-platdev.c @@ -179,7 +179,7 @@ static bool __init cpu0_node_has_opp_v2_prop(void) struct device_node *np = of_cpu_device_node_get(0); bool ret = false; - if (of_get_property(np, "operating-points-v2", NULL)) + if (of_property_present(np, "operating-points-v2")) ret = true; of_node_put(np); diff --git a/drivers/cpufreq/imx-cpufreq-dt.c b/drivers/cpufreq/imx-cpufreq-dt.c index 76e553af2071..535867a7dfdd 100644 --- a/drivers/cpufreq/imx-cpufreq-dt.c +++ b/drivers/cpufreq/imx-cpufreq-dt.c @@ -89,7 +89,7 @@ static int imx_cpufreq_dt_probe(struct platform_device *pdev) cpu_dev = get_cpu_device(0); - if (!of_find_property(cpu_dev->of_node, "cpu-supply", NULL)) + if (!of_property_present(cpu_dev->of_node, "cpu-supply")) return -ENODEV; if (of_machine_is_compatible("fsl,imx7ulp")) { diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c index ad4ce8493144..48e1772e98fd 100644 --- a/drivers/cpufreq/imx6q-cpufreq.c +++ b/drivers/cpufreq/imx6q-cpufreq.c @@ -222,7 +222,7 @@ static int imx6q_opp_check_speed_grading(struct device *dev) u32 val; int ret; - if (of_find_property(dev->of_node, "nvmem-cells", NULL)) { + if (of_property_present(dev->of_node, "nvmem-cells")) { ret = nvmem_cell_read_u32(dev, "speed_grade", &val); if (ret) return ret; @@ -279,7 +279,7 @@ static int imx6ul_opp_check_speed_grading(struct device *dev) u32 val; int ret = 0; - if (of_find_property(dev->of_node, "nvmem-cells", NULL)) { + if (of_property_present(dev->of_node, "nvmem-cells")) { ret = nvmem_cell_read_u32(dev, "speed_grade", &val); if (ret) return ret; diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index 513a071845c2..f34e6382a4c5 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -310,7 +310,7 @@ static int scmi_cpufreq_probe(struct scmi_device *sdev) #ifdef CONFIG_COMMON_CLK /* dummy clock provider as needed by OPP if clocks property is used */ - if (of_find_property(dev->of_node, "#clock-cells", NULL)) + if (of_property_present(dev->of_node, "#clock-cells")) devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, NULL); #endif diff --git a/drivers/cpufreq/tegra20-cpufreq.c b/drivers/cpufreq/tegra20-cpufreq.c index ab7ac7df9e62..dfd2de4f8e07 100644 --- a/drivers/cpufreq/tegra20-cpufreq.c +++ b/drivers/cpufreq/tegra20-cpufreq.c @@ -25,7 +25,7 @@ static bool cpu0_node_has_opp_v2_prop(void) struct device_node *np = of_cpu_device_node_get(0); bool ret = false; - if (of_get_property(np, "operating-points-v2", NULL)) + if (of_property_present(np, "operating-points-v2")) ret = true; of_node_put(np);