From patchwork Fri Mar 10 14:47:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 67506 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp952459wrd; Fri, 10 Mar 2023 08:01:55 -0800 (PST) X-Google-Smtp-Source: AK7set+fSYolQm4H4ebHuzWg+q1vq8Eid6RA0givWRCfgAQLfR+gIuvNVH+WzXBImsoCSmS7rpYv X-Received: by 2002:a05:6a20:3116:b0:c6:c85f:da5b with SMTP id 22-20020a056a20311600b000c6c85fda5bmr23584944pzf.55.1678464115120; Fri, 10 Mar 2023 08:01:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678464115; cv=none; d=google.com; s=arc-20160816; b=ypHCTMZt7wLP3gI7xsvmGKzhOnHkLKc0/nmNG3Lhpz+gK+Xow1YeQtjqSVhXVXC6jP tXRRTdJZhZ5kxgeb0qEMrU+pQZBB/kQA3C33Rolty6d0NJAlfSVcePXgLqztqtE6PIgX AnlBWCsm9yS+98B5BveWSdj2votjyYmgFEO+O4x9FP8vF/0kjEaVor5S8GSd00owSNQ7 n9DqZE35rYa1kiGDFeyMqyUQD25P2dE3hJc8RwS+jukZhysv0597e5mus7dgCzcjGX7E mHq0nYqdgWe1Oa3Zfb+BRpZZFSplL4shvJsT0ZgbQCk/prKfgqY+M3+zplMllyAhO5QT X2oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=HLqzD8+2CF/pIUdlHHjjrK7T/hMwbjXYhuFmb1oAmEA=; b=DSeS2rFArPajdxHCLC57K4U25yk1TWU3mAP7kV70LgiHTLaOHrLOg2XyC5vgft3nje oNPoLuCAwVjPavs2nhsLkpcLHBOCEaD+HUuO2aESY9JY3Z6aAnadL5OP57u3PXmAomIi LmOlWtefxUfcPd0Y8OCGSae/SmTNrekCP8/v4UR1RuJ6sIz60Ca2sk1sWk2Y4O6wjTT1 91QQeAY8DTsCZSg7NWJUZyK5SCLAieuv3ICj/ljY903waF5nbOdSyTdYLL13ifVTrYAG x587IlOJSWdx+fhvvfbVxscrVVV76vGhUjkj+og2NKjQEdcxhsBt71rH3Qtw+aFOSNO+ 26dQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 187-20020a6306c4000000b00502f48d80b6si100546pgg.645.2023.03.10.08.01.39; Fri, 10 Mar 2023 08:01:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232893AbjCJOsY (ORCPT + 99 others); Fri, 10 Mar 2023 09:48:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232983AbjCJOrc (ORCPT ); Fri, 10 Mar 2023 09:47:32 -0500 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E47E812115F; Fri, 10 Mar 2023 06:47:15 -0800 (PST) Received: by mail-oi1-f175.google.com with SMTP id bp19so4405843oib.4; Fri, 10 Mar 2023 06:47:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678459632; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HLqzD8+2CF/pIUdlHHjjrK7T/hMwbjXYhuFmb1oAmEA=; b=ggfOf9TUe/BXTPpUQ4T3LmlzGanGvSDcTdTSRRRu3ogPIT9V8ndT0GgA6pF7Vdq6qm +d7xdE+HktoAkLPxsDQW9IMj6RK7Xp8bwh4zWsOcQa58lzQl7A/lD4jvyTNdsolWWNZh EegtDMYlYQ9I64V1WAXtOHCKqKASvdxIuFjE+TbkEEhHuxylzyJtc9hLLuNDjgk6ZY3q FmT0PJ0Unr5N29vqWxOK2g2uPEfaUhIh+ZPbBjhULOo3VDLdQMHzVOQR3VKdWIvbQLVA r7RSIjRHeurYtuyW2Drj+rOve7M8pU7JloS4c2p+bTvXd7PyfpskIQUi9HAO0tUNlPUY fhlA== X-Gm-Message-State: AO0yUKXV4NeUx+8TXwMV/8rMvY2NUbpIxuRh6AQdapzXorUBCnkOkEt4 yjZec97p/3euPGTll4vCnw== X-Received: by 2002:aca:2204:0:b0:35e:d286:232b with SMTP id b4-20020aca2204000000b0035ed286232bmr11451371oic.10.1678459632180; Fri, 10 Mar 2023 06:47:12 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id e184-20020acab5c1000000b003847ca255fasm972035oif.30.2023.03.10.06.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 06:47:11 -0800 (PST) Received: (nullmailer pid 1541530 invoked by uid 1000); Fri, 10 Mar 2023 14:47:01 -0000 From: Rob Herring To: Michael Turquette , Stephen Boyd , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] clk: Use of_property_present() for testing DT property presence Date: Fri, 10 Mar 2023 08:47:01 -0600 Message-Id: <20230310144701.1541504-1-robh@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759997187759207887?= X-GMAIL-MSGID: =?utf-8?q?1759997187759207887?= It is preferred to use typed property access functions (i.e. of_property_read_ functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more. Signed-off-by: Rob Herring Acked-by: Chunyan Zhang --- drivers/clk/clk.c | 4 ++-- drivers/clk/sprd/common.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index ae07685c7588..f7528d7f8256 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -4880,8 +4880,8 @@ static struct device_node *get_clk_provider_node(struct device *dev) np = dev->of_node; parent_np = dev->parent ? dev->parent->of_node : NULL; - if (!of_find_property(np, "#clock-cells", NULL)) - if (of_find_property(parent_np, "#clock-cells", NULL)) + if (!of_property_present(np, "#clock-cells")) + if (of_property_present(parent_np, "#clock-cells")) np = parent_np; return np; diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c index ce81e4087a8f..1a3795a61f81 100644 --- a/drivers/clk/sprd/common.c +++ b/drivers/clk/sprd/common.c @@ -44,7 +44,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev, struct device_node *node = dev->of_node, *np; struct regmap *regmap; - if (of_find_property(node, "sprd,syscon", NULL)) { + if (of_property_present(node, "sprd,syscon")) { regmap = syscon_regmap_lookup_by_phandle(node, "sprd,syscon"); if (IS_ERR(regmap)) { pr_err("%s: failed to get syscon regmap\n", __func__);