From patchwork Fri Mar 10 13:02:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 67391 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp861565wrd; Fri, 10 Mar 2023 05:09:50 -0800 (PST) X-Google-Smtp-Source: AK7set+XyRay07TyammoGF/vdP+7kTqVWGF7qkm7jHvZ8b8jSxLC2XQ9Rt8r5YovMDzTvPksUtEV X-Received: by 2002:a62:1748:0:b0:5dc:6dec:e9b9 with SMTP id 69-20020a621748000000b005dc6dece9b9mr23747790pfx.21.1678453790208; Fri, 10 Mar 2023 05:09:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678453790; cv=none; d=google.com; s=arc-20160816; b=oMBt3LWXiAgU45zooGtb3CkWauGqUaEUkU5GwKJgm9+jHw/ORf4x621yoUG5MyN8Hl C16z4tP4vbbl2GSk5HbkQctL6SXXJWr5G5MfPPjof0ZYUlYEjzxY784o2eZkQPvSCOdu 2FDcCE5KvxKpW8ptxxituMADaobIJDJQM8htnklF9Dj0WWCm2OF/LseSj0Tilytmy1Yw IMV9xU8Bno08EyAq5+Xpvjky+fSuIxgwapsnkCuJT1aMHNkrzR0DpBFCKMEb691APyIR 4/dRLlkpqZOeucp3lRqOx+KshqbDB+TnRQCGQ7wVkI86kZxmi3RyAERks5eJpuegjKf0 3ZoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=6TtIQg09ZmPHNc7fwNMyG9gkvYgQeJ5WuDUEisBpScU=; b=VBPg0XkQL6Hs9ndep2ZQhLAihhp8LQIwng6XZTzJbC8UMoiCJzeFV8+xipqZ7LZMzz w4hrT1rP+vF4nt0U3JeeOBhCDYbkxT69e+PJsLhGZEaDQt9B2D9X+1/sytGgrOUPmvuM 2NFl1nq8rb0jUJBBUUpE04VUzgFgSfWDVOrLPp/lTeS9az4MptYrW+GUlKIDeitpuvPF DWOTAERWDwZWl8BQ2rUk0ViQTpmKaa8PAD86mVVuEgNNgT8juab7//u8D1/7o5LqVS+w /BbVXXWAp6UjofFkRMlpHm5p3GdeRfheB5kcjJpm5DaDzlyTbDiFjqsenJAsEgFvuQQ7 MJGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=nZ9APEsO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q10-20020a63e94a000000b00503a2a21d1esi1889136pgj.728.2023.03.10.05.09.35; Fri, 10 Mar 2023 05:09:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=nZ9APEsO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230184AbjCJNDL (ORCPT + 99 others); Fri, 10 Mar 2023 08:03:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229890AbjCJNDJ (ORCPT ); Fri, 10 Mar 2023 08:03:09 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.216]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D4F43423E; Fri, 10 Mar 2023 05:03:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=6TtIQ g09ZmPHNc7fwNMyG9gkvYgQeJ5WuDUEisBpScU=; b=nZ9APEsOjKa0oCV2VufXM iPmsciw9JwNWjzWhqcS3KCkJrgiOmSmpQUev6wg30ffX2OcX3MI0MdjgmPJY4/dz cN4EJ0fetkCfvQHk2wHZsFbP7Wmod9vXzh0g0howXh6gjFWobi+HadxJLt/N9+fj oOyTRGpDRvYHyOMJo4mXlc= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g2-0 (Coremail) with SMTP id _____wDXhZJnKgtkMLlkCw--.5392S2; Fri, 10 Mar 2023 21:02:32 +0800 (CST) From: Zheng Wang To: gregkh@linuxfoundation.org Cc: p.zabel@pengutronix.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH] usb: renesas_usbhs: Fix use after free bug in usbhs_remove due to race condition Date: Fri, 10 Mar 2023 21:02:30 +0800 Message-Id: <20230310130230.1732896-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wDXhZJnKgtkMLlkCw--.5392S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Ww13Gw1rKw47WF1UAw15CFg_yoW8JF4xpa 15JFy8G3yrGrWjgan2qr4UXFyrCayqgr17WrZ7WwsxuwnxAa18Za4FqF4j9r13Xa93Ja1Y v3Wvyr95CaykCFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0ziFdg_UUUUU= X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/xtbBzgAuU2I0Xl15awABs1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759986361452019890?= X-GMAIL-MSGID: =?utf-8?q?1759986361452019890?= In usbhs_probe, &priv->notify_hotplug_work is bound with usbhsc_notify_hotplug. It will be started then. If we remove the driver which will call usbhs_remove to make cleanup, there may be a unfinished work. The possible sequence is as follows: Fix it by finishing the work before cleanup in the usbhs_remove CPU0 CPU1 |usbhsc_notify_hotplug usbhs_remove | usbhs_mod_remove | usbhs_mod_gadget_remove| kfree(gpriv); | |usbhsc_hotplug |usbhs_mod_call start |usbhsg_start |usbhsg_try_start |//use gpriv Fixes: bc57381e6347 ("usb: renesas_usbhs: use delayed_work instead of work_struct") Signed-off-by: Zheng Wang --- drivers/usb/renesas_usbhs/common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c index 96f3939a65e2..17a0987ef4f5 100644 --- a/drivers/usb/renesas_usbhs/common.c +++ b/drivers/usb/renesas_usbhs/common.c @@ -768,6 +768,7 @@ static int usbhs_remove(struct platform_device *pdev) dev_dbg(&pdev->dev, "usb remove\n"); + cancel_delayed_work_sync(&priv->notify_hotplug_work); /* power off */ if (!usbhs_get_dparam(priv, runtime_pwctrl)) usbhsc_power_ctrl(priv, 0);