From patchwork Fri Mar 10 08:34:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Straube X-Patchwork-Id: 67281 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp758538wrd; Fri, 10 Mar 2023 00:55:30 -0800 (PST) X-Google-Smtp-Source: AK7set+m0cjkHzzLQjWusXeVSL8rhB4RvBImDbyyLMpHlDPKf+RoYbk6eA7z1KkNaSFcPvgP5quR X-Received: by 2002:a17:90a:359:b0:237:24a8:c5e2 with SMTP id 25-20020a17090a035900b0023724a8c5e2mr25506324pjf.40.1678438530156; Fri, 10 Mar 2023 00:55:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678438530; cv=none; d=google.com; s=arc-20160816; b=jk2fpVHS0qaGu4BTH4yBX/OdFAO5CLFPJuFyKckdTD90zZhujiPaWb1oj2fhmhm0t4 mXzpcs0djkf1IvNA1gVW/oErulNW9f8QiM/a2Gz96Yfmk0vftnYV304QOxgWPH9kK7nV AYpGS9n3Jm/3aI1+30Sg0mFoNTVkA+EQfs0lxpqijQiZlLMv4hHWvPuL2q+iVFqaLPRm SfpRNezOVoHxHibUlx4ndNkKbBSFCIZqiatOMD1virjHSiO7fKIg8QX0HYW08WvAm9nr g6S1abyzlyab6GQBjKmn/oLvq21SDubnDqPAlIdYhQFx7X4Ak+oTF0Ea7zbdUBgkE2QM i9BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qq0v9YVI3wtTDDjRzU92twoQtmr2PxAaTyrW0UMmWQw=; b=H4NAXOGl78s4Iw0ef53IqsUg6cTecSVs6wPG04+5FnpjsewH/Nzcp7kEeqQP0J4Kgg UOvqZVv6gw9048jWBIEIqJ6V3n6sKuhQ+QQEPpfh3VsXc8dMmAWCeUPLevyIW/zR6yrA YDhpjhMvu/tr3Qp2DqxNGvbbwGMErdjfkpfn/AdkHnUGkSS9UtxRpDE44f5v1x/xiENI XKj01NYbRLWZipzo4R/lSXlTDFIyXpP7wvgEJ1JzCbZqsJcT74FjJTVY8oHRlPIwclfg lhszcFfJWLikuiZSZViH60VRJ1Z9jNKLYS/ZOO28RK7KihTiJwibFTPTlvZOWVc0cr+T ghbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=DPozms87; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kh15-20020a170903064f00b0019e608da5absi1588017plb.322.2023.03.10.00.55.17; Fri, 10 Mar 2023 00:55:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=DPozms87; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231201AbjCJIfV (ORCPT + 99 others); Fri, 10 Mar 2023 03:35:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230444AbjCJIfJ (ORCPT ); Fri, 10 Mar 2023 03:35:09 -0500 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 744EC57D27 for ; Fri, 10 Mar 2023 00:35:07 -0800 (PST) Received: by mail-ed1-x529.google.com with SMTP id x3so17303464edb.10 for ; Fri, 10 Mar 2023 00:35:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678437306; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qq0v9YVI3wtTDDjRzU92twoQtmr2PxAaTyrW0UMmWQw=; b=DPozms87b/PKkkvHKub1WKUztXE4+jPb5NnQzzW1kMEuhkF8hKSWBzkPblC7l61XQh EZ1IRrjDeI6vRq9phb5K1GGpS+AbLi8zw0oHClXEhj+1S/M50sK6Zh87BFVW8E/x1k86 GPNd3m060qI+rO6sDrrMjMqBIjYU5L0drL2gxFllMpKGHFfM6Ib4pIGPrHMslE4+1xS7 IPPJxK0q+RZLSIQg8FCsIpBBqs8h+Gwp/umX+b9Mhp0jaWndX2nPWxVv7fpU6/ZKK7xn EzRJ/uL5ZIzsIfu46DzMC6ihuntdr1MWemfP1ze9dgz+6G5NssJ18c5vqAveeFWzRxqS HsZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678437306; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qq0v9YVI3wtTDDjRzU92twoQtmr2PxAaTyrW0UMmWQw=; b=z/7cIWcy4nLDGP5x26av/tWp02wg/wL8hejf2fqjgYqTEp/yNPkKPFePeHowv4fWzi 3REZ9oiIirRK4oIgPBxkcnEx76m8OHnfE6PAD7jMcd8oHQLOCJfA8bfUfEfO3/9iHqFv AYX2EN2OiRaNFJuk6R7I9LLiL6909FpaGbN1bgaO9g7+4H3mnFRioe547MNf6molQ5qc JHSb0qIKkwC4N/D8DU0gNKiCs21EO4jyznIPNqjU4yg9U1mvDr++dILf4b08rlTPXqdd YUjqNG8KV136hlb1X7roL6LKP7jFWdIHkF+nwuJVDdY6meAOwTkIbbVgadc4Jcnu5IkY x3xA== X-Gm-Message-State: AO0yUKWHF64w4MYAV7VD9Mec8y/BHKY7qdb+nya22LmyNs294miaH50d cAMPDNkrimHyRBi0bBzBsrE= X-Received: by 2002:a17:906:6d85:b0:8c3:3439:24d9 with SMTP id h5-20020a1709066d8500b008c3343924d9mr19667016ejt.24.1678437306035; Fri, 10 Mar 2023 00:35:06 -0800 (PST) Received: from localhost.localdomain (ip5f5abbd3.dynamic.kabel-deutschland.de. [95.90.187.211]) by smtp.gmail.com with ESMTPSA id h10-20020a17090619ca00b008ce5b426d77sm697888ejd.13.2023.03.10.00.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 00:35:05 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 1/5] staging: rtl8723bs: MapCharToHexDigit() is not used Date: Fri, 10 Mar 2023 09:34:45 +0100 Message-Id: <20230310083449.23775-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230310083449.23775-1-straube.linux@gmail.com> References: <20230310083449.23775-1-straube.linux@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759970360494645112?= X-GMAIL-MSGID: =?utf-8?q?1759970360494645112?= The function MapCharToHexDigit() is not used anywhere, remove it. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/hal/hal_com.c | 16 ---------------- drivers/staging/rtl8723bs/include/hal_com.h | 2 -- 2 files changed, 18 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c index e42556d03bce..b74817fc4316 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -859,22 +859,6 @@ bool eqNByte(u8 *str1, u8 *str2, u32 num) return true; } -/* */ -/* Description: */ -/* Translate a character to hex digit. */ -/* */ -u32 MapCharToHexDigit(char chTmp) -{ - if (chTmp >= '0' && chTmp <= '9') - return chTmp - '0'; - else if (chTmp >= 'a' && chTmp <= 'f') - return 10 + (chTmp - 'a'); - else if (chTmp >= 'A' && chTmp <= 'F') - return 10 + (chTmp - 'A'); - else - return 0; -} - bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8 *pInt) { u16 i = 0; diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/rtl8723bs/include/hal_com.h index 6356b8c2ef81..8a7d31d1eaca 100644 --- a/drivers/staging/rtl8723bs/include/hal_com.h +++ b/drivers/staging/rtl8723bs/include/hal_com.h @@ -147,8 +147,6 @@ u8 GetHalDefVar(struct adapter *adapter, enum hal_def_variable variable, bool eqNByte(u8 *str1, u8 *str2, u32 num); -u32 MapCharToHexDigit(char chTmp); - bool ParseQualifiedString(char *In, u32 *Start, char *Out, char LeftQualifier, char RightQualifier);