From patchwork Thu Mar 9 18:38:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 67068 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp457905wrd; Thu, 9 Mar 2023 10:51:35 -0800 (PST) X-Google-Smtp-Source: AK7set/pY6ZjYOWSwcvQ+JHK1izCm6cvgJ/QSNHBHtX8ExzFnaOWe/tKMK9RaUP5xSlrwcv6RUWS X-Received: by 2002:a17:903:1c1:b0:19e:6700:174 with SMTP id e1-20020a17090301c100b0019e67000174mr27984405plh.25.1678387895076; Thu, 09 Mar 2023 10:51:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678387895; cv=none; d=google.com; s=arc-20160816; b=wiHnFPsIGxsnDVG0BUpInlnuTfAaf5Lwm9IFut17tqEFPOjLGBK9PicWa4MzS4Eorg 1JbE1ypHLpMY2k4wv/MMxZ9qLrG0h/xbgrIkdtnHqDho5l7HDuEtysI0dh6tC9rIxCQj aT1zmFQ170lwdBD7wpzCjCgrHJb2ZUN6AVCa3gyq8XEuwbPBq0Dgb4TZNCfsjIaLvAvH nZb5rYVrhTPsCQLbh2vvChEDwQZz/EBYPdasRKNnUOAwZRKYmyAM7T0yuIeFkhVrfgGq PZL4N/Gza+bU2uPghKn1xRFmtAXQLmjPY8oOGeOymAwudHNChw4DBiXe/3r9flPtAWn6 z1xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LmXrypUhkfQZNqHBXt/FnFD1GHWz24KdFa4arN1jaDs=; b=bKJGv8v17FFUDESuZF/mPhQL4nIqhjTfR4P80ha14EP02Pa71dpbZo2QjvdZkFWB4S nKSusqhLzw6AfqLIb1jnjEUnxgdq+oPKe7/kKbs3qvGxudBGs/fBJP/ahdMC30T5aig5 h89P1j69DriPE02iQFoHObne2HdEZvMxlci1qmx+UymGdPLpc4jsKRPSsEXYz8TgRyVu +Z94tme0AGvIhOWfd/Hexjry631nxCOe4dtRG2BDfbX2lKDGBM4h6dKt1Sez8Ytl78OW tneZhQnCicm/I4ylB5xKvcOe49zEptgOCyBH2Bpak0FP29TZd82PVOzkVI1sIIByCW8h gv1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=OeGEkv9b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c5-20020a170903234500b0019a7ef5e9acsi6836plh.305.2023.03.09.10.51.20; Thu, 09 Mar 2023 10:51:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=OeGEkv9b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230119AbjCISib (ORCPT + 99 others); Thu, 9 Mar 2023 13:38:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229870AbjCISia (ORCPT ); Thu, 9 Mar 2023 13:38:30 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CDF7FF16BD; Thu, 9 Mar 2023 10:38:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=LmXry pUhkfQZNqHBXt/FnFD1GHWz24KdFa4arN1jaDs=; b=OeGEkv9b2LimBM9xgXpwk olYySl+AaRQp/4TBZNoRWsvyDb4bS3atoHeRy5n+BunTBSemigD1Iv08CO+eS1rw mDPXgA717P625BEjaXGNYbaZpi7F/Kohtam2Mi0n6YQhQqM8AHLa4YXpwLpdfk7x 3n8Pp/UUoJCdUNI0ZAbvIk= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g2-0 (Coremail) with SMTP id _____wCXBZ6VJwpkAS33Cg--.7263S2; Fri, 10 Mar 2023 02:38:13 +0800 (CST) From: Zheng Wang To: njavali@marvell.com Cc: mrangankar@marvell.com, GR-QLogic-Storage-Upstream@marvell.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH] scsi: qla4xxx: Fix use after free bug in da9150_charger_remove due to race condition Date: Fri, 10 Mar 2023 02:38:12 +0800 Message-Id: <20230309183812.299349-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wCXBZ6VJwpkAS33Cg--.7263S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKFyUKw1xtw4rAr1UWFy3Jwb_yoWkWrX_C3 yqvryxKr1aqr4kKr17Xr13ArWxWF4kXF90kFyrtF13AFy5uwn3X3yDuFZ0vw4UG39FyFy3 Cw1jyrW5Zrn8KjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRMwZ2DUUUUU== X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiQhctU1aEEmt7MAAAsL X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759917265387859092?= X-GMAIL-MSGID: =?utf-8?q?1759917265387859092?= In qla4xxx_probe_adapter, &ha->dpc_work is bound with qla4xxx_do_dpc. qla4xxx_post_aen_work may be called to start the work. If we remove the module which will call qla4xxx_remove_adapter to make cleanup, there may be a unfinished work. The possible sequence is as follows: Fix it by canceling the work before cleanup in qla4xxx_remove_adapter CPU0 CPUc1 |qla4xxx_do_dpc qla4xxx_remove_adapter| scsi_remove_host | kfree(ha->host) | | | iscsi_host_for_each_session | //use ha->host Fixes: afaf5a2d341d ("[SCSI] Initial Commit of qla4xxx") Signed-off-by: Zheng Wang --- drivers/scsi/qla4xxx/ql4_os.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 005502125b27..d530cc853f43 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -9001,6 +9001,7 @@ static void qla4xxx_remove_adapter(struct pci_dev *pdev) if (!pci_is_enabled(pdev)) return; + cancel_work_sync(&ha->dpc_work); ha = pci_get_drvdata(pdev); if (is_qla40XX(ha))