From patchwork Thu Mar 9 17:43:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Korotkov X-Patchwork-Id: 67064 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp435076wrd; Thu, 9 Mar 2023 10:05:16 -0800 (PST) X-Google-Smtp-Source: AK7set8pNMuQ8aVLPsr/PKepmICggPWakWq3jAo71cbNi6lH3NCpCj73eOoVVRmLd5Q9qpXv7y9b X-Received: by 2002:a05:6e02:1522:b0:317:9945:6054 with SMTP id i2-20020a056e02152200b0031799456054mr18120683ilu.9.1678385115960; Thu, 09 Mar 2023 10:05:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678385115; cv=none; d=google.com; s=arc-20160816; b=zfe4YomH68a6fVfDYYSpf0I3ytDvHFVk+lqyvZ4K+EVVnwoRvvQcdj6X/5EEJ4LXdW MNtRzYwi0IV7+4wvs71Epx2p7PlPyeaCZy4M7aSbisqCijoLzTj8Ih0AgLU31/BsCMXT DoGVeN+TFxJZexr/Ldy1P5UhorpppR/bTFH88B3H/VLlj/QrZMddP55pEyt8kxnOGDn6 1MJ70Zn15O2oDzQt4l+h/ZsI4cWrfbjRKtGuQ/59vH0KNofRbP0EK+Uqutn7ryCF52aX yPbEGl1TnicipVKT5hyVo1Ng8e1tB1tZj/NIbKbm8hym0nvtfV10GM/zRtpBvMuv4zM/ Fb3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=1XQk2zEiV+dJ+pQWsXM/szRvf3lCRM8FE84GMsL/aVY=; b=IHa7oyb1uq/+a/+j0Z64VyMpdDjvpMyuaCn7yDarDGsJdVB332C1nJJs5mAoor/+KJ qr7m0ZqI7q4YNtWT/vjTCkIjLqB9AiksQJ579pMbMczv8iHQtaXMKDHUqiyITpi8SjkU X+5FU1gJuExC58mDs5IAA/PhrIXXVyleGryxvTNpl4Ra6IQFf3E5dShmqaz86LxroR6n Ji4RMFrHkePzD0q/Vl/btYiwA/s/8gEqBoL2BrVksMQg+tp7gRSZYEH5uVjsItPrVeb8 eMOuzkc5w75inbgh3lTvkkUdQgwMG6T2o/jFU4dOCT8MXJroQrnNOK4gZkDrj7u4jyN9 LNWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=CXbIn7as; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h12-20020a0566380f8c00b003c4d5938504si18444635jal.3.2023.03.09.10.04.59; Thu, 09 Mar 2023 10:05:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=CXbIn7as; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230232AbjCIRoQ (ORCPT + 99 others); Thu, 9 Mar 2023 12:44:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230085AbjCIRoN (ORCPT ); Thu, 9 Mar 2023 12:44:13 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A097A6591; Thu, 9 Mar 2023 09:44:10 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id f18so3326288lfa.3; Thu, 09 Mar 2023 09:44:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678383849; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1XQk2zEiV+dJ+pQWsXM/szRvf3lCRM8FE84GMsL/aVY=; b=CXbIn7ashUb6ON6IfSbY7/ivlL+O/FblWeeJz85sQhf0LACl7RGCkPf9/twaXPOl+N +haJpqrpy3p0njsJbRPwGMiQ2TU2ymk6BYlI2OT11yLoEDP1y0C2hIBP7kG3G+0Ruwy9 OlUWsDEfAOR8qU2Su1iEyTKB5MWo+Kx3+4KAB2vg9rbs1iTrqe5AYxOiPGnKwEBPx5wT JwK+/OV7CCBpQyHrF/6J7SSJvzQfDk43pI8vGLfS46FT3Jwz+ty+FbHx2CyoOLTAjTnw K3gKhNk5nBv88d85yIWoDU4k5VNJTe9u+XN6YQ3ho+M+dwHt7CrHOGxnQlGn+R9Hg0Vo E2zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678383849; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1XQk2zEiV+dJ+pQWsXM/szRvf3lCRM8FE84GMsL/aVY=; b=A/+QLsbHyjQ04IijC7SqA0mrLPjrqT2Z0e8C2VW3r+PXT5o4ir/AjPuvoMgP4Jy4Qp oNKzXcEZXDUqmxX1EGk/0HMF3fQgiJYubIQIc8xgcHf2JziLuTKA/6dZVjj6kqUgNdw9 OP8uXFp80H6tlHP7TJvBJ9jQI/Oeb4ZcGduFpCwlBCpJnlvsmhSkPkrg3pWC62lmOjWQ tbabLCdKe6OjZhyIygkwcnI4cTDgU78IVUmimox4nG3z7R/1s3/tFBr711YDlISe20Hi d7aZX6EeyG28lmi4NfEpSjmmYEUEQHO9ZjFmD7H2kC7lxvEiMDnfoiW0B9EZunzswYEf m6vg== X-Gm-Message-State: AO0yUKU9kORRH3F5GssxWQYCIb7LYPuEg2Fg/+FZ1LjArZTPSSdktBrJ y/CFg7r20qSb6tKYvakVGZM= X-Received: by 2002:ac2:4255:0:b0:4cb:2aa:9e58 with SMTP id m21-20020ac24255000000b004cb02aa9e58mr6564361lfl.13.1678383848793; Thu, 09 Mar 2023 09:44:08 -0800 (PST) Received: from mkor.. (89-109-45-204.dynamic.mts-nn.ru. [89.109.45.204]) by smtp.gmail.com with ESMTPSA id y27-20020ac255bb000000b004b59067142bsm2718619lfg.8.2023.03.09.09.44.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 09:44:08 -0800 (PST) From: Maxim Korotkov To: Michael Chan Cc: Maxim Korotkov , Pavan Chebbi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH next-next] bnxt: avoid overflow in bnxt_get_nvram_directory() Date: Thu, 9 Mar 2023 20:43:47 +0300 Message-Id: <20230309174347.3515-1-korotkov.maxim.s@gmail.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759914351026895248?= X-GMAIL-MSGID: =?utf-8?q?1759914351026895248?= The value of an arithmetic expression is subject of possible overflow due to a failure to cast operands to a larger data type before performing arithmetic. Used macro for multiplication instead operator for avoiding overflow. Found by Security Code and Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Maxim Korotkov Reviewed-by: Pavan Chebbi --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index ec573127b707..696f32dfe41f 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -2862,7 +2862,7 @@ static int bnxt_get_nvram_directory(struct net_device *dev, u32 len, u8 *data) if (rc) return rc; - buflen = dir_entries * entry_length; + buflen = mul_u32_u32(dir_entries, entry_length); buf = hwrm_req_dma_slice(bp, req, buflen, &dma_handle); if (!buf) { hwrm_req_drop(bp, req);