From patchwork Thu Mar 9 16:01:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 66953 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp377248wrd; Thu, 9 Mar 2023 08:12:05 -0800 (PST) X-Google-Smtp-Source: AK7set9jRi6TjZuZNRkt2c8XRygKOKxzXWzX0OLkko75ZLjo3xLjpj8tkWRI4cFg8DnJWThQq/nk X-Received: by 2002:a05:6a20:430f:b0:d0:4361:9720 with SMTP id h15-20020a056a20430f00b000d043619720mr9986853pzk.61.1678378325087; Thu, 09 Mar 2023 08:12:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678378325; cv=none; d=google.com; s=arc-20160816; b=dKkLmmXMxUp8XnulLKRlfE8jaJj3Lpn2H/9p6Str92xGqFJsYQvYY2iPpymuE+mhsC f71OgYSYKYWjyF9+L2pSLkGfPqDrlUOHuMfOtlvSDjJp/r7DUruD8W81qf9j0rrLyCPo xMSjvOcis7XzhNzr+yBwmGYpWkP/tJTXARGuaPZ9zk9WDPtngw8KucRxm9i5umDtfoqp qXBbakjzmz9XgxZpmf8yvxmom8vOqJwP+sUATFHQQURXkNSYOURD3RuLrkBkndpBHXOI 5lXwmb/3tCUxu3DepbpdX4IkTQ2oPS0IVYY4R6fD7/jf8YBPxH4iOiCyQjKP86qIN3wA tUsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=vc3MhzDf1ytnsAQte0if7o8oovAVmX2ICQWxWSrkdIk=; b=A7qk+bY7DPpt18Fi5UsCp0l1gWO33XslorDWrrRHK+LZ7tUVRQLzuIXqNKWb2vxCLZ dXkEvQl5CZg0rDenrmMLnDx+VRAIxh8AXiDJU3dxtluaM41k4Wh58u+pY+OCtRxT9HuB knisdOdQngfgVgXJxvy4Z+LQztHQ+7Y7eHW+hHQuaLNheP2ZASTXx6AKwSlGF5KSfanY IQmq/05pmDn8OG7psA5w6QFBGa30xuY1lpCEqP6+Y1+dSM1uEOq/RkFy/Wbz4Ms8lUt3 o58a9mAu0GrL4mXL4zfbsNv+z9AM2MwsqaOBq0PQio054fzyRuNL5BnKOuB1/8qseWZ+ wZIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=FiIMR8Ip; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=DpafcnkE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b141-20020a621b93000000b0056c231e4447si2362648pfb.198.2023.03.09.08.11.45; Thu, 09 Mar 2023 08:12:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=FiIMR8Ip; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=DpafcnkE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232483AbjCIQKW (ORCPT + 99 others); Thu, 9 Mar 2023 11:10:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231764AbjCIQCl (ORCPT ); Thu, 9 Mar 2023 11:02:41 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3252EF63A3; Thu, 9 Mar 2023 08:02:40 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DAF912216A; Thu, 9 Mar 2023 16:02:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678377758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vc3MhzDf1ytnsAQte0if7o8oovAVmX2ICQWxWSrkdIk=; b=FiIMR8Ipp0/ClhsoBteb/TvJRP0rhUbP77FigucWxvGsSnBXDm5mji5cyXuX5Dgt1z54Aw CEsrVTLMb3ftymT/7LOvI29Y/RpcTSYV+SULwqpDyPf+IoE82APXQYFfh8i9g0KstECaVl OhkN5jXd7y617eM7cMxRmGHC6h+GUHE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678377758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vc3MhzDf1ytnsAQte0if7o8oovAVmX2ICQWxWSrkdIk=; b=DpafcnkE6VWfFGcvZg5uAQpABZ6r8j3l67ZybvrYWYYSn5NnlszCl9POswvSGQpfn/LcKM whxPMWE1BywtHAAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7E75F13A73; Thu, 9 Mar 2023 16:02:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aBb6HR4DCmQHbgAAMHmgww (envelope-from ); Thu, 09 Mar 2023 16:02:38 +0000 From: Thomas Zimmermann To: deller@gmx.de, geert+renesas@glider.be, timur@kernel.org, rdunlap@infradead.org, paulus@samba.org, benh@kernel.crashing.org, linux@armlinux.org.uk, pjones@redhat.com, adaplas@gmail.com, s.hauer@pengutronix.de, shawnguo@kernel.org, mbroemme@libmpq.org, thomas@winischhofer.net, James.Bottomley@HansenPartnership.com, sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, corbet@lwn.net Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v2 085/101] fbdev/tridentfb: Duplicate video-mode option string Date: Thu, 9 Mar 2023 17:01:45 +0100 Message-Id: <20230309160201.5163-86-tzimmermann@suse.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230309160201.5163-1-tzimmermann@suse.de> References: <20230309160201.5163-1-tzimmermann@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759907230588789476?= X-GMAIL-MSGID: =?utf-8?q?1759907230588789476?= Assume that the driver does not own the option string or its substrings and hence duplicate the option string for the video mode. Allocate the copy's memory with kstrdup() and free it in the module's exit function. Done in preparation of switching the driver to struct option_iter and constifying the option string. v2: * replace static memory with kstrdup()/kfree() (Geert) Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/tridentfb.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c index 6099b9768ba1..dbde64aef91f 100644 --- a/drivers/video/fbdev/tridentfb.c +++ b/drivers/video/fbdev/tridentfb.c @@ -61,6 +61,7 @@ static struct fb_fix_screeninfo tridentfb_fix = { /* defaults which are normally overriden by user values */ /* video mode */ +static char *mode_option_buf; static char *mode_option; static int bpp = 8; @@ -1800,8 +1801,11 @@ static int __init tridentfb_setup(char *options) memdiff = simple_strtoul(opt + 8, NULL, 0); else if (!strncmp(opt, "nativex=", 8)) nativex = simple_strtoul(opt + 8, NULL, 0); - else - mode_option = opt; + else { + kfree(mode_option_buf); + mode_option_buf = kstrdup(opt, GFP_KERNEL); // ignore errors + mode_option = mode_option_buf; + } } return 0; } @@ -1827,6 +1831,7 @@ static int __init tridentfb_init(void) static void __exit tridentfb_exit(void) { pci_unregister_driver(&tridentfb_pci_driver); + kfree(mode_option_buf); } module_init(tridentfb_init);