From patchwork Thu Mar 9 16:01:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 67020 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp389846wrd; Thu, 9 Mar 2023 08:35:46 -0800 (PST) X-Google-Smtp-Source: AK7set+q8qy6p8UDnOFVUA7heHGWtUIzy9agY+GwvN5EEg444b8cOTfHud3oFoMB5z+7Ogzt1kBM X-Received: by 2002:a05:6a20:3941:b0:cc:7c25:2e1c with SMTP id r1-20020a056a20394100b000cc7c252e1cmr5720392pzg.13.1678379746281; Thu, 09 Mar 2023 08:35:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678379746; cv=none; d=google.com; s=arc-20160816; b=Bq2YsbMHF9TZic9nDUZqOUnnINgQ69ex+HuUk/lJvwYcYqObweUZ8DE5cD6sbae3fW fSs0CG4QBJblKftQXc1A5nCJ61kl9rrn2LI5sephcb6jOTBh8YMuNfb0Onn4lxV0FoQP THAxHt+gzmBIpi1Sz2aBDh3Hf6KSZxyTuZTyTUqLO6WoqkJH7DZ9H6ygr6bTD3Xh6dv5 Yifu1f2mD+ECom2D6o1ZMTB4j+sxKc1y0gTsA/6F+jlXJ8ger12y5e5mHB2wzNeaInEG o7MkcmE+vVvXshKo7Ewz4N28rJpFH2MdX0UHEGh05B8oXqWQMMhSnfduPEGh8dDPvu1f 0PwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=i5PgfaO6hx580hMewU4zouv2NIVdCtMZiQTH6Xeh3Y0=; b=jgPRFpR/GNF4AyXmCf7dBh3ZjOtkET3b8Hu8CEwrQEXLv72nasjYZ0lVKamPagnniX TfK8+jjTBP1oNHfCiYBzNcfFqbp5HNaLQfw57FffRyRLW+qSgrCQxDUBN1/Tar/x6XQv J424Wmk/U1o7PSGM6wS458e3CHK4GZd6pn+NXYDFS5clUaNkqPv+hcXK24Ba4An0o99s 0JUg9z2xsiBIfply7tE07DgiUzUopZnjaJ3kG28kEggAlPMai5V9ghfQQiUZBs4XIyQS cIMtwiT9XuTxOUO4lJ3T+Fn8q7Zq+dikjMSWldmAYJXuH0XDOkSPU6xBnej9MkaVLYfm khEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=OxplyLZ8; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=4s08p0a2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c12-20020aa7952c000000b005a8ee84ba02si17989217pfp.310.2023.03.09.08.35.33; Thu, 09 Mar 2023 08:35:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=OxplyLZ8; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=4s08p0a2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231340AbjCIQGU (ORCPT + 99 others); Thu, 9 Mar 2023 11:06:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231649AbjCIQCX (ORCPT ); Thu, 9 Mar 2023 11:02:23 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C90D2F786F; Thu, 9 Mar 2023 08:02:22 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6E20322155; Thu, 9 Mar 2023 16:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678377741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i5PgfaO6hx580hMewU4zouv2NIVdCtMZiQTH6Xeh3Y0=; b=OxplyLZ8PZLhwMHdW9CSfy3+3/6UPfg4V0ga+qxHNiA+/tEAib/yIpRxC9NncZ3bI9EHok 3KkgvPls3saHo/wvZrG1YKCkendDAjEIlUBmN9gdGVqjsb5vAyxBtN/LpOwja2NkboYzbh 7na0S+K24HgdL1DpMBNn8MhFdGrMxJc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678377741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i5PgfaO6hx580hMewU4zouv2NIVdCtMZiQTH6Xeh3Y0=; b=4s08p0a2T6+MyG/KDAuw9YiK+s+lyGGLLBa9SNu/Ciee0vTt9foheCqlwknCIBVOBnvYem 1V1zhtFa9nZfoFAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1262D13A73; Thu, 9 Mar 2023 16:02:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qIInAw0DCmQHbgAAMHmgww (envelope-from ); Thu, 09 Mar 2023 16:02:21 +0000 From: Thomas Zimmermann To: deller@gmx.de, geert+renesas@glider.be, timur@kernel.org, rdunlap@infradead.org, paulus@samba.org, benh@kernel.crashing.org, linux@armlinux.org.uk, pjones@redhat.com, adaplas@gmail.com, s.hauer@pengutronix.de, shawnguo@kernel.org, mbroemme@libmpq.org, thomas@winischhofer.net, James.Bottomley@HansenPartnership.com, sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, corbet@lwn.net Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v2 041/101] fbdev/kyrofb: Duplicate video-mode option string Date: Thu, 9 Mar 2023 17:01:01 +0100 Message-Id: <20230309160201.5163-42-tzimmermann@suse.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230309160201.5163-1-tzimmermann@suse.de> References: <20230309160201.5163-1-tzimmermann@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759908720408202347?= X-GMAIL-MSGID: =?utf-8?q?1759908720408202347?= Assume that the driver does not own the option string or its substrings and hence duplicate the option string for the video mode. Allocate the copy's memory with kstrdup() and free it in the module's exit function. Done in preparation of switching the driver to struct option_iter and constifying the option string. v2: * replace static memory with kstrdup()/kfree() (Geert) Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/kyro/fbdev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/kyro/fbdev.c b/drivers/video/fbdev/kyro/fbdev.c index 0596573ef140..97f4d8995e36 100644 --- a/drivers/video/fbdev/kyro/fbdev.c +++ b/drivers/video/fbdev/kyro/fbdev.c @@ -79,6 +79,7 @@ typedef struct { /* global graphics card info structure (one per card) */ static device_info_t deviceInfo; +static char *mode_option_buf; static char *mode_option = NULL; static int nopan = 0; static int nowrap = 1; @@ -579,7 +580,9 @@ static int __init kyrofb_setup(char *options) } else if (strcmp(this_opt, "nomtrr") == 0) { nomtrr = 1; } else { - mode_option = this_opt; + kfree(mode_option_buf); + mode_option_buf = kstrdup(this_opt, GFP_KERNEL); // ignore errors + mode_option = mode_option_buf; } } @@ -805,6 +808,7 @@ static int __init kyrofb_init(void) static void __exit kyrofb_exit(void) { pci_unregister_driver(&kyrofb_pci_driver); + kfree(mode_option_buf); } module_init(kyrofb_init);